[v3,net-next,0/6] skbuff: micro-optimize flow dissection

Message ID	20210314111027.7657-1-alobakin@pm.me
Headers	show Return-Path: <netdev-owner@kernel.org> Date: Sun, 14 Mar 2021 11:10:51 +0000 To: "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> From: Alexander Lobakin <alobakin@pm.me> Cc: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>, John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>, Jonathan Lemon <jonathan.lemon@gmail.com>, Alexander Lobakin <alobakin@pm.me>, Eric Dumazet <edumazet@google.com>, Willem de Bruijn <willemb@google.com>, Kevin Hao <haokexin@gmail.com>, Pablo Neira Ayuso <pablo@netfilter.org>, Jakub Sitnicki <jakub@cloudflare.com>, Marco Elver <elver@google.com>, Dexuan Cui <decui@microsoft.com>, Vladimir Oltean <vladimir.oltean@nxp.com>, Ariel Levkovich <lariel@mellanox.com>, Wang Qing <wangqing@vivo.com>, Davide Caratti <dcaratti@redhat.com>, Guillaume Nault <gnault@redhat.com>, Eran Ben Elisha <eranbe@nvidia.com>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Kirill Tkhai <ktkhai@virtuozzo.com>, Bartosz Golaszewski <bgolaszewski@baylibre.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Reply-To: Alexander Lobakin <alobakin@pm.me> Subject: [PATCH v3 net-next 0/6] skbuff: micro-optimize flow dissection Message-ID: <20210314111027.7657-1-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk
Series	skbuff: micro-optimize flow dissection \| expand [v3,net-next,0/6] skbuff: micro-optimize flow dissection [v3,net-next,2/6] skbuff: make __skb_header_pointer()'s data argument const [v3,net-next,4/6] linux/etherdevice.h: misc trailing whitespace cleanup [v3,net-next,6/6] skbuff: micro-optimize {,__}skb_header_pointer()

Message ID

20210314111027.7657-1-alobakin@pm.me

Headers

Date: Sun, 14 Mar 2021 11:10:51 +0000
To: "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>
From: Alexander Lobakin <alobakin@pm.me>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>, KP Singh <kpsingh@kernel.org>,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Alexander Lobakin <alobakin@pm.me>, Eric Dumazet <edumazet@google.com>,
	Willem de Bruijn <willemb@google.com>, Kevin Hao <haokexin@gmail.com>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Jakub Sitnicki <jakub@cloudflare.com>, Marco Elver <elver@google.com>,
	Dexuan Cui <decui@microsoft.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Ariel Levkovich <lariel@mellanox.com>, Wang Qing <wangqing@vivo.com>,
	Davide Caratti <dcaratti@redhat.com>,
	Guillaume Nault <gnault@redhat.com>, Eran Ben Elisha <eranbe@nvidia.com>,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Kirill Tkhai <ktkhai@virtuozzo.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Reply-To: Alexander Lobakin <alobakin@pm.me>
Subject: [PATCH v3 net-next 0/6] skbuff: micro-optimize flow dissection
Message-ID: <20210314111027.7657-1-alobakin@pm.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Series

skbuff: micro-optimize flow dissection | expand

Message

Alexander Lobakin March 14, 2021, 11:10 a.m. UTC

This little number makes all of the flow dissection functions take
raw input data pointer as const (1-5) and shuffles the branches in
__skb_header_pointer() according to their hit probability.

The result is +20 Mbps per flow/core with one Flow Dissector pass
per packet. This affects RPS (with software hashing), drivers that
use eth_get_headlen() on their Rx path and so on.