mbox series

[net,0/3] Netfilter fixes for net

Message ID 20210103192920.18639-1-pablo@netfilter.org
Headers show
Series Netfilter fixes for net | expand

Message

Pablo Neira Ayuso Jan. 3, 2021, 7:29 p.m. UTC
Hi Jakub, David,

The following patchset contains Netfilter fixes for net:

1) Missing sanitization of rateest userspace string, bug has been
   triggered by syzbot, patch from Florian Westphal.

2) Report EOPNOTSUPP on missing set features in nft_dynset, otherwise
   error reporting to userspace via EINVAL is misleading since this is
   reserved for malformed netlink requests.

3) New binaries with old kernels might silently accept several set
   element expressions. New binaries set on the NFT_SET_EXPR and
   NFT_DYNSET_F_EXPR flags to request for several expressions per
   element, hence old kernels which do not support for this bail out
   with EOPNOTSUPP.

Please, pull these changes from:

  git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git

Thanks!

P.S: Best wishes for 2021.

----------------------------------------------------------------

The following changes since commit 1f45dc22066797479072978feeada0852502e180:

  ibmvnic: continue fatal error reset after passive init (2020-12-23 12:56:10 -0800)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git HEAD

for you to fetch changes up to b4e70d8dd9ea6bd5d5fb3122586f652326ca09cd:

  netfilter: nftables: add set expression flags (2020-12-28 10:50:26 +0100)

----------------------------------------------------------------
Florian Westphal (1):
      netfilter: xt_RATEEST: reject non-null terminated string from userspace

Pablo Neira Ayuso (2):
      netfilter: nft_dynset: report EOPNOTSUPP on missing set feature
      netfilter: nftables: add set expression flags

 include/uapi/linux/netfilter/nf_tables.h |  3 +++
 net/netfilter/nf_tables_api.c            |  6 +++++-
 net/netfilter/nft_dynset.c               | 15 ++++++++++-----
 net/netfilter/xt_RATEEST.c               |  3 +++
 4 files changed, 21 insertions(+), 6 deletions(-)

Comments

Jakub Kicinski Jan. 4, 2021, 11:04 p.m. UTC | #1
On Sun,  3 Jan 2021 20:29:17 +0100 Pablo Neira Ayuso wrote:
> Hi Jakub, David,

> 

> The following patchset contains Netfilter fixes for net:

> 

> 1) Missing sanitization of rateest userspace string, bug has been

>    triggered by syzbot, patch from Florian Westphal.

> 

> 2) Report EOPNOTSUPP on missing set features in nft_dynset, otherwise

>    error reporting to userspace via EINVAL is misleading since this is

>    reserved for malformed netlink requests.

> 

> 3) New binaries with old kernels might silently accept several set

>    element expressions. New binaries set on the NFT_SET_EXPR and

>    NFT_DYNSET_F_EXPR flags to request for several expressions per

>    element, hence old kernels which do not support for this bail out

>    with EOPNOTSUPP.

> 

> Please, pull these changes from:

> 

>   git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git


Pulled, thanks!

> P.S: Best wishes for 2021.


Happy 2021!