Message ID | 20210103112542.35149-1-samuel@sholland.org |
---|---|
Headers | show |
Series | dwmac-sun8i cleanup and shutdown hook | expand |
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland <samuel@sholland.org> wrote: > > Use the appropriate function instead of reimplementing it, > and update the error message to match the code. > > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland <samuel@sholland.org> wrote: > > Adjust the spacing and use an explicit "return 0" in the success path > to make the function easier to parse. > > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
On Sun, Jan 3, 2021 at 7:25 PM Samuel Holland <samuel@sholland.org> wrote: > > The Ethernet MAC and PHY are usually major consumers of power on boards > which may not be able to fully power off (that have no PMIC). Powering > down the MAC and internal PHY saves power while these boards are "off". > > Signed-off-by: Samuel Holland <samuel@sholland.org> Reviewed-by: Chen-Yu Tsai <wens@csie.org>