| Message ID | 20201102222338.1442081-1-anthony.l.nguyen@intel.com |
|---|---|
| Headers | show |
| Series | 100GbE Intel Wired LAN Driver Updates 2020-11-02 | expand |
On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote: > This series contains updates to ice driver only. ... > Tony renames Flow Director functions to be more generic as their use > is expanded. > > Real expands ntuple support to allow for mask values to be specified. > This > is done by implementing ACL filtering in HW. > This is a lot of code with only 2 liner commit messages! Can you please shed more light on what user interface is being used to program and manage those ACLs, i see it is ethtool from the code but the cover letter and commit messages do not provide any information about that. Also could you please explain what ethtool interfaces/commands are being implemented, in the commit messages or cover letter, either is fine. Thanks!
On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote: > From: Jacob Keller <jacob.e.keller@intel.com> > > When printing messages with ice_debug, align the printed string to > the > origin line of the message in order to ease debugging and tracking > messages back to their source. > Just out of curiosity, you are only re-aligning the code and not the printed messages themselves. How would this help ? did you mean help with tracking the sources when doing grep like operations on the source code ?
On 11/2/2020 3:07 PM, Saeed Mahameed wrote: > On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote: >> From: Jacob Keller <jacob.e.keller@intel.com> >> >> When printing messages with ice_debug, align the printed string to >> the >> origin line of the message in order to ease debugging and tracking >> messages back to their source. >> > > Just out of curiosity, you are only re-aligning the code and not the > printed messages themselves. How would this help ? did you mean help > with tracking the sources when doing grep like operations on the source > code ? > The primary motivation is that the line number of the string now matches the line number of the debug function statement, so there is better alignment when using these line numbers with the dynamic debug messaging system. It's also a style thing, that came up on the list for some patches I wrote for the ice flash update.. it was suggested to just keep the message on the same line as the function. I felt that it was better to go ahead and fix all of these files, so that future code is more likely to use the preferred style rather than follow the pattern of older code. Thanks, Jake
On Mon, 02 Nov 2020 14:58:08 -0800 Saeed Mahameed wrote: > On Mon, 2020-11-02 at 14:23 -0800, Tony Nguyen wrote: > > This series contains updates to ice driver only. > > ... > > > Tony renames Flow Director functions to be more generic as their use > > is expanded. > > > > Real expands ntuple support to allow for mask values to be specified. > > This > > is done by implementing ACL filtering in HW. > > > > This is a lot of code with only 2 liner commit messages! > > Can you please shed more light on what user interface is being used to > program and manage those ACLs, i see it is ethtool from the code but > the cover letter and commit messages do not provide any information > about that. > > Also could you please explain what ethtool interfaces/commands are > being implemented, in the commit messages or cover letter, either is > fine. Please remove the defensive programming checks, and preferably slim down the use of your special return codes.