| Message ID | 20201101232257.3028508-1-bigeasy@linutronix.de |
|---|---|
| Headers | show |
| Series | fsl/qbman: in_interrupt() cleanup. | expand |
On 11/2/2020 1:23 AM, Sebastian Andrzej Siewior wrote: > The driver uses in_irq() + in_serving_softirq() magic to decide if NAPI > scheduling is required or packet processing. > > The usage of in_*() in drivers is phased out and Linus clearly requested > that code which changes behaviour depending on context should either be > separated or the context be conveyed in an argument passed by the caller, > which usually knows the context. > > Use the `sched_napi' argument passed by the callback. It is set true if > called from the interrupt handler and NAPI should be scheduled. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Cc: "Horia Geantă" <horia.geanta@nxp.com> > Cc: Aymen Sghaier <aymen.sghaier@nxp.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Madalin Bucur <madalin.bucur@nxp.com> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Li Yang <leoyang.li@nxp.com> > Cc: linux-crypto@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org Reviewed-by: Horia Geantă <horia.geanta@nxp.com> Thanks, Horia
> -----Original Message----- > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Sent: 02 November 2020 01:23 > To: netdev@vger.kernel.org > Cc: Horia Geanta <horia.geanta@nxp.com>; Aymen Sghaier > <aymen.sghaier@nxp.com>; Herbert Xu <herbert@gondor.apana.org.au>; David S. > Miller <davem@davemloft.net>; Madalin Bucur <madalin.bucur@nxp.com>; Jakub > Kicinski <kuba@kernel.org>; Leo Li <leoyang.li@nxp.com>; Thomas Gleixner > <tglx@linutronix.de>; Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Subject: [PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup. > > This is the in_interrupt() clean for FSL DPAA framework and the two > users. > > The `napi' parameter has been renamed to `sched_napi', the other parts > are same as in the previous post [0]. > > https://lore.kernel.org/linux-arm-kernel/20201027225454.3492351-1-bigeasy@linutronix.de/ > > Sebastian For the series, Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
> -----Original Message----- > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > Sent: Monday, November 2, 2020 01:23 > To: netdev@vger.kernel.org > Cc: Horia Geanta <horia.geanta@nxp.com>; Aymen Sghaier > <aymen.sghaier@nxp.com>; Herbert Xu <herbert@gondor.apana.org.au>; > David S. Miller <davem@davemloft.net>; Madalin Bucur > <madalin.bucur@nxp.com>; Jakub Kicinski <kuba@kernel.org>; Leo Li > <leoyang.li@nxp.com>; Thomas Gleixner <tglx@linutronix.de>; Sebastian > Andrzej Siewior <bigeasy@linutronix.de> > Subject: [PATCH v2 net-next 0/3] fsl/qbman: in_interrupt() cleanup. > > This is the in_interrupt() clean for FSL DPAA framework and the two > users. > > The `napi' parameter has been renamed to `sched_napi', the other parts > are same as in the previous post [0]. > > [0] https://lore.kernel.org/linux-arm-kernel/20201027225454.3492351-1-bigeasy@linutronix.de/ > > Sebastian Tested-by: Camelia Groza <camelia.groza@nxp.com>
On Mon, 2 Nov 2020 00:22:54 +0100 Sebastian Andrzej Siewior wrote: > This is the in_interrupt() clean for FSL DPAA framework and the two > users. > > The `napi' parameter has been renamed to `sched_napi', the other parts > are same as in the previous post [0]. > > [0] https://lkml.kernel.org/r/20201027225454.3492351-1-bigeasy@linutronix.de Applied, thanks everyone!