mbox series

[v4,0/5] dpaa2_eth: support 1588 one-step timestamping

Message ID 20200918090802.13757-1-yangbo.lu@nxp.com
Headers show
Series dpaa2_eth: support 1588 one-step timestamping | expand

Message

Y.b. Lu Sept. 18, 2020, 9:07 a.m. UTC
This patch-set is to add MC APIs of 1588 one-step timestamping, and
support one-step timestamping for PTP Sync packet on DPAA2.

Before egress, one-step timestamping enablement needs,

- Enabling timestamp and FAS (Frame Annotation Status) in
  dpni buffer layout.

- Write timestamp to frame annotation and set PTP bit in
  FAS to mark as one-step timestamping event.

- Enabling one-step timestamping by dpni_set_single_step_cfg()
  API, with offset provided to insert correction time on frame.
  The offset must respect all MAC headers, VLAN tags and other
  protocol headers accordingly. The correction field update can
  consider delays up to one second. So PTP frame needs to be
  filtered and parsed, and written timestamp into Sync frame
  originTimestamp field.

The operation of API dpni_set_single_step_cfg() has to be done
when no one-step timestamping frames are in flight. So we have
to make sure the last one-step timestamping frame has already
been transmitted on hardware before starting to send the current
one. The resolution is,

- Utilize skb->cb[0] to mark timestamping request per packet.
  If it is one-step timestamping PTP sync packet, queue to skb queue.
  If not, transmit immediately.

- Schedule a work to transmit skbs in skb queue.

- mutex lock is used to ensure the last one-step timestamping packet
  has already been transmitted on hardware through TX confirmation queue
  before transmitting current packet.

Changes for v2:
	- Removed unused variable priv in dpaa2_eth_xdp_create_fd().
Changes for v3:
	- Fixed sparse warnings.
	- Fix build issue on 32-bit.
	- Converted to use ptp_parse_header.
Changes for v4:
	- Used WARN_ONCE instead of netdev_err in data path.
	- Enabled timestamping only when PTP driver is ready.
	- Added comments in using onestep_tstamp_lock.
	- Dropped dpmac.c sparse warning fix-up patch.

Yangbo Lu (5):
  dpaa2-eth: add APIs of 1588 single step timestamping
  dpaa2-eth: define a global ptp_qoriq structure pointer
  dpaa2-eth: invoke dpaa2_eth_enable_tx_tstamp() once in code
  dpaa2-eth: utilize skb->cb[0] for hardware timestamping
  dpaa2-eth: support PTP Sync packet one-step timestamping

 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c   | 227 ++++++++++++++++++---
 drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h   |  44 +++-
 .../net/ethernet/freescale/dpaa2/dpaa2-ethtool.c   |   7 +-
 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c   |   3 +-
 drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.h   |   4 +
 drivers/net/ethernet/freescale/dpaa2/dpni-cmd.h    |  21 ++
 drivers/net/ethernet/freescale/dpaa2/dpni.c        |  79 +++++++
 drivers/net/ethernet/freescale/dpaa2/dpni.h        |  31 +++
 8 files changed, 379 insertions(+), 37 deletions(-)

Comments

David Miller Sept. 18, 2020, 9:33 p.m. UTC | #1
From: Yangbo Lu <yangbo.lu@nxp.com>

Date: Fri, 18 Sep 2020 17:07:57 +0800

> This patch-set is to add MC APIs of 1588 one-step timestamping, and

> support one-step timestamping for PTP Sync packet on DPAA2.

> 

> Before egress, one-step timestamping enablement needs,

> 

> - Enabling timestamp and FAS (Frame Annotation Status) in

>   dpni buffer layout.

> 

> - Write timestamp to frame annotation and set PTP bit in

>   FAS to mark as one-step timestamping event.

> 

> - Enabling one-step timestamping by dpni_set_single_step_cfg()

>   API, with offset provided to insert correction time on frame.

>   The offset must respect all MAC headers, VLAN tags and other

>   protocol headers accordingly. The correction field update can

>   consider delays up to one second. So PTP frame needs to be

>   filtered and parsed, and written timestamp into Sync frame

>   originTimestamp field.

> 

> The operation of API dpni_set_single_step_cfg() has to be done

> when no one-step timestamping frames are in flight. So we have

> to make sure the last one-step timestamping frame has already

> been transmitted on hardware before starting to send the current

> one. The resolution is,

> 

> - Utilize skb->cb[0] to mark timestamping request per packet.

>   If it is one-step timestamping PTP sync packet, queue to skb queue.

>   If not, transmit immediately.

> 

> - Schedule a work to transmit skbs in skb queue.

> 

> - mutex lock is used to ensure the last one-step timestamping packet

>   has already been transmitted on hardware through TX confirmation queue

>   before transmitting current packet.

 ...

Series applied to net-next, thanks.