From patchwork Tue Jun 23 09:59:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 191421 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp906032ecs; Tue, 23 Jun 2020 03:00:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxgzHACUA16Z3mBx6TNfSU9fwNb+3rQTEgohehUqyEByxRz8PL6OIaM9i4FDQ6zmcOJT+Cq X-Received: by 2002:a50:b0a1:: with SMTP id j30mr21227511edd.387.1592906400627; Tue, 23 Jun 2020 03:00:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592906400; cv=none; d=google.com; s=arc-20160816; b=eNO0FsC3nTLA/Y/50ZZfZcG0ZM+QzeetEiRWYUUelzjPgkP6k0yqGde9aU5NitA4mi GgpaAqau7H2JHgyQd0lpRsVwFKA9hthmoVSBX+5u4pvW/WHn1eugo4WVc/3kP3e2B4bA ViCP1QIk2g5aIarIDT9I4LMvC9KbC+XN1sFBRMcPtZXvzsH64vyC+xrrAXrYPG/SOoLL ZDegykBSZ0C0o5qzcFynIWtTofCcigTozE3eM0wU62qT1Tp3IbC1Ow5UcLeYWWuHllrn spLDIvAH4H79t2sqge3gx8weE0jmzHIbRmTzVA6tF1NQFv9hE/RN8vwAFS9EJxeN0Id6 Z9qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=w29Orj+BsSDc4iIvwbYzVPPmzlf99oVmU9LDf+B1c2Q=; b=ezFBb9Q3dyjYjyCjlk5ubKQZIxvW/lh83j1FoelPqTdaesKPkZA95GVqTsmzExtKfK BMaCB+DOtAobyKLZHKgBWcCXCTalQJx0c6U4ZNARJ6fMov9b/iY6ZvcCQjqm6luk+fLe gDIaSV2pWb4f2U55MhxeTIhUSseJrOtLIGeG8ndynrXBfC++121GEa89zfq2Btq98eJz PJ0vVU2GDWvtYMqx4MvhpQ61fnYad8XZ65RjF6AAlyW6Uq3CzXbeDfbh6+kstHBP7p3X RahNZtjfRjYLiIDWwcKOGn8QdRe5pNxguJ0t54pqfjvt2YqwoHIwL9M3o4wPA6k79rX0 +pEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=gydD8o1Q; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si9699561ejr.634.2020.06.23.03.00.00; Tue, 23 Jun 2020 03:00:00 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=mail header.b=gydD8o1Q; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732138AbgFWJ76 (ORCPT + 9 others); Tue, 23 Jun 2020 05:59:58 -0400 Received: from mail.zx2c4.com ([192.95.5.64]:42093 "EHLO mail.zx2c4.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731947AbgFWJ75 (ORCPT ); Tue, 23 Jun 2020 05:59:57 -0400 Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 3e0fa82c; Tue, 23 Jun 2020 09:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; s=mail; bh=tJHSsa/WpyLQZvunBAmuYEMzU5U=; b=gydD8o1Qtxgk9mxyZCuP t3TJBGMsdb0SMB2iK0tsuU/fZ647/EpDSKVElXA1uzBHNuMPF814s76Qa1xa4pCU NahsuHxFFLiAnextUEsjB+D54/ps7qP09cSRlEMrRXpEaFLFnd97CxrgplyHdtF2 D/bfgM/+YhlsWHXm/NG432T1K9S/qfKPLrdBgz1VuoHedn92Xzyt8Nb9aLWFSyxN ygj3JlZ/epzosCypxqDfKUtiJmGgIFuvP3rnJKR3alCJ6JS8hsad7GXs4CmxdnXw QKt4WCHXTu/aNXEFks+C3Bp0ALW9i67yiojHQPoqnxXGY7HekzmgxAm7PNrm+zK5 mQ== Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 40f83448 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 23 Jun 2020 09:41:04 +0000 (UTC) From: "Jason A. Donenfeld" To: davem@davemloft.net, netdev@vger.kernel.org Cc: "Jason A. Donenfeld" Subject: [PATCH net 0/2] wireguard fixes for 5.8-rc3 Date: Tue, 23 Jun 2020 03:59:43 -0600 Message-Id: <20200623095945.1402468-1-Jason@zx2c4.com> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Dave, This series contains two fixes, one cosmetic and one quite important: 1) Avoid the `if ((x = f()) == y)` pattern, from Frank Werner-Krippendorf. 2) Mitigate a potential memory leak by creating circular netns references, while also making the netns semantics a bit more robust. Patch (2) has a "Fixes:" line and should be backported to stable. Thanks, Jason Frank Werner-Krippendorf (1): wireguard: noise: do not assign initiation time in if condition Jason A. Donenfeld (1): wireguard: device: avoid circular netns references drivers/net/wireguard/device.c | 58 ++++++++++------------ drivers/net/wireguard/device.h | 3 +- drivers/net/wireguard/netlink.c | 14 ++++-- drivers/net/wireguard/noise.c | 4 +- drivers/net/wireguard/socket.c | 25 +++++++--- tools/testing/selftests/wireguard/netns.sh | 13 ++++- 6 files changed, 69 insertions(+), 48 deletions(-) -- 2.27.0