From patchwork Mon Jun 1 12:58:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 218075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67C50C433DF for ; Mon, 1 Jun 2020 12:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 25BA420679 for ; Mon, 1 Jun 2020 12:59:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="h99Te+LT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726035AbgFAM7b (ORCPT ); Mon, 1 Jun 2020 08:59:31 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:33121 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgFAM7a (ORCPT ); Mon, 1 Jun 2020 08:59:30 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B7AA95C00ED; Mon, 1 Jun 2020 08:59:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 01 Jun 2020 08:59:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=E3/24F62NlPLS0BZI KB9PKwWbUkHMjMffQEINIidQHQ=; b=h99Te+LTYj1fbOkSZ9lHj1daH8EbqhQo8 GoNJTebbOCgOQRQJk5CgvW2dZiclE2QA49BYWUSXYP0H92LkxfODq94vp053YwYC OQbxWAyjhrdmwtlPS0NTVI7zmS3dOwfT9ZUydlfzUB9He2kfybLj/cC1NIj+/9O6 3gO6Ekr6cBMjfy4drsMvjJHeMD4Xvsxi9gGwmzA4tqa+96aSbqYfS5jdwXPijtY2 cqo4RFH+XJGufRNZdVkk3GcYsQAD/IrroEvUu9tjxF5KwVhdRufq19p2So+sNDc2 z5GBFesqcqxa4ZYI9ASvAzLaBDsGrlkbHSq7j4D3FPjLsOfjLg/9Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefhedgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiughoshgt hhdrohhrgheqnecuggftrfgrthhtvghrnhepteevgefhvefggfffkeeuffeuvdfhueehhe etffeikeegheevfedvgeelvdffudfhnecukfhppeejledrudejiedrvdegrddutdejnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihguohhstg hhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from splinter.mtl.com (bzq-79-176-24-107.red.bezeqint.net [79.176.24.107]) by mail.messagingengine.com (Postfix) with ESMTPA id E84DB3280059; Mon, 1 Jun 2020 08:59:26 -0400 (EDT) From: Ido Schimmel To: netdev@vger.kernel.org, bridge@lists.linux-foundation.org Cc: davem@davemloft.net, kuba@kernel.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, dlstevens@us.ibm.com, allas@mellanox.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net 0/2] Fix infinite loop in bridge and vxlan modules Date: Mon, 1 Jun 2020 15:58:53 +0300 Message-Id: <20200601125855.1751343-1-idosch@idosch.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel When suppressing invalid IPv6 Neighbour Solicitation messages, it is possible for the bridge and vxlan modules to get stuck in an infinite loop. See the individual changelogs for detailed explanation of the problem and solution. The bug was originally reported against the bridge module, but after auditing the code base I found that the buggy code was copied from the vxlan module. This patch set fixes both modules. Could not find more instances of the problem. Please consider both patches for stable releases. Ido Schimmel (2): bridge: Avoid infinite loop when suppressing NS messages with invalid options vxlan: Avoid infinite loop when suppressing NS messages with invalid options drivers/net/vxlan.c | 4 ++++ net/bridge/br_arp_nd_proxy.c | 4 ++++ 2 files changed, 8 insertions(+)