mbox series

[bpf-next,0/2] samples: bpf: refactor perf_event user program with libbpf bpf_link

Message ID 20200310055147.26678-1-danieltimlee@gmail.com
Headers show
Series samples: bpf: refactor perf_event user program with libbpf bpf_link | expand

Message

Daniel T. Lee March 10, 2020, 5:51 a.m. UTC 
Currently, some samples are using ioctl for enabling perf_event and
attaching BPF programs to this event. However, the bpf_program__attach
of libbpf(using bpf_link) is much more intuitive than the previous
method using ioctl.

bpf_program__attach_perf_event manages the enable of perf_event and
attach of BPF programs to it, so there's no neeed to do this
directly with ioctl.

In addition, bpf_link provides consistency in the use of API because it
allows disable (detach, destroy) for multiple events to be treated as
one bpf_link__destroy.

To refactor samples with using this libbpf API, the bpf_load in the
samples were removed and migrated to libbbpf. Because read_trace_pipe
is used in bpf_load, multiple samples cannot be migrated to libbpf,
this function was moved to trace_helpers.

Daniel T. Lee (2):
  samples: bpf: move read_trace_pipe to trace_helpers
  samples: bpf: refactor perf_event user program with libbpf bpf_link

 samples/bpf/Makefile                        |  8 +--
 samples/bpf/bpf_load.c                      | 20 -------
 samples/bpf/bpf_load.h                      |  1 -
 samples/bpf/sampleip_user.c                 | 58 +++++++++++++--------
 samples/bpf/trace_event_user.c              | 57 +++++++++++++-------
 samples/bpf/tracex1_user.c                  |  1 +
 samples/bpf/tracex5_user.c                  |  1 +
 tools/testing/selftests/bpf/trace_helpers.c | 23 ++++++++
 tools/testing/selftests/bpf/trace_helpers.h |  1 +
 9 files changed, 106 insertions(+), 64 deletions(-)