mbox series

[net,v8,0/3] fix packet stuck problem for lockless qdisc

Message ID 1620962221-40131-1-git-send-email-linyunsheng@huawei.com
Headers show
Series fix packet stuck problem for lockless qdisc | expand

Message

Yunsheng Lin May 14, 2021, 3:16 a.m. UTC
This patchset fixes the packet stuck problem mentioned in [1].

Patch 1: Add STATE_MISSED flag to fix packet stuck problem.
Patch 2: Fix a tx_action rescheduling problem after STATE_MISSED
         flag is added in patch 1.
Patch 3: Fix the significantly higher CPU consumption problem when
         multiple threads are competing on a saturated outgoing
         device.

V8: Change function name as suggested by Jakub and fix some typo
    in patch 3, adjust commit log in patch 2, and add Acked-by
    from Jakub.
V7: Fix netif_tx_wake_queue() data race noted by Jakub.
V6: Some performance optimization in patch 1 suggested by Jakub
    and drop NET_XMIT_DROP checking in patch 3.
V5: add patch 3 to fix the problem reported by Michal Kubecek.
V4: Change STATE_NEED_RESCHEDULE to STATE_MISSED and add patch 2.

[1]. https://lkml.org/lkml/2019/10/9/42

Yunsheng Lin (3):
  net: sched: fix packet stuck problem for lockless qdisc
  net: sched: fix tx action rescheduling issue during deactivation
  net: sched: fix tx action reschedule issue with stopped queue

 include/net/pkt_sched.h   |  7 +------
 include/net/sch_generic.h | 35 ++++++++++++++++++++++++++++++++-
 net/core/dev.c            | 29 ++++++++++++++++++++++-----
 net/sched/sch_generic.c   | 50 +++++++++++++++++++++++++++++++++++++++++++++--
 4 files changed, 107 insertions(+), 14 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org May 14, 2021, 10:20 p.m. UTC | #1
Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Fri, 14 May 2021 11:16:58 +0800 you wrote:
> This patchset fixes the packet stuck problem mentioned in [1].
> 
> Patch 1: Add STATE_MISSED flag to fix packet stuck problem.
> Patch 2: Fix a tx_action rescheduling problem after STATE_MISSED
>          flag is added in patch 1.
> Patch 3: Fix the significantly higher CPU consumption problem when
>          multiple threads are competing on a saturated outgoing
>          device.
> 
> [...]

Here is the summary with links:
  - [net,v8,1/3] net: sched: fix packet stuck problem for lockless qdisc
    https://git.kernel.org/netdev/net/c/a90c57f2cedd
  - [net,v8,2/3] net: sched: fix tx action rescheduling issue during deactivation
    https://git.kernel.org/netdev/net/c/102b55ee92f9
  - [net,v8,3/3] net: sched: fix tx action reschedule issue with stopped queue
    https://git.kernel.org/netdev/net/c/dcad9ee9e066

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html