| Message ID | 1610701570-29496-1-git-send-email-bupadhaya@marvell.com |
|---|---|
| Headers | show |
| Series | qede: add netpoll and per-queue coalesce support | expand |
On Fri, 15 Jan 2021 01:06:08 -0800 Bhaskar Upadhaya wrote: > Add net poll controller support to transmit kernel printks > over UDP Why do you need this patch? Couple years back netpoll was taught how to pull NAPIs by itself, and all you do is schedule NAPIs. All the driver should do is to make sure that when napi is called with budget of 0 it only processes Tx completions, not Rx traffic.
> On Fri, 15 Jan 2021 01:06:08 -0800 Bhaskar Upadhaya wrote: >> Add net poll controller support to transmit kernel printks >> over UDP > > Why do you need this patch? Couple years back netpoll was taught > how to pull NAPIs by itself, and all you do is schedule NAPIs. > > All the driver should do is to make sure that when napi is called > with budget of 0 it only processes Tx completions, not Rx traffic. Hi Jakub, Thanks for the hint, we were not aware of that. I see our driver may not handle zero budget accordingly. Will check. But then, all this means .ndo_poll_controller is basically deprecated? Regards, Igor
On Sun, 17 Jan 2021 17:35:30 +0100 Igor Russkikh wrote: > > On Fri, 15 Jan 2021 01:06:08 -0800 Bhaskar Upadhaya wrote: > >> Add net poll controller support to transmit kernel printks > >> over UDP > > > > Why do you need this patch? Couple years back netpoll was taught > > how to pull NAPIs by itself, and all you do is schedule NAPIs. > > > > All the driver should do is to make sure that when napi is called > > with budget of 0 it only processes Tx completions, not Rx traffic. > > Hi Jakub, > > Thanks for the hint, we were not aware of that. > > I see our driver may not handle zero budget accordingly. Will check. > > But then, all this means .ndo_poll_controller is basically deprecated? It's still needed for special devices, off the top of my head for example bonding uses it to poll its members. But for normal NIC drivers, yes, it's pretty much deprecated.
Patch 1: Add net poll controller support to transmit kernel printks over UDP. Patch 2: QLogic card support multiple queues and each queue can be configured with respective coalescing parameters, this patch add per queue rx-usecs, tx-usecs coalescing parameters. Patch 3: set default per queue rx-usecs, tx-usecs coalescing parameters. Bhaskar Upadhaya (3): qede: add netpoll support for qede driver qede: add per queue coalesce support for qede driver qede: set default per queue rx/tx usecs coalescing parameters drivers/net/ethernet/qlogic/qede/qede.h | 5 + .../net/ethernet/qlogic/qede/qede_ethtool.c | 126 +++++++++++++++++- drivers/net/ethernet/qlogic/qede/qede_fp.c | 14 ++ drivers/net/ethernet/qlogic/qede/qede_main.c | 7 + 4 files changed, 150 insertions(+), 2 deletions(-)