mbox series

[net-next,0/2,v3] net: socionext: XDP support

Message ID 1538220482-16129-1-git-send-email-ilias.apalodimas@linaro.org
Headers show
Series net: socionext: XDP support | expand

Message

Ilias Apalodimas Sept. 29, 2018, 11:28 a.m. UTC
This patch series adds AF_XDP support socionext netsec driver
In addition the new dma allocation scheme offers a 10% boost on Rx
pps rate using 64b packets

- patch [1/2]: Use a different allocation scheme for Rx DMA buffers to 
  prepare the driver for AF_XDP support
- patch [2/2]: Add XDP support without zero-copy

test and performance numbers (64b packets):
-------------------------------------------
- Normal SKBs on Rx: ~217kpps
test: pktgen -> intel i210 -> netsec -> XDP_TX/XDP_REDIRECT
- XDP_TX: 320kpps
- XDP_REDIRECT: 320kpps

qemu -> pktgen -> virtio -> ndo_xdp_xmit -> netsec
- ndo_xdp_xmit: Could not send more than 120kpps. Interface forwarded that 
                with success

Changes since v2:
 - Always allocate Rx buffers with XDP_PACKET_HEADROOM
 
 Björn Töpel:
 - Added locking in the Tx queue

 Jesper Dangaard Brouer:
 - Added support for .ndo_xdp_xmit
 - XDP_TX does not flush every packet

Changes since v1:
- patch [2/2]:
 Toshiaki Makita:
 - Added XDP_PACKET_HEADROOM
 - Fixed a bug on XDP_PASS case
 - Using extact for error messaging instead of netdev_warn, when
   trying to setup XDP

Ilias Apalodimas (2):
  net: socionext: different approach on DMA
  net: socionext: add XDP support

 drivers/net/ethernet/socionext/netsec.c | 541 +++++++++++++++++++++++++-------
 1 file changed, 426 insertions(+), 115 deletions(-)

-- 
2.7.4

Comments

Björn Töpel Oct. 1, 2018, 12:48 p.m. UTC | #1
On 2018-09-29 13:28, Ilias Apalodimas wrote:
> This patch series adds AF_XDP support socionext netsec driver


This series adds *XDP* support and as a result, the AF_XDP batteries
are included. ;-)


Björn

> In addition the new dma allocation scheme offers a 10% boost on Rx

> pps rate using 64b packets

> 

> - patch [1/2]: Use a different allocation scheme for Rx DMA buffers to

>    prepare the driver for AF_XDP support

> - patch [2/2]: Add XDP support without zero-copy

> 

> test and performance numbers (64b packets):

> -------------------------------------------

> - Normal SKBs on Rx: ~217kpps

> test: pktgen -> intel i210 -> netsec -> XDP_TX/XDP_REDIRECT

> - XDP_TX: 320kpps

> - XDP_REDIRECT: 320kpps

> 

> qemu -> pktgen -> virtio -> ndo_xdp_xmit -> netsec

> - ndo_xdp_xmit: Could not send more than 120kpps. Interface forwarded that

>                  with success

> 

> Changes since v2:

>   - Always allocate Rx buffers with XDP_PACKET_HEADROOM

>   

>   Björn Töpel:

>   - Added locking in the Tx queue

> 

>   Jesper Dangaard Brouer:

>   - Added support for .ndo_xdp_xmit

>   - XDP_TX does not flush every packet

> 

> Changes since v1:

> - patch [2/2]:

>   Toshiaki Makita:

>   - Added XDP_PACKET_HEADROOM

>   - Fixed a bug on XDP_PASS case

>   - Using extact for error messaging instead of netdev_warn, when

>     trying to setup XDP

> 

> Ilias Apalodimas (2):

>    net: socionext: different approach on DMA

>    net: socionext: add XDP support

> 

>   drivers/net/ethernet/socionext/netsec.c | 541 +++++++++++++++++++++++++-------

>   1 file changed, 426 insertions(+), 115 deletions(-)

>
Ilias Apalodimas Oct. 1, 2018, 1:59 p.m. UTC | #2
On Mon, Oct 01, 2018 at 02:48:54PM +0200, Björn Töpel wrote:
> On 2018-09-29 13:28, Ilias Apalodimas wrote:

> >This patch series adds AF_XDP support socionext netsec driver

> 

> This series adds *XDP* support and as a result, the AF_XDP batteries

> are included. ;-)

> 

Noted, thanks for cathcing this, i replaced all other AF_XDP -> XDP but seems
like i missed this one!


/Ilias