From patchwork Thu Apr 7 13:22:22 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Elo, Matias \(Nokia - FI/Espoo\)" X-Patchwork-Id: 65321 Delivered-To: patch@linaro.org Received: by 10.112.43.237 with SMTP id z13csp75829lbl; Thu, 7 Apr 2016 06:22:37 -0700 (PDT) X-Received: by 10.140.100.225 with SMTP id s88mr3557802qge.35.1460035357087; Thu, 07 Apr 2016 06:22:37 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 101si5889141qgh.16.2016.04.07.06.22.36; Thu, 07 Apr 2016 06:22:37 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE dis=NONE) header.from=nokia.com Received: by lists.linaro.org (Postfix, from userid 109) id B0EA561972; Thu, 7 Apr 2016 13:22:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 2C2E761073; Thu, 7 Apr 2016 13:22:30 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 949E161972; Thu, 7 Apr 2016 13:22:27 +0000 (UTC) Received: from demumfd001.nsn-inter.net (demumfd001.nsn-inter.net [93.183.12.32]) by lists.linaro.org (Postfix) with ESMTPS id 761D961779 for ; Thu, 7 Apr 2016 13:22:25 +0000 (UTC) Received: from muimrel002.emea.nsn-intra.net ([10.159.32.133]) by demumfd001.nsn-inter.net (8.15.2/8.15.2) with ESMTPS id u37DMNk0012460 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Apr 2016 13:22:23 GMT Received: from DEMUHTC004.nsn-intra.net ([10.159.42.35]) by muimrel002.emea.nsn-intra.net (8.14.3/8.14.3) with ESMTP id u37DMNY1002491 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Thu, 7 Apr 2016 13:22:23 GMT Received: from DEMUHTC008.nsn-intra.net (10.159.42.39) by DEMUHTC004.nsn-intra.net (10.159.42.35) with Microsoft SMTP Server (TLS) id 14.3.279.2; Thu, 7 Apr 2016 15:22:23 +0200 Received: from DEMUMBX011.nsn-intra.net ([169.254.11.224]) by DEMUHTC008.nsn-intra.net ([10.159.42.39]) with mapi id 14.03.0279.002; Thu, 7 Apr 2016 15:22:23 +0200 From: "Elo, Matias (Nokia - FI/Espoo)" To: EXT Maxim Uvarov , "lng-odp@lists.linaro.org" Thread-Topic: [lng-odp] [PATCH 2/2] configure: remove dead code Thread-Index: AQHRjDYI+uyzN4i9Uk6Evu2wCVN2xZ9+XQ0AgAAp6xA= Date: Thu, 7 Apr 2016 13:22:22 +0000 Message-ID: References: <1458933927-77722-1-git-send-email-brian.brooks@linaro.org> <1458933927-77722-2-git-send-email-brian.brooks@linaro.org> <570656A4.1080201@linaro.org> In-Reply-To: <570656A4.1080201@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.159.42.124] MIME-Version: 1.0 X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 3634 X-purgate-ID: 151667::1460035343-00001B3D-0486F327/0/0 X-Topics: patch Subject: Re: [lng-odp] [PATCH 2/2] configure: remove dead code X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" > -----Original Message----- > From: EXT Maxim Uvarov [mailto:maxim.uvarov@linaro.org] > Sent: Thursday, April 07, 2016 3:46 PM > To: lng-odp@lists.linaro.org > Cc: Elo, Matias (Nokia - FI/Espoo) > Subject: Re: [lng-odp] [PATCH 2/2] configure: remove dead code > > Matias, if you tested that can you please send Teted-by: ? > > Maxim. Hi Maxim, I tested the fixed patch suggested by Anders, not the original patch sent by Brian. Anders' fixed patch below. -Matias if test x$cunit_support = xyes @@ -42,3 +50,9 @@ then else cunit_support=no fi + +########################################################################## +# Restore old saved variables +########################################################################## +LDFLAGS=$OLD_LDFLAGS +CPPFLAGS=$OLD_CPPFLAGS diff --git a/configure.ac b/configure.ac index d0d3ca6..6361f14 100644 --- a/configure.ac +++ b/configure.ac @@ -172,20 +172,6 @@ AC_ARG_ENABLE([debug], ODP_CFLAGS="$ODP_CFLAGS -DODP_DEBUG=$ODP_DEBUG" ########################################################################## -# Save and set temporary compilation flags -########################################################################## -OLD_LDFLAGS=$LDFLAGS -OLD_CPPFLAGS=$CPPFLAGS -LDFLAGS="$AM_LDFLAGS $LDFLAGS" -CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" - -########################################################################## -# Restore old saved variables -########################################################################## -LDFLAGS=$OLD_LDFLAGS -CPPFLAGS=$OLD_CPPFLAGS - -########################################################################## # Default warning setup ########################################################################## ODP_CFLAGS="$ODP_CFLAGS -W -Wall -Werror -Wstrict-prototypes -Wmissing-prototypes" diff --git a/test/m4/validation.m4 b/test/m4/validation.m4 index b137118..d32f675 100644 --- a/test/m4/validation.m4 +++ b/test/m4/validation.m4 @@ -31,6 +31,14 @@ AC_HELP_STRING([--with-cunit-path=DIR path to CUnit libs and headers], cunit_support=yes],[]) ########################################################################## +# Save and set temporary compilation flags +########################################################################## +OLD_LDFLAGS=$LDFLAGS +OLD_CPPFLAGS=$CPPFLAGS +LDFLAGS="$AM_LDFLAGS $LDFLAGS" +CPPFLAGS="$AM_CPPFLAGS $CPPFLAGS" + +########################################################################## # Check for CUnit availability ##########################################################################