From patchwork Thu Jul 30 21:13:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 51729 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by patches.linaro.org (Postfix) with ESMTPS id 0D41E22D9C for ; Thu, 30 Jul 2015 21:17:20 +0000 (UTC) Received: by lbcjf8 with SMTP id jf8sf17990031lbc.0 for ; Thu, 30 Jul 2015 14:17:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:message-id:date:from :user-agent:mime-version:to:references:in-reply-to:cc:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:content-transfer-encoding:content-type :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=LsSvU/UuToPtdDpHaHuwhiM3BbLTgt1EdlRPlCIy1zw=; b=KW64o0h6dQPzhY9SS5hNDxKpNgbDW8WvESB6gZog+lk3MV0y42M1cYLZvfc/onPG+t I/VWIXDvg0skwtUZn3Ka34Lm0HWsjES7pPKBHBCH2sioZe918mGI20DYI9vcYqFzU6KV K1u8ooPybSTPgXs9qkNY1vCGTfApvLNVrI3xAEwGlH2uHNLUh4QmR7DVv7nUbkx7Ow20 60AZkU7f0GOsFNb8NumGmD2c55sdxWN9zKACI2aPOIXVituhiwAWOiUb1m9sUh72Wqt+ 31tUcV9JJpqVulcS6/3Kc3QIctwaahHrh23heEq+NfqI2eLrViEWL+ksfaVgyMI+Rd6L +tcw== X-Gm-Message-State: ALoCoQkXxUFsDat0RfF4H1Xu/uBmT8u2xXW3+xlvuUR7lHQrJIRtW0CNzIghBSU7WTwf4GEbbLN9 X-Received: by 10.194.173.3 with SMTP id bg3mr18386393wjc.5.1438291038624; Thu, 30 Jul 2015 14:17:18 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.36.99 with SMTP id p3ls197302laj.57.gmail; Thu, 30 Jul 2015 14:17:18 -0700 (PDT) X-Received: by 10.152.182.194 with SMTP id eg2mr46188340lac.71.1438291038446; Thu, 30 Jul 2015 14:17:18 -0700 (PDT) Received: from mail-lb0-f169.google.com (mail-lb0-f169.google.com. [209.85.217.169]) by mx.google.com with ESMTPS id g1si1786924lab.70.2015.07.30.14.17.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 14:17:18 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) client-ip=209.85.217.169; Received: by lbbyj8 with SMTP id yj8so35022011lbb.0 for ; Thu, 30 Jul 2015 14:17:18 -0700 (PDT) X-Received: by 10.152.37.228 with SMTP id b4mr46041675lak.117.1438291037984; Thu, 30 Jul 2015 14:17:17 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp850814lba; Thu, 30 Jul 2015 14:17:16 -0700 (PDT) X-Received: by 10.140.132.73 with SMTP id 70mr3515955qhe.6.1438291036274; Thu, 30 Jul 2015 14:17:16 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 87si2985156qkx.9.2015.07.30.14.17.15; Thu, 30 Jul 2015 14:17:16 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 234D16207D; Thu, 30 Jul 2015 21:17:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E9C2C61E37; Thu, 30 Jul 2015 21:17:04 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id ECC5162079; Thu, 30 Jul 2015 21:16:57 +0000 (UTC) Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by lists.linaro.org (Postfix) with ESMTPS id E429962072 for ; Thu, 30 Jul 2015 21:13:52 +0000 (UTC) Received: by wicmv11 with SMTP id mv11so35750328wic.0 for ; Thu, 30 Jul 2015 14:13:52 -0700 (PDT) X-Received: by 10.194.248.201 with SMTP id yo9mr80608132wjc.31.1438290832033; Thu, 30 Jul 2015 14:13:52 -0700 (PDT) Received: from [192.168.1.5] (66-238-133-95.pool.ukrtel.net. [95.133.238.66]) by smtp.googlemail.com with ESMTPSA id jz4sm3726614wjb.16.2015.07.30.14.13.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jul 2015 14:13:51 -0700 (PDT) Message-ID: <55BA938C.5050107@linaro.org> Date: Fri, 31 Jul 2015 00:13:48 +0300 From: Ivan Khoronzhuk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Christophe Milard , maxim.uvarov@linaro.org References: <20150708150737.GA26781@erachmi-VirtualBox> In-Reply-To: <20150708150737.GA26781@erachmi-VirtualBox> Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] Pull request: validation last modules from platform side X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ivan.khoronzhuk@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.169 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Hi Christophe, Could you please clarify how to build validation tests from platform side. As I see all tests stop to build only because i do: The test/Makefile.am is called because subdir "test" is in root Makefile.am You've added TESTS list in platform/linux-generic/test/Makefile.am but for now they are built only because test/Makefile.am contains subdir "validation". Is it supposed that it's built now from platform side already or it's still under development? On 08.07.15 18:07, Christophe Milard wrote: > Hi Maxim, > Hope this is what you need for a proper pull request. > Let me know if anything is wrong/could be improved in this pull-req. > > All these patches have been reviewed by Stuart and do -hopefully- > not contain any big surprises. just the continuation of the > "run from platform side" for the last test/validation modules. > Thanks, > Christophe. > > The following changes since commit 493b618e8ad3184a97910485ad782732ec382979: > > linux-generic: schedule: fix double free (2015-07-03 15:09:24 +0300) > > are available in the git repository at: > > https://git.linaro.org/people/christophe.milard/odp.git test_module_timer > > for you to fetch changes up to 46fc2ab3225159d2bababe0d7f020009ebbb69f0: > > validation: call to timer_main from platform (2015-07-08 16:18:41 +0200) > > ---------------------------------------------------------------- > Christophe Milard (20): > validation: removed errno from odp_ver_abt_log_dbg > validation: cosmetic change in odp_errno.c > validation: new module errno > validation: renaming in odp_errno.c > validation: renaming system to time > validation: single src for odp_ver_abt_log_dbg > validation: mv odp_ver_abt_log_dbg to system > validation: own main in odp_system > validation: renaming in system.c > validation: creating own dir and lib for system > validation: call to system_main from platform side > validation: own main in odp_shared_memory.c > validation: renaming in odp_shared_memory.c > validation: creating own dir and lib for shmem > validation: call to shmem_main from platform side. > validation: own main in odp_timer.c > validation: renaming in odp_timer.c > validation: cosmetic changes in odp_timer.c > validation: creating own dir and lib for timer > validation: call to timer_main from platform > > configure.ac | 6 +- > platform/linux-generic/test/Makefile.am | 8 +- > test/validation/.gitignore | 3 - > test/validation/Makefile.am | 27 ++--- > test/validation/errno/.gitignore | 2 + > test/validation/errno/Makefile.am | 8 ++ > .../{ver_abt_log_dbg/odp_errno.c => errno/errno.c} | 17 +++- > test/validation/errno/errno.h | 7 ++ > test/validation/errno/errno_main.c | 12 +++ > test/validation/shmem/.gitignore | 2 + > test/validation/shmem/Makefile.am | 8 ++ > .../{odp_shared_memory.c => shmem/shmem.c} | 15 ++- > test/validation/shmem/shmem.h | 7 ++ > test/validation/shmem/shmem_main.c | 12 +++ > test/validation/system/.gitignore | 2 +- > test/validation/system/system.c | 112 +++++++++++++-------- > test/validation/system/system.h | 2 +- > test/validation/system/system_main.c | 2 +- > test/validation/time/.gitignore | 2 + > test/validation/time/Makefile.am | 8 ++ > test/validation/time/time.c | 79 +++++++++++++++ > test/validation/time/time.h | 7 ++ > test/validation/time/time_main.c | 12 +++ > test/validation/timer/.gitignore | 2 + > test/validation/timer/Makefile.am | 8 ++ > test/validation/{odp_timer.c => timer/timer.c} | 63 ++++++------ > test/validation/timer/timer.h | 7 ++ > test/validation/timer/timer_main.c | 12 +++ > test/validation/ver_abt_log_dbg/odp_errno.h | 9 -- > test/validation/ver_abt_log_dbg/odp_system.c | 94 ----------------- > test/validation/ver_abt_log_dbg/odp_system.h | 9 -- > .../ver_abt_log_dbg/odp_ver_abt_log_dbg.c | 16 --- > 32 files changed, 343 insertions(+), 237 deletions(-) > create mode 100644 test/validation/errno/.gitignore > create mode 100644 test/validation/errno/Makefile.am > rename test/validation/{ver_abt_log_dbg/odp_errno.c => errno/errno.c} (55%) > create mode 100644 test/validation/errno/errno.h > create mode 100644 test/validation/errno/errno_main.c > create mode 100644 test/validation/shmem/.gitignore > create mode 100644 test/validation/shmem/Makefile.am > rename test/validation/{odp_shared_memory.c => shmem/shmem.c} (86%) > create mode 100644 test/validation/shmem/shmem.h > create mode 100644 test/validation/shmem/shmem_main.c > create mode 100644 test/validation/time/.gitignore > create mode 100644 test/validation/time/Makefile.am > create mode 100644 test/validation/time/time.c > create mode 100644 test/validation/time/time.h > create mode 100644 test/validation/time/time_main.c > create mode 100644 test/validation/timer/.gitignore > create mode 100644 test/validation/timer/Makefile.am > rename test/validation/{odp_timer.c => timer/timer.c} (90%) > create mode 100644 test/validation/timer/timer.h > create mode 100644 test/validation/timer/timer_main.c > delete mode 100644 test/validation/ver_abt_log_dbg/odp_errno.h > delete mode 100644 test/validation/ver_abt_log_dbg/odp_system.c > delete mode 100644 test/validation/ver_abt_log_dbg/odp_system.h > delete mode 100644 test/validation/ver_abt_log_dbg/odp_ver_abt_log_dbg.c > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > --- a/test/Makefile.am +++ b/test/Makefile.am @@ -1,5 +1,5 @@ SUBDIRS = api_test performance miscellaneous if cunit_support - SUBDIRS += validation +# SUBDIRS += validation endif