From patchwork Wed Jul 12 01:43:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 107432 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp205975qge; Tue, 11 Jul 2017 18:44:08 -0700 (PDT) X-Received: by 10.55.79.198 with SMTP id d189mr3285337qkb.37.1499823848531; Tue, 11 Jul 2017 18:44:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1499823848; cv=none; d=google.com; s=arc-20160816; b=jmrTdNt2HKZ70aJWYioTFaYrbzqPYATgAgS57jvr05RmwwLlXorqVUZg8y/aQ492xO VVbJevt2iR8EbIugoh3qy30rjXUXzX/PL+QUP8UeGzjnLf/3slW/p3+nswZ1gDcjCstu gLgc6+cpLqWkLr6YcbSECdoz9t6ZvN2AJs7fA/Cp8sTdj+ApRJWt0KsuJ9ZvhHGqudoO uxhR9rbdCBkjvn+jL7Jp/MTBjxgXx4HkoMbCCQP8qx4QOq0BsyJ2BftgfUvRpRb2cj8F dnidH2ySsZWBPB3EGmaHyR+gEkOEaAsFkt2w8btyUavmuRbV8rhC1GbuFfTmj3j/2lRo Cw4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:message-id:date:to:from :delivered-to:arc-authentication-results; bh=J3woiwI2uHD29NuC5v9DkvNdrVsBsyyXfkz/fAyFmfQ=; b=JU5sk4mPkdAN8pKQdh8UXeH1bdLUyBXCBTKzAB0utqe44DgmC0tq192Sj5ayWWGHMZ V9eTpzyVknEnkzi52BMAdyu86bGS/HD3CrufbJaRCF78IHKbtJRs2OyXXOZUXXF1+yGV sJMQ7PmOG4Ipt8hMEDNY7zIqOlRQjwxBUhPgh/SW55H3aAbdtv6r0BHeKfMoFIMAL3qU gtN4LsQ2JNt0aNUWGQFf3U6VXi9fuPVRGACsIDoNahzcj58JLqq1FKzY4JHzupSQceyl aOUd9hXHIUzXAz/G6TgmZMJTR0hmURSBJEs/i9jh08fOVb+93pXSpivVLgzx4QubzmVm 5PPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id o33si952312qtb.100.2017.07.11.18.44.07; Tue, 11 Jul 2017 18:44:08 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C714762D11; Wed, 12 Jul 2017 01:44:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_SPAM, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3007D62AE4; Wed, 12 Jul 2017 01:44:04 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 526AB62CE7; Wed, 12 Jul 2017 01:44:02 +0000 (UTC) Received: from mail-oi0-f54.google.com (mail-oi0-f54.google.com [209.85.218.54]) by lists.linaro.org (Postfix) with ESMTPS id DA77F61057 for ; Wed, 12 Jul 2017 01:44:00 +0000 (UTC) Received: by mail-oi0-f54.google.com with SMTP id x187so8040159oig.3 for ; Tue, 11 Jul 2017 18:44:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=J3woiwI2uHD29NuC5v9DkvNdrVsBsyyXfkz/fAyFmfQ=; b=OVpbmFp9YYpif+bgrg52bbK38FqcibJAWgBMp3G0jzElJP640ilbcJSFRlHDi9xxud Oj9RozZla4FEcDiOmFIKTfjJD3lT7FXA3it0vJaeERcT8XTOgbn/QRK573cVTzKhqCtW RZTP6k/4ESewJ8c8ocxF6zlETcQis2SK26puUcgkTAvVcyYMAiyQLHx6Ds7SOUQCqq0X OnoQWifgKp0f2S2gY0MGDrQ0Onm9rh24nFFk7CPEDI5PTjbX5oi3KdlA42Vz/TujngTl TeJwYhRYL+JoLxapMq8dZUBHwXYBNo8z9tfkNL/NmzEAZ8O1kmpdERv2mqT+nJRvyiot EX4Q== X-Gm-Message-State: AIVw113hvmdo1aBd4KRgUxB5F57Qe0yEgqSqhBO5Ml94ZurQN87p2nzT eqkQivNKvY5O1rrsmCgSiDAW X-Received: by 10.202.244.215 with SMTP id s206mr2066733oih.25.1499823840127; Tue, 11 Jul 2017 18:44:00 -0700 (PDT) Received: from localhost.localdomain (cpe-70-121-83-241.austin.res.rr.com. [70.121.83.241]) by smtp.gmail.com with ESMTPSA id f137sm1480626oig.26.2017.07.11.18.43.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 18:43:59 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Tue, 11 Jul 2017 20:43:57 -0500 Message-Id: <20170712014357.12352-1-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.11.0 Subject: [lng-odp] [MONARCH_LTS PATCH] api: byteorder: avoid bitfield order doxygen omissions X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2402 by assigning explicit values to ODP_LITTLE_ENDIAN_BITFIELD and ODP_BIT_ENDIAN_BITFIELD to avoid Doxygen warnings. This makes these consistent with the usage for ODP_BIG_ENDIAN and ODP_LITTLE_ENDIAN. Also define the summary variable ODP_BITFIELD_ORDER which can be used similar to ODP_BYTE_ORDER for an explicit test of bitfield endianness. Note that this requires tests of these fields to change from #ifdef to #if. Signed-off-by: Bill Fischofer --- include/odp/api/spec/byteorder.h | 3 +++ platform/linux-generic/include/odp/api/plat/byteorder_types.h | 8 ++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) -- 2.11.0 diff --git a/include/odp/api/spec/byteorder.h b/include/odp/api/spec/byteorder.h index 10189971..e16a0d5a 100644 --- a/include/odp/api/spec/byteorder.h +++ b/include/odp/api/spec/byteorder.h @@ -39,6 +39,9 @@ extern "C" { * * @def ODP_BYTE_ORDER * Selected byte order + * + * @def ODP_BITFIELD_ORDER + * Selected bitfield order */ /** diff --git a/platform/linux-generic/include/odp/api/plat/byteorder_types.h b/platform/linux-generic/include/odp/api/plat/byteorder_types.h index 679d4cf9..09235b53 100644 --- a/platform/linux-generic/include/odp/api/plat/byteorder_types.h +++ b/platform/linux-generic/include/odp/api/plat/byteorder_types.h @@ -52,12 +52,16 @@ extern "C" { #define ODP_LITTLE_ENDIAN 1 #define ODP_BIG_ENDIAN 0 #define ODP_BYTE_ORDER ODP_LITTLE_ENDIAN - #define ODP_LITTLE_ENDIAN_BITFIELD + #define ODP_LITTLE_ENDIAN_BITFIELD 1 + #define ODP_BIG_ENDIAN_BITFIELD 0 + #define ODP_BITFIELD_ORDER ODP_LITTLE_ENDIAN_BITFIELD #else #define ODP_LITTLE_ENDIAN 0 #define ODP_BIG_ENDIAN 1 #define ODP_BYTE_ORDER ODP_BIG_ENDIAN - #define ODP_BIG_ENDIAN_BITFIELD + #define ODP_LITTLE_ENDIAN_BITFIELD 0 + #define ODP_BIG_ENDIAN_BITFIELD 1 + #define ODP_BITFIELD_ORDER ODP_BIG_ENDIAN_BITFIELD #endif typedef uint16_t __odp_bitwise odp_u16le_t;