From patchwork Wed Apr 5 21:16:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 96907 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp450173qgd; Wed, 5 Apr 2017 14:16:33 -0700 (PDT) X-Received: by 10.55.105.129 with SMTP id e123mr28319877qkc.184.1491426993368; Wed, 05 Apr 2017 14:16:33 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id y6si18809991qkd.212.2017.04.05.14.16.33; Wed, 05 Apr 2017 14:16:33 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id EF40A635DE; Wed, 5 Apr 2017 21:16:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 498A9609EB; Wed, 5 Apr 2017 21:16:29 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C4008609F2; Wed, 5 Apr 2017 21:16:26 +0000 (UTC) Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) by lists.linaro.org (Postfix) with ESMTPS id 7B3FA608AC for ; Wed, 5 Apr 2017 21:16:25 +0000 (UTC) Received: by mail-oi0-f46.google.com with SMTP id r203so30725348oib.3 for ; Wed, 05 Apr 2017 14:16:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=LtV1P1nhQV/VyLOeGPLg/zX5bJL5s6IcMJZ11iFIvCo=; b=OkTST1d5uX57QGXyzFy5wOWfHwUqurI2tbTYfQI0isfwxk0iooHbfxzPEPo9T9uDH0 ASxIa8/DMcEbPDU1n0eZBzF9Jg6VsD+Nx1afrSR+xIU4h/UfRLWidG3en7xb11byWpqg wRLHePgCbkxGH4smFcM7QZwEcGv6cpHx+i9obuBT4kPCAdA5QSlZ5PDp8o5ubTzClSOg WAOfTRsjHf6LoOQn9j1Oc2GWrBn+LnQP0wxGBDKH7t5QRYsivllfANGg/39x1yhwmqii ffwAgg5f7Y1J4OvO3OrFbLgSPO/lVgXFWBVBdNf4EYzVDE/4EBu2kGzNm+OLa0qIuXNl HbRA== X-Gm-Message-State: AFeK/H2eC1X/qJ4WDQ9m4jeZxTlUPJo4klGpR8Nx1ON/GwGbPUtZ67kh0Nvj8Nf2mjoeHnK1CTQ= X-Received: by 10.157.12.198 with SMTP id o6mr3315303otd.103.1491426984760; Wed, 05 Apr 2017 14:16:24 -0700 (PDT) Received: from localhost.localdomain (cpe-70-121-83-241.austin.res.rr.com. [70.121.83.241]) by smtp.gmail.com with ESMTPSA id 63sm10317903otu.25.2017.04.05.14.16.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 14:16:24 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Wed, 5 Apr 2017 16:16:20 -0500 Message-Id: <20170405211620.10245-1-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.9.3 Subject: [lng-odp] [PATCH] example: l3fwd: check rc from odph_eth_addr_parse() X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2779 by checking the return code from odph_eth_addr_parse() and failing the call if dst_mac is unparseable. Signed-off-by: Bill Fischofer --- example/l3fwd/odp_l3fwd_db.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.9.3 diff --git a/example/l3fwd/odp_l3fwd_db.c b/example/l3fwd/odp_l3fwd_db.c index 082b2c2..7d1efd5 100644 --- a/example/l3fwd/odp_l3fwd_db.c +++ b/example/l3fwd/odp_l3fwd_db.c @@ -394,7 +394,8 @@ int create_fwd_db_entry(char *input, char **oif, uint8_t **dst_mac) *oif = entry->oif; break; case 2: - odph_eth_addr_parse(&entry->dst_mac, token); + if (odph_eth_addr_parse(&entry->dst_mac, token) < 0) + return -1; *dst_mac = entry->dst_mac.addr; break;