From patchwork Tue Jan 30 17:00:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 126282 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp3538386ljd; Tue, 30 Jan 2018 09:04:19 -0800 (PST) X-Google-Smtp-Source: AH8x224ocuGUnTvCuAzqcAKxgl6MWORVP/QxBkYIFD8i3/7SF3IhmUfV3UE5MEJvulcf+Nfnzhib X-Received: by 10.129.198.1 with SMTP id l1mr20058781ywi.398.1517331859683; Tue, 30 Jan 2018 09:04:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517331859; cv=none; d=google.com; s=arc-20160816; b=Y1VbN0w2SiaTmkYAGug7Xaj7eBEwfyrVBMbQaK1bZfmTMAIKgUs9ViGPpmLZj6l9k3 EYVloiMOouOQTbzCbZ7bxKISmMUzyESVSiy33XKPCQWr7T+Gou0IDnKLsSJRQsiLGP1G PFs4XC/cEJkWC/AwFEu/L1sbP0r6uTRKu42ZZg0Fa1+wYg0AMxzik7KCvSqSnpeewyC3 7JeKdxrXquZVw/Bg5etDO7DTQj23kV7MG+PnASNz4jYQOolc3hQnzDcxE249M+KHdx7L O9S803dKsK0M3e5Spd17elb1Iuf6G/1WEewoYA7UrPmGva7iN+GXLclT/+/ZObsNz49M JAiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=Un2D8uDfSug1LbXBhjn/mInGEFUjZRTwUYHaDBk6kI4=; b=yjfcPBaMyMwM6zPxn+4QBzqF/hll5nz3aHZT0scG5EW6APKGi8gl2EEOjfhAU+UvG2 Ayilsp5hwkSzmuuwte2HiNZ6r1v4ton1AShVGOKzdqfj8U4K+ABqGZxkRKy8Th3/pwTO 1BVH+0lMr3A4NnMpCZyNCwxi1SkWdWAXBaQd+dO8TvencBW7GE8XVj3KSKp2oGlbCQO1 YaXeFY3+ub9uSG+qSra1VEm380QIjHRtTDCLjQ17LgB0sslRtvqH4qGu7PpPzjmAOfno Pd+IEqrP/B1l6n0Qgts2EgGAFwqsgjB9ONRkcB7UzKD8bO19EvIoRzXY8xe4l1xL0fc6 rM4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id g58si1398367qtk.263.2018.01.30.09.04.19; Tue, 30 Jan 2018 09:04:19 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 5596461787; Tue, 30 Jan 2018 17:04:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id CF41461512; Tue, 30 Jan 2018 17:02:22 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2543361763; Tue, 30 Jan 2018 17:02:01 +0000 (UTC) Received: from forward106o.mail.yandex.net (forward106o.mail.yandex.net [37.140.190.187]) by lists.linaro.org (Postfix) with ESMTPS id DA05F60C5D for ; Tue, 30 Jan 2018 17:00:39 +0000 (UTC) Received: from mxback10g.mail.yandex.net (mxback10g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:171]) by forward106o.mail.yandex.net (Yandex) with ESMTP id 40C2378262F for ; Tue, 30 Jan 2018 20:00:38 +0300 (MSK) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback10g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id AvPjGwRkLN-0cpOs6sI; Tue, 30 Jan 2018 20:00:38 +0300 Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 3C5hSSv4xg-0brG9L3i; Tue, 30 Jan 2018 20:00:37 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 30 Jan 2018 20:00:08 +0300 Message-Id: <1517331619-18755-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517331619-18755-1-git-send-email-odpbot@yandex.ru> References: <1517331619-18755-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 434 Subject: [lng-odp] [PATCH API-NEXT v4 4/15] validation: crypto: drop obsolete GMAC-related hack X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Checking that cipher is not NULL was required because GMAC used NULL cipher to specify it's IV. Now it is obosolete, as auths has their own IV. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 434 (lumag:crypto-upd) ** https://github.com/Linaro/odp/pull/434 ** Patch: https://github.com/Linaro/odp/pull/434.patch ** Base sha: 5718327018debbb02aacb464493504c95fbe57a3 ** Merge commit sha: c5d9389a8d3b1a532e290aff4508756a920173ee **/ test/validation/api/crypto/odp_crypto_test_inp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index 2b0ba1cd9..0448972b8 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -580,9 +580,6 @@ static void check_alg(odp_crypto_op_t op, for (i = 0; i < cipher_num; i++) { cipher_ok |= cipher_tested[i]; if (!cipher_tested[i]) { - /* GMAC-related hacks */ - if (cipher_alg == ODP_CIPHER_ALG_NULL) - continue; printf("\n Untested: alg=%s, key_len=%" PRIu32 ", " "iv_len=%" PRIu32 "\n", cipher_alg_name(cipher_alg),