From patchwork Tue Jan 30 15:00:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 126238 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp3444646ljd; Tue, 30 Jan 2018 07:08:42 -0800 (PST) X-Google-Smtp-Source: AH8x227NuFLEEfNmtIbUmCROm++465xoXa4f1Z7ZpZ/8uOdRgWx3/SMPnOIvlpmuHhaicCjnCsmy X-Received: by 10.55.25.146 with SMTP id 18mr40692285qkz.214.1517324922163; Tue, 30 Jan 2018 07:08:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517324922; cv=none; d=google.com; s=arc-20160816; b=eFPLtRvUZLcIZyeqfC0+ajdR1ys49EEn6Sgv/VnNngheEXWSiRF0oyueBvR2sWq1bY iSl6dJBiT0sylQIj7T+pdqzWuXmCeW8tY8ZtKOAjFLQI5vlKu+7bdvNW5pwgbeSil484 kvSGySwbzJ6D/tYuEQEj5Ul9wRP8ZyT21x3qFjY7lmbeDpP10pKWWGa23Gz2f686xM6K Hvmqm+1dW+IYJ3OVBIefztx66vQF4q2YVgZ2tFkPjvTqUMn0uBCL+JSt2Bp4JJsjd5K5 0aQRr7NJIlJiQpjGMbCLSENLvjiOJbOWhdTcAVPc1tZVVIfAC4gI4GWrmTs4yEULeb4c eadA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=b6R1Xm4ZWmPDprMXfZQjfx+H2EU1PXbcrmoD2WEf5AM=; b=VwjK0ms7g+6m9VhUHKuJnCXNhoNjqCxHGIppXt2TjZEoXT0fgum8wpmvWNJllHMhwu O/IYXXOKq7hXrYhF8CyheZNQc0Y3aaiiF2XG4biUAvagdKd6otshs7sNOxJ23y3AS1xx YilwFMJOY+93ClkNH4oSFczHKyrDyfy+3xkvzTjPqg1+t8x+QZtgltQLxIM0wD/xiArW p0BSlDccP3TD4dQ06hx7J3W+CuRXJIceYQK0MsO7z2I1Q1zaxcARxrA7YE0QtVoP9Pwj slxWHIrunndeW+lKx81ccldj2AoDtHtltYDPhr2JKc02QbmoTXDjRnhuu7XLRlbq7z0o Ne1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id i3si5888440qkc.418.2018.01.30.07.08.41; Tue, 30 Jan 2018 07:08:42 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id B4730616F5; Tue, 30 Jan 2018 15:08:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A61E861704; Tue, 30 Jan 2018 15:01:01 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D87836099A; Tue, 30 Jan 2018 15:00:28 +0000 (UTC) Received: from forward100o.mail.yandex.net (forward100o.mail.yandex.net [37.140.190.180]) by lists.linaro.org (Postfix) with ESMTPS id 8A07160C4C for ; Tue, 30 Jan 2018 15:00:20 +0000 (UTC) Received: from mxback8j.mail.yandex.net (mxback8j.mail.yandex.net [IPv6:2a02:6b8:0:1619::111]) by forward100o.mail.yandex.net (Yandex) with ESMTP id E2B442A21799 for ; Tue, 30 Jan 2018 18:00:18 +0300 (MSK) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback8j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id BQRHzwYhlW-0IfGvmdp; Tue, 30 Jan 2018 18:00:18 +0300 Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id sxKD104gxy-0IrSmfGl; Tue, 30 Jan 2018 18:00:18 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 30 Jan 2018 18:00:01 +0300 Message-Id: <1517324412-24567-7-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517324412-24567-1-git-send-email-odpbot@yandex.ru> References: <1517324412-24567-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 434 Subject: [lng-odp] [PATCH API-NEXT v3 6/17] validation: crypto: drop obsolete GMAC-related hack X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Checking that cipher is not NULL was required because GMAC used NULL cipher to specify it's IV. Now it is obosolete, as auths has their own IV. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 434 (lumag:crypto-upd) ** https://github.com/Linaro/odp/pull/434 ** Patch: https://github.com/Linaro/odp/pull/434.patch ** Base sha: abc7b3bb0babe8efa0fde52752bcd514f2f0d422 ** Merge commit sha: 15e0c830b5937ae889b7bcf6822797dbe0ecb799 **/ test/validation/api/crypto/odp_crypto_test_inp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index 2b0ba1cd9..0448972b8 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -580,9 +580,6 @@ static void check_alg(odp_crypto_op_t op, for (i = 0; i < cipher_num; i++) { cipher_ok |= cipher_tested[i]; if (!cipher_tested[i]) { - /* GMAC-related hacks */ - if (cipher_alg == ODP_CIPHER_ALG_NULL) - continue; printf("\n Untested: alg=%s, key_len=%" PRIu32 ", " "iv_len=%" PRIu32 "\n", cipher_alg_name(cipher_alg),