From patchwork Sat Jan 27 06:00:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 126029 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp841664ljd; Fri, 26 Jan 2018 22:03:15 -0800 (PST) X-Google-Smtp-Source: AH8x225TdA/bETkR4m/dZuroMXLdPwb2gd1Z0x1XBRycBLNu0RKR2e8iVcdBZv/qoSD1eKogGjFN X-Received: by 10.55.162.150 with SMTP id l144mr24670845qke.336.1517032995003; Fri, 26 Jan 2018 22:03:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517032994; cv=none; d=google.com; s=arc-20160816; b=mZMExqsHb/yAoK4AtR3HbNgUpLQMcyr1NHdUFdOLwYK+LUUs8nREcQk6rb8TMkPnmW ZBNX4lgP0Oar7gOyDPkxJWqW7FOYVIXd/mfuA+AeZIn78YtVMU6TM7l5TU1oYrU72hI7 JwFaXnfxPcdRVAF2Awxox2pLhglvynEJ2XmY2J4vkIIrfFNXjJr70+b/aNRfngorNapH IMnk1qDG+mONyvXztAHPgDOGCQH3sbcHpelzJsZFQIsImAsNeoUHwwl/9+B9ERoC/WlD HyvzRPR/eL3yCj70u0z7/Ba3BKodAzsidYkX0uhKKM0M7GTO8pKbopnwNkyUjp537q6J ofrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=6tHwjXj5rV5e7ehqvl7H6n45DfNKwlXZ6Tzf1qKtvZQ=; b=fnz9L+Kt6RXN8iLgDwE7qfJII108UptziUl9LeMHUha4JGsZR0dKMfYsWpvuwdWLKU MSrwwsuBqsteVHOKRk9y6nuZpTQVA6Ma2k+xMHPSmWajI57FjRAXpO8U4w04Qmt0ZcJ0 Z23/mo/M3gsQCRKPjpetmjKyTapWUEc5bbWyEnSBfdBS80FgZev8Ve/hwSf4B9ZOP550 yWZZPKSfI0D6eBimoJ7qx40mzd8nJt7tr58l0T8CWnD7dVq8mWEN9E7dj8NOcNHwzkb2 kotE8DU33ugr1jhL7+xtDaws1o+OaXlmKzPJ5FlXUdnt0Mv5h1T8Ubuxf7/Vj33AKu1g rHwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id f9si488773qke.33.2018.01.26.22.03.14; Fri, 26 Jan 2018 22:03:14 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id B7541617D4; Sat, 27 Jan 2018 06:03:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 7D9C3617CC; Sat, 27 Jan 2018 06:00:45 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 35938617B8; Sat, 27 Jan 2018 06:00:23 +0000 (UTC) Received: from forward101p.mail.yandex.net (forward101p.mail.yandex.net [77.88.28.101]) by lists.linaro.org (Postfix) with ESMTPS id DEE23616F4 for ; Sat, 27 Jan 2018 06:00:17 +0000 (UTC) Received: from mxback2o.mail.yandex.net (mxback2o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::1c]) by forward101p.mail.yandex.net (Yandex) with ESMTP id 6CFB36A83653 for ; Sat, 27 Jan 2018 09:00:16 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback2o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 73Vktm3raG-0G0eHg7h; Sat, 27 Jan 2018 09:00:16 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id JSKreAboNf-0FNOpNtm; Sat, 27 Jan 2018 09:00:15 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Sat, 27 Jan 2018 09:00:00 +0300 Message-Id: <1517032810-971-7-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517032810-971-1-git-send-email-odpbot@yandex.ru> References: <1517032810-971-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 434 Subject: [lng-odp] [PATCH API-NEXT v1 6/16] validation: crypto: drop obsolete GMAC-related hack X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Checking that cipher is not NULL was required because GMAC used NULL cipher to specify it's IV. Now it is obosolete, as auths has their own IV. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 434 (lumag:crypto-upd) ** https://github.com/Linaro/odp/pull/434 ** Patch: https://github.com/Linaro/odp/pull/434.patch ** Base sha: 0bdad6d2562166eec4abeb957b6bb5067de9fe94 ** Merge commit sha: 8cc286211b098976aafc39992f510742cefc7118 **/ test/validation/api/crypto/odp_crypto_test_inp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index 2b0ba1cd9..0448972b8 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -580,9 +580,6 @@ static void check_alg(odp_crypto_op_t op, for (i = 0; i < cipher_num; i++) { cipher_ok |= cipher_tested[i]; if (!cipher_tested[i]) { - /* GMAC-related hacks */ - if (cipher_alg == ODP_CIPHER_ALG_NULL) - continue; printf("\n Untested: alg=%s, key_len=%" PRIu32 ", " "iv_len=%" PRIu32 "\n", cipher_alg_name(cipher_alg),