From patchwork Thu Dec 28 01:00:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 122827 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2860173qgn; Wed, 27 Dec 2017 17:02:01 -0800 (PST) X-Google-Smtp-Source: ACJfBouaXmabSXrtRm4OAJOReZGHIyH1Nr7z/O3Sa+32I17c2TVMMah675npQYf8ervxNDlrcy0F X-Received: by 10.55.39.210 with SMTP id n201mr39811246qkn.116.1514422921655; Wed, 27 Dec 2017 17:02:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514422921; cv=none; d=google.com; s=arc-20160816; b=WcI0Fx1vz7DKvtT9ylatAvVSmhjqa0l1RwZpdw9wHFS4Sq8UO66OjadmB5YVaL7k/e j9FOq/SKA2AD25ekA0x/ZkxawfCAZhf4UmRs4TpMZxmuiEqdLl6fQ/hIdumueXDaEMlq BCk/oI4vOY9s1F9P2Fa98UClo4Q+2N/6yt/4IEDlyvsWOQnpxI9YfY1+ry5ebX/TBqfJ dBWNt4izrqSb/y4busnIJn98EAPlf41ntJg8dwjf5fjHVm5x2AFcdUrw6lZTNcwSnLGc BbBS8VKy1s85cgz7KHWstZED55UaElXGq/q7+qwYESo0tdUxPJO5oYEtziOUEmbV7uTa y+LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=KJ41XU2P0jt6Y35JyuNtFS1+ImVlHr5E0uQD7BObgFE=; b=Qfy+EFUOGZm+hl62iEOepZTtJdOFDVdnwOX3QbKh5VxuV9Fg+qNnJK6RNgeyqI9bFc aX8O0FivmQaTxt+SreOUMhsFoqWs8le4fS/9ogsezvMz82GzWx/Dx4o6xJq4pH8oDERd VwhAtoj8153/LmPsnfPfq/0klLL8BduuR+MOd3yHwqInWpSxTi+ZuyrpRdZhA7lkBOfe 421Ftl7bRMC9BKPhuozxTyvbEoVtqoqXFBxhcgGvKbS+/wBVjfh2dPF1QrHRRpPDs+Fj kRUbeaC4e3aOokGKwWIzmTOhXKrwfH8PDlPqxwO4+k/IyWtU7vcRNSqP20A9p5E4D7e1 CioQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id i23si3356960qti.155.2017.12.27.17.02.01; Wed, 27 Dec 2017 17:02:01 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 5AC5C6099A; Thu, 28 Dec 2017 01:02:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E8C7F614FE; Thu, 28 Dec 2017 01:01:07 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id ABE93614E3; Thu, 28 Dec 2017 01:01:01 +0000 (UTC) Received: from forward105o.mail.yandex.net (forward105o.mail.yandex.net [37.140.190.183]) by lists.linaro.org (Postfix) with ESMTPS id 17DC160AEF for ; Thu, 28 Dec 2017 01:00:18 +0000 (UTC) Received: from mxback4g.mail.yandex.net (mxback4g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:165]) by forward105o.mail.yandex.net (Yandex) with ESMTP id 933ED4444FC8 for ; Thu, 28 Dec 2017 04:00:16 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback4g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id yVhxoofUUr-0GpOwwhr; Thu, 28 Dec 2017 04:00:16 +0300 Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id VMPEZNaPaw-0GoWLVIv; Thu, 28 Dec 2017 04:00:16 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 28 Dec 2017 04:00:07 +0300 Message-Id: <1514422807-6007-4-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514422807-6007-1-git-send-email-odpbot@yandex.ru> References: <1514422807-6007-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 374 Subject: [lng-odp] [PATCH API-NEXT v3 3/3] api: crypto: deprecate DES algorithm X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov DES is too weak, 56-bit keys, 64-bit blocks. Can be cracked nearly bare-handed nowadays. Depreate it now, to be dropped in next release. Note: Tripple-DES (TDES) remains in place. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 374 (lumag:no-des) ** https://github.com/Linaro/odp/pull/374 ** Patch: https://github.com/Linaro/odp/pull/374.patch ** Base sha: a7b46491ca049998dc38b0a5b29213a407931523 ** Merge commit sha: ff1bca033a3fe0d12c1309ba04b1f9d97d6e95a5 **/ include/odp/api/spec/crypto.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h index 81fecbc36..92a02d409 100644 --- a/include/odp/api/spec/crypto.h +++ b/include/odp/api/spec/crypto.h @@ -71,9 +71,6 @@ typedef enum { /** No cipher algorithm specified */ ODP_CIPHER_ALG_NULL, - /** DES */ - ODP_CIPHER_ALG_DES, - /** Triple DES with cipher block chaining */ ODP_CIPHER_ALG_3DES_CBC, @@ -95,6 +92,9 @@ typedef enum { /** @deprecated Use ODP_CIPHER_ALG_AES_GCM instead */ ODP_DEPRECATE(ODP_CIPHER_ALG_AES128_GCM), + /** @deprecated Do not use DES, 56-bit keys are too weak nowadays */ + ODP_DEPRECATE(ODP_CIPHER_ALG_DES), + } odp_cipher_alg_t; /** @@ -168,9 +168,6 @@ typedef union odp_crypto_cipher_algos_t { /** ODP_CIPHER_ALG_NULL */ uint32_t null : 1; - /** ODP_CIPHER_ALG_DES */ - uint32_t des : 1; - /** ODP_CIPHER_ALG_3DES_CBC */ uint32_t trides_cbc : 1; @@ -189,6 +186,9 @@ typedef union odp_crypto_cipher_algos_t { /** @deprecated Use aes_gcm instead */ uint32_t ODP_DEPRECATE(aes128_gcm) : 1; + /** @deprecated Too weak, do not use */ + uint32_t ODP_DEPRECATE(des) : 1; + } bit; /** All bits of the bit field structure