From patchwork Thu Dec 28 01:00:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 122825 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp2859650qgn; Wed, 27 Dec 2017 17:01:28 -0800 (PST) X-Google-Smtp-Source: ACJfBose2xsVHNFO+dhxSWB3O7uI5TPxxnDafp3micXgZ4tKWCLFHW8D3NsHF81uAgoW+dxZroAu X-Received: by 10.200.27.116 with SMTP id p49mr42221706qtk.118.1514422888594; Wed, 27 Dec 2017 17:01:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1514422888; cv=none; d=google.com; s=arc-20160816; b=KMS7/PlE6U2bMKikztktQhzb2rHt+Dn2vJ0ZM2yWd12mV71yWSGz5vcK6HT1ntLyCa 7aX97jXj+tJLR3npF7xUEkscqdfaf+ZvZuQgbhVYAj0ZylnYZO8RmjIXy45Tg3oKXVI3 9KTEB2rkY3huKAmb1Oikea7eBEhJhApeGCB+MOYeCxM0Nt0HQoLyRspafE8FCLqkCOk4 mndIXTaZ08MEk9eWRKgraNKiaPyrVw9j2jHQJF8apBUM3uRHOo+YW8DS74yhR/VnmeJN jy/W4PpQeQVAVnlgfoQi78WH/iftgtVAbkJyAAG5u8CZOKlAdSv+ikvox/PBDZhClQkE z9bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=63XTHVJEB/inFXxZD6rz09akbzWczf7GAS1qNpcIjbk=; b=D6yQ2AxFrDawbLTiL6Ml8Cr0jA/cEb+x/nZkV6GdH5S4GR3ezyXH+kp5LI/RDNbfPv 6xkwpIzCgFzxPD8grJn0ZQiv+SyyWI7/4sV4Te6sxebc1H5N2nf53er7TOF+ZjuBWZPy VKUZflzIMGEf9oji47Aje1UDB9KnJMj9eSS2SGDXAWj3mKE/e+Lc+jfQ2xXR7VXZMqG4 lQUNzz/kCk7LWo4cTY1nr1rV+tCmoNUJx1F16hQOCaCbE13cTwth8DOb5ASxEbOBW0vF YGyUiV+1sN6z94ofi93GdoK0iEZ2GUdMFkJBm3PisPWqxLmrg8s+fQEaIBQe72ZfyiOK gjPA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id y35si1583808qth.349.2017.12.27.17.01.28; Wed, 27 Dec 2017 17:01:28 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 3E00B60974; Thu, 28 Dec 2017 01:01:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 705936097D; Thu, 28 Dec 2017 01:00:56 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 759AE6097F; Thu, 28 Dec 2017 01:00:52 +0000 (UTC) Received: from forward100o.mail.yandex.net (forward100o.mail.yandex.net [37.140.190.180]) by lists.linaro.org (Postfix) with ESMTPS id 99C4B6099A for ; Thu, 28 Dec 2017 01:00:17 +0000 (UTC) Received: from mxback12g.mail.yandex.net (mxback12g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:91]) by forward100o.mail.yandex.net (Yandex) with ESMTP id 119412A22FBE for ; Thu, 28 Dec 2017 04:00:16 +0300 (MSK) Received: from smtp1j.mail.yandex.net (smtp1j.mail.yandex.net [2a02:6b8:0:801::ab]) by mxback12g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id mfEnhM9zhR-09X0V0JL; Thu, 28 Dec 2017 04:00:10 +0300 Received: by smtp1j.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id VMPEZNaPaw-09o8UTr9; Thu, 28 Dec 2017 04:00:09 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 28 Dec 2017 04:00:06 +0300 Message-Id: <1514422807-6007-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1514422807-6007-1-git-send-email-odpbot@yandex.ru> References: <1514422807-6007-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 374 Subject: [lng-odp] [PATCH API-NEXT v3 2/3] validation: crypto, ipsec: stop supporting DES operation X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov RFC 7321 (and RFC 8221) mark single-key DES as 'MUST NOT' be implemented. Single-key DES is being phased out of ODP, so drop its support. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 374 (lumag:no-des) ** https://github.com/Linaro/odp/pull/374 ** Patch: https://github.com/Linaro/odp/pull/374.patch ** Base sha: a7b46491ca049998dc38b0a5b29213a407931523 ** Merge commit sha: ff1bca033a3fe0d12c1309ba04b1f9d97d6e95a5 **/ test/validation/api/crypto/odp_crypto_test_inp.c | 9 --------- test/validation/api/ipsec/ipsec.c | 4 ---- 2 files changed, 13 deletions(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index f1da6989c..0f3f800ac 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -62,8 +62,6 @@ static const char *cipher_alg_name(odp_cipher_alg_t cipher) switch (cipher) { case ODP_CIPHER_ALG_NULL: return "ODP_CIPHER_ALG_NULL"; - case ODP_CIPHER_ALG_DES: - return "ODP_CIPHER_ALG_DES"; case ODP_CIPHER_ALG_3DES_CBC: return "ODP_CIPHER_ALG_3DES_CBC"; case ODP_CIPHER_ALG_AES_CBC: @@ -339,9 +337,6 @@ static void alg_test(odp_crypto_op_t op, if (cipher_alg == ODP_CIPHER_ALG_AES_GCM && !(capa.ciphers.bit.aes_gcm)) rc = -1; - if (cipher_alg == ODP_CIPHER_ALG_DES && - !(capa.ciphers.bit.des)) - rc = -1; if (cipher_alg == ODP_CIPHER_ALG_NULL && !(capa.ciphers.bit.null)) rc = -1; @@ -560,10 +555,6 @@ static int check_alg_support(odp_cipher_alg_t cipher, odp_auth_alg_t auth) if (!capability.ciphers.bit.null) return ODP_TEST_INACTIVE; break; - case ODP_CIPHER_ALG_DES: - if (!capability.ciphers.bit.des) - return ODP_TEST_INACTIVE; - break; case ODP_CIPHER_ALG_3DES_CBC: if (!capability.ciphers.bit.trides_cbc) return ODP_TEST_INACTIVE; diff --git a/test/validation/api/ipsec/ipsec.c b/test/validation/api/ipsec/ipsec.c index ea3cff052..effe6fb02 100644 --- a/test/validation/api/ipsec/ipsec.c +++ b/test/validation/api/ipsec/ipsec.c @@ -157,10 +157,6 @@ int ipsec_check(odp_bool_t ah, if (!capa.ciphers.bit.null) return ODP_TEST_INACTIVE; break; - case ODP_CIPHER_ALG_DES: - if (!capa.ciphers.bit.des) - return ODP_TEST_INACTIVE; - break; case ODP_CIPHER_ALG_3DES_CBC: if (!capa.ciphers.bit.trides_cbc) return ODP_TEST_INACTIVE;