From patchwork Mon Dec 11 21:00:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 121463 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp3278839qgn; Mon, 11 Dec 2017 13:01:31 -0800 (PST) X-Google-Smtp-Source: ACJfBov37lyEq+XPuqOndv0BwMW/q8O/tOJ3hfwG7bEiDBrcC+NmxqVlrXqSsw0rgzh55DDjzOkA X-Received: by 10.200.26.108 with SMTP id q41mr2643261qtk.7.1513026091803; Mon, 11 Dec 2017 13:01:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513026091; cv=none; d=google.com; s=arc-20160816; b=Is86GB0YexwA0J686ohvSgmbVdJxeAVf6WRDjBP0hz+IOh2ESYO9GqXW59UVg37dL8 2F4wW/LCU9OGkvzZHZANrE+1DceYCjY2kLFZeE3uR3Xmje6pakC3uRFVEQwnIe5rEDS7 6U6Nn1c8rF1mF9lNNI1ZojVxBU4vQ5+gs5QOHZBg3f2ZGBYpupV/75AiMAwYd7z7RrbQ +Kk0RJ0f85YRiGFcwyCdoKYJTNhVoNE+bKC/m+MAquTinLz7GXigl4kVInuf41nbYb6Y 4OTUIZuFZo8OvqzzeW2vmVakHvYpaD2hBDBrdW2PW4Y4tm5nYeYrLnTC/+ZDdBUIZZvB 7GrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=Z92HObaWd47YYNOdVt26wQZFjKujBAyQtRHSAKFwSV0=; b=baC/f1kYiRHHc0YP9cESsbw+risUJdMtNXcY2ppP8acFTT71HEtWjNM3JS9aFSNlPE 9zYsfPYyNcTuWczssBwTVjhUo78DdMoTPYAJwsGfjNiU9wpAXfNAu1u6yNn4DBns7cB3 XbObyBQyPwQE17ZGGl67dQbjB5tOWfjp7uvhUr+CgSfI7nnRA7A8D/iiEH4vuQxKuz68 EihbPbbLOuEXUlJ7HFguzTdAGw2YySffchJMrYLWNI2gQ37VFekx/Y1AB2KspeaA+pWp GDRoiJ9MtW0AuhUjWAEiQWUtbUTC8ra3G/EBTQasGkWZgnllY+GKACeYgnqDrAfKQPzg tPmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id a9si1408880qtg.455.2017.12.11.13.01.31; Mon, 11 Dec 2017 13:01:31 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 43F6B6097B; Mon, 11 Dec 2017 21:01:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0D8F96097D; Mon, 11 Dec 2017 21:00:33 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8768F608E8; Mon, 11 Dec 2017 21:00:26 +0000 (UTC) Received: from forward105p.mail.yandex.net (forward105p.mail.yandex.net [77.88.28.108]) by lists.linaro.org (Postfix) with ESMTPS id 689F1608E6 for ; Mon, 11 Dec 2017 21:00:24 +0000 (UTC) Received: from mxback7g.mail.yandex.net (mxback7g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:168]) by forward105p.mail.yandex.net (Yandex) with ESMTP id DE9704083BC6 for ; Tue, 12 Dec 2017 00:00:22 +0300 (MSK) Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [2a02:6b8:0:1a2d::27]) by mxback7g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 15eXwxvZVA-0M0eKx5t; Tue, 12 Dec 2017 00:00:22 +0300 Received: by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id YE9KORLQTE-0MbiuWV7; Tue, 12 Dec 2017 00:00:22 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 12 Dec 2017 00:00:19 +0300 Message-Id: <1513026020-24993-3-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513026020-24993-1-git-send-email-odpbot@yandex.ru> References: <1513026020-24993-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 325 Subject: [lng-odp] [PATCH v3 2/3] linux-generic: pool: avoid direct use of printf() in check_params X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Bill Fischofer Use ODP_DBG() for diagnostic error prints rather than direct use of printf(). This allows errors to be output conditionally and via the log function. Signed-off-by: Bill Fischofer --- /** Email created from pull request 325 (Bill-Fischofer-Linaro:bug3465) ** https://github.com/Linaro/odp/pull/325 ** Patch: https://github.com/Linaro/odp/pull/325.patch ** Base sha: 6881620135a179911a5839d4be97423a8d80e5ab ** Merge commit sha: 031d1e139f0c3b25b906fc9c79120fd327a758c4 **/ platform/linux-generic/odp_pool.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/platform/linux-generic/odp_pool.c b/platform/linux-generic/odp_pool.c index b3c652360..d0e4674f9 100644 --- a/platform/linux-generic/odp_pool.c +++ b/platform/linux-generic/odp_pool.c @@ -534,17 +534,17 @@ static int check_params(odp_pool_param_t *params) switch (params->type) { case ODP_POOL_BUFFER: if (params->buf.num > capa.buf.max_num) { - printf("buf.num too large %u\n", params->buf.num); + ODP_DBG("buf.num too large %u\n", params->buf.num); return -1; } if (params->buf.size > capa.buf.max_size) { - printf("buf.size too large %u\n", params->buf.size); + ODP_DBG("buf.size too large %u\n", params->buf.size); return -1; } if (params->buf.align > capa.buf.max_align) { - printf("buf.align too large %u\n", params->buf.align); + ODP_DBG("buf.align too large %u\n", params->buf.align); return -1; } @@ -552,25 +552,25 @@ static int check_params(odp_pool_param_t *params) case ODP_POOL_PACKET: if (params->pkt.len > capa.pkt.max_len) { - printf("pkt.len too large %u\n", params->pkt.len); + ODP_DBG("pkt.len too large %u\n", params->pkt.len); return -1; } if (params->pkt.max_len > capa.pkt.max_len) { - printf("pkt.max_len too large %u\n", - params->pkt.max_len); + ODP_DBG("pkt.max_len too large %u\n", + params->pkt.max_len); return -1; } if (params->pkt.seg_len > capa.pkt.max_seg_len) { - printf("pkt.seg_len too large %u\n", - params->pkt.seg_len); + ODP_DBG("pkt.seg_len too large %u\n", + params->pkt.seg_len); return -1; } if (params->pkt.uarea_size > capa.pkt.max_uarea_size) { - printf("pkt.uarea_size too large %u\n", - params->pkt.uarea_size); + ODP_DBG("pkt.uarea_size too large %u\n", + params->pkt.uarea_size); return -1; } @@ -578,13 +578,13 @@ static int check_params(odp_pool_param_t *params) case ODP_POOL_TIMEOUT: if (params->tmo.num > capa.tmo.max_num) { - printf("tmo.num too large %u\n", params->tmo.num); + ODP_DBG("tmo.num too large %u\n", params->tmo.num); return -1; } break; default: - printf("bad pool type %i\n", params->type); + ODP_DBG("bad pool type %i\n", params->type); return -1; }