From patchwork Tue Oct 24 11:00:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 116941 Delivered-To: patch@linaro.org Received: by 10.140.22.164 with SMTP id 33csp5664651qgn; Tue, 24 Oct 2017 04:02:08 -0700 (PDT) X-Google-Smtp-Source: ABhQp+Rjl2TCV/cuGNMXsUiZk/XPACSMfeLQRA2MvEVx5+lc+wLBKJKQ53JekvhnjInz2dXaQi2a X-Received: by 10.55.195.11 with SMTP id a11mr22058872qkj.222.1508842928138; Tue, 24 Oct 2017 04:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508842928; cv=none; d=google.com; s=arc-20160816; b=w4n9vA68cBSATq84Oo3Nf/7GYjicMRMHJQVfhjx+uImvbqrvGlCQbGXdxKRryCqfoD HtkHd5jF/ta6kURa9tOgj+4TVYWm31wDHzyW6bOLBmFcuuJjr3Io4e5WB0p+gOTvJdYl R7f17OiqTp7Zt/eEL+yiqHD0sPdljbITD8V9REH1ywkwCaj51QKUKj5K0Rc0c/0GYvst P1UYktI1f9QPEevqoG9ystM/u+jnRXCdzl3YzfbMKiYM9khqHioPE+z2KFayOjVWErVn aaUsci2MQcoIZgz6A4q7HOxcpaBNglt2uT5mw106emd26LsWKdERrL34Pv1PVhhRNJtz T6pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=G2IoDO98ESTKohHSsQj9bkw2NCYZWJ4KaB2TDBor1NU=; b=eehvY/CcmiGHDfQGEwfD9TXYEOFcjkusmMMM0WsFPvBnxJoPreG+JmYy1nyXB1wcnA S090yLRqRNKXamUMyb3UgQ8qv2UYsZ3bjfQ+/kQHlsEYojTkndt3KHEbxk+2dkKdZB9V Y8GfjwTGCu3H0Rd8Nu+fmV9tvtW5U+azJ0QKYEdrfRfbBTvgkDWK5xNP2xfc9vJIEcIs nzGYXNGxluD5cGeOXFTEp1ysp7ZPxlJtGO96O3I+uVD4/8D8RCt6t2JK0xKMv0Y6k+hS UOVN8Nqcuxxxl7Xr1ZJH6i17CoK5bgDMxnz5suvszuqkk5VmWZgDrwcagnoGDADkjsSv spOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id q128si13194qkb.335.2017.10.24.04.02.07; Tue, 24 Oct 2017 04:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id D0E12628B4; Tue, 24 Oct 2017 11:02:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A28FD628C0; Tue, 24 Oct 2017 11:00:50 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3815E628B4; Tue, 24 Oct 2017 11:00:36 +0000 (UTC) Received: from forward102j.mail.yandex.net (forward102j.mail.yandex.net [5.45.198.243]) by lists.linaro.org (Postfix) with ESMTPS id 7CBE4622CF for ; Tue, 24 Oct 2017 11:00:29 +0000 (UTC) Received: from mxback8j.mail.yandex.net (mxback8j.mail.yandex.net [IPv6:2a02:6b8:0:1619::111]) by forward102j.mail.yandex.net (Yandex) with ESMTP id 010A756023E3 for ; Tue, 24 Oct 2017 14:00:28 +0300 (MSK) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback8j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id czKHaxeKtz-0RiKq6sE; Tue, 24 Oct 2017 14:00:27 +0300 Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id hdAvnRHsih-0RPCSZXp; Tue, 24 Oct 2017 14:00:27 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 24 Oct 2017 14:00:04 +0300 Message-Id: <1508842806-17934-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508842806-17934-1-git-send-email-odpbot@yandex.ru> References: <1508842806-17934-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 256 Subject: [lng-odp] [PATCH API-NEXT v1 1/3] api: ipsec: rework ODP_IPSEC_SA_DISABLE into packet error X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov According to the discussion on mailing list, most of implementations will not be able to support odp_ipsec_sa_disable() status event directly. Instead they will submit a dummy packet to that SA. Then after receiving this packet after odp_ipsec_result() will detect this packet and will report it as a packet with odp_ipsec_error_t->sa_disabled bit set. Signed-off-by: Dmitry Eremin-Solenikov Cc: Nikhil Agarwal Cc: Balasubramanian Manoharan --- /** Email created from pull request 256 (lumag:ipsec_sa_disable_v2) ** https://github.com/Linaro/odp/pull/256 ** Patch: https://github.com/Linaro/odp/pull/256.patch ** Base sha: 825f75ed8644ef57c5648961e7982daf13cd9375 ** Merge commit sha: 1bab6bb255422c8eb061c6482397eb498fc7b1cc **/ include/odp/api/spec/ipsec.h | 38 ++++++++++++++------------------------ 1 file changed, 14 insertions(+), 24 deletions(-) diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h index 26e852fca..f550b6bac 100644 --- a/include/odp/api/spec/ipsec.h +++ b/include/odp/api/spec/ipsec.h @@ -842,11 +842,12 @@ odp_ipsec_sa_t odp_ipsec_sa_create(const odp_ipsec_sa_param_t *param); * the SA and be processed successfully. * * When in synchronous operation mode, the call will return when it's possible - * to destroy the SA. In asynchronous mode, the same is indicated by an - * ODP_EVENT_IPSEC_STATUS event sent to the queue specified for the SA. The - * status event is guaranteed to be the last event for the SA, i.e. all + * to destroy the SA. In asynchronous mode, the same is indicated by a packet + * event sent to the queue specified for the SA having sa_disabled error bit + * set. The packet is guaranteed to be the last event for the SA, i.e. all * in-progress operations have completed and resulting events (including status - * events) have been enqueued before it. + * events) have been enqueued before it. The will be no more packets coming + * from SA queue. * * @param sa IPSEC SA to be disabled * @@ -914,6 +915,8 @@ typedef struct odp_ipsec_error_t { /** Hard lifetime expired: packets */ uint32_t hard_exp_packets : 1; + + uint32_t sa_disabled : 1; }; /** All error bits @@ -927,7 +930,12 @@ typedef struct odp_ipsec_error_t { } odp_ipsec_error_t; -/** IPSEC warnings */ +/** IPSEC warnings + * + * For outbound SAs in ODP_IPSEC_OP_MODE_INLINE mode warnings can be reported + * only as status events. In all other cases warnings can be reported either as + * a part of packet result or via separate ODP status event. + */ typedef struct odp_ipsec_warn_t { /** IPSEC warnings */ union { @@ -1133,15 +1141,6 @@ typedef struct odp_ipsec_packet_result_t { * IPSEC status ID */ typedef enum odp_ipsec_status_id_t { - /** Response to SA disable command - * - * Following status event (odp_ipsec_status_t) fields have valid - * content, other fields must be ignored: - * - sa: The SA that was requested to be disabled - * - result: Operation result - */ - ODP_IPSEC_STATUS_SA_DISABLE = 0, - /** Warning from inline IPSEC processing * * Following status event (odp_ipsec_status_t) fields have valid @@ -1152,7 +1151,7 @@ typedef enum odp_ipsec_status_id_t { * This status event is generated only for outbound SAs in * ODP_IPSEC_OP_MODE_INLINE mode. */ - ODP_IPSEC_STATUS_WARN + ODP_IPSEC_STATUS_WARN = 0 } odp_ipsec_status_id_t; @@ -1166,13 +1165,6 @@ typedef struct odp_ipsec_status_t { /** IPSEC SA that was target of the operation */ odp_ipsec_sa_t sa; - /** Result of the operation - * - * 0: Success - * <0: Failure - */ - int result; - /** Warnings of an ODP_IPSEC_STATUS_WARN status event */ odp_ipsec_warn_t warn; @@ -1469,8 +1461,6 @@ int odp_ipsec_result(odp_ipsec_packet_result_t *result, odp_packet_t packet); * * @retval 0 On success * @retval <0 On failure - * - * @see odp_ipsec_sa_disable() */ int odp_ipsec_status(odp_ipsec_status_t *status, odp_event_t event);