From patchwork Tue Oct 17 13:00:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 116090 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp4870243qgn; Tue, 17 Oct 2017 06:06:28 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TRSPzOthDncK7+7aQ4lYNwhxndWgqifpHSalZ2r5KA7k13xMaa8LOVMf9mmkBNPRro3gAx X-Received: by 10.36.50.140 with SMTP id j134mr343894ita.98.1508245588744; Tue, 17 Oct 2017 06:06:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508245588; cv=none; d=google.com; s=arc-20160816; b=mSuDNZbW4DO9p+xfh5ufN8jdruFqpyWIl/JZv8COpHT4fI7YKDiMIP2NktkDjoYCpj hPYXlcS3UcxBCOqM53bpJPcO4IMHZXuyfLoiOXbXa0ZL+RqavTQkhmG3xU1luqu0sRmK dDm1rghz61FQmh6gMDxjM/A6ljA0D6d4UXbSGjnS824B7QUW78Kbbn62tn9S/j/bYq2Y N748lgnpAo1hPFQyQyiXLLsJCUz2Cjtp4HUDfkFpjv2bjmLmW35Ikt++toB+1+LAi2gn /1Vq+s7qaD7EQq+UxadW3/Tng1MkL74HDca1nNrb5wVFEQfvMixI88NKgzpKq+SXXZvg UsPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=W3Sfq+qU7VyeFSjodUEgP+XThaUzK9TICk9Mpa04q94=; b=uvx6ndW2+uIBK9JzoGkExcm4eZB45E+UhStah0TZ6apFlFXqtvL0o0RJxiOc0tIapv MCrPuAmJTm4x2N2hPNTYvKOFcFIVfNi0EXvuwQAKApaQ3KCmdWZUBNkA+rBKcvgJbAz4 isbA8tycHpM5tzVFHcag+JKhSEXXQ7ci1iUQSbW+mLLtHUmMGwVhs1yg6WrcwLR3K0T7 41Bd4fYFsm1ViLWvkmD1+BIf9jZbf0uNs2fMqdChiKh932BS9DJa9E763HLrrSQUlgw3 WO7vZLGy8OBQ4eDPL+DNDcETOpBPWMEFAnIzh80tBAPMJ5I3VI5r+qnbZaxvzouhWOyh i6Ww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id w65si7310360ith.120.2017.10.17.06.06.28; Tue, 17 Oct 2017 06:06:28 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 3C24862986; Tue, 17 Oct 2017 13:06:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 9028A622E3; Tue, 17 Oct 2017 13:00:48 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id BF5896100C; Tue, 17 Oct 2017 13:00:27 +0000 (UTC) Received: from forward100p.mail.yandex.net (forward100p.mail.yandex.net [77.88.28.100]) by lists.linaro.org (Postfix) with ESMTPS id 0DD9E60C1D for ; Tue, 17 Oct 2017 13:00:18 +0000 (UTC) Received: from mxback14g.mail.yandex.net (mxback14g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:93]) by forward100p.mail.yandex.net (Yandex) with ESMTP id C0FE65104267 for ; Tue, 17 Oct 2017 16:00:16 +0300 (MSK) Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [2a02:6b8:0:1a2d::28]) by mxback14g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id YhHpFPTo0z-0GvmHDoH; Tue, 17 Oct 2017 16:00:16 +0300 Received: by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id MWBGlG1zBA-0Goa6bxh; Tue, 17 Oct 2017 16:00:16 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 17 Oct 2017 16:00:01 +0300 Message-Id: <1508245207-16744-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1508245207-16744-1-git-send-email-odpbot@yandex.ru> References: <1508245207-16744-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 235 Subject: [lng-odp] [PATCH v1 4/10] configure: cleanup per-platform if X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Move setting IMPLEMENTATION_NAME to platform configure.m4. Use AS_IF instead of handcoded if. Use AC_MSG_ERROR instead of echo & exit. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 235 (lumag:plat-def-2) ** https://github.com/Linaro/odp/pull/235 ** Patch: https://github.com/Linaro/odp/pull/235.patch ** Base sha: ec0c3145fcafa09ae3a79875e7e07dd4794583cc ** Merge commit sha: c662b285472d8c638ba43867ecfa5e0c7efba9f6 **/ configure.ac | 12 +++--------- platform/linux-generic/m4/configure.m4 | 2 ++ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/configure.ac b/configure.ac index 442c85db4..c419df0f6 100644 --- a/configure.ac +++ b/configure.ac @@ -165,15 +165,9 @@ AC_SUBST([with_platform]) ########################################################################## # Run platform specific checks and settings ########################################################################## -IMPLEMENTATION_NAME="" -if test "${with_platform}" = "linux-generic"; -then - m4_include([./platform/linux-generic/m4/configure.m4]) - IMPLEMENTATION_NAME="odp-linux" -else - echo "UNSUPPORTED PLATFORM: ${with_platform}" - exit 1 -fi +AS_IF([test "${with_platform}" = "linux-generic"], + [m4_include([./platform/linux-generic/m4/configure.m4])], + [AC_MSG_ERROR([UNSUPPORTED PLATFORM: ${with_platform}])]) AC_DEFINE_UNQUOTED([IMPLEMENTATION_NAME], ["$IMPLEMENTATION_NAME"], [Define to the name of the implementation]) diff --git a/platform/linux-generic/m4/configure.m4 b/platform/linux-generic/m4/configure.m4 index 68a270d89..5d7ad35a1 100644 --- a/platform/linux-generic/m4/configure.m4 +++ b/platform/linux-generic/m4/configure.m4 @@ -1,3 +1,5 @@ +IMPLEMENTATION_NAME="odp-linux" + ODP_VISIBILITY ODP_ATOMIC