From patchwork Thu Aug 31 13:00:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 111384 Delivered-To: patch@linaro.org Received: by 10.140.95.112 with SMTP id h103csp2509285qge; Thu, 31 Aug 2017 06:01:47 -0700 (PDT) X-Google-Smtp-Source: ADKCNb66cJ8nEAijFLqJmlgvT3fGd9WaDbly1QzwzsISdRmgUbin1HgfA9URvqdoC2yrHaU3RNlU X-Received: by 10.107.139.84 with SMTP id n81mr4577136iod.159.1504184506990; Thu, 31 Aug 2017 06:01:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1504184506; cv=none; d=google.com; s=arc-20160816; b=oAPbIzR3nr+XdTvqLovHCcC8kR0PgSJNxzWHcD1Y4xs+f6H2+5SI/7QdRLo1AZLEgr +5c5PrF06uJVriKP/sw2hl+1L8hHf0M1QkRvsRAsK+Jpu+yy+3qgyceyOy0HZno1Ssiz RK8IkSvv6Lrm56ZI44alfMObFSXkfZCtJiJKsv/UlPHANNE0xWpX5uE4tBk7ZpEU2WUY N1uYds5L8Vk6bqU8qEOzkHZhq9u4RWFWrsnOGNOhEUdqJBOkwxKh04vv12gYNj6SWUHU gQWyMc2dcc5BXR5Np1s+oEkGRYj/rlGEy2Tw8aQOpk2ER2bH5t5vE/xcdsT+mZNPFEBt UHHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=KYOPHAlHs4diOQ9N9JhqeQh3ebAE02IIeNmKdoRNcSY=; b=XbXofEDrT8YzpehGtZlpRkDBFLsCehBH9OZbm3ds/vpH6vcjFciWLNSqizGF3bxz8L A2O1BtTuCMUJ6hnDyqjtIOzI4NQPnXQch31RoTWT4Nzz9rlJ2m+yIgeFoSBl0GIXh/N9 usIex+o9RrWRXmGckGKH50iv5RVqyYyNDeMAGR9aQHR1oMFp08l+V5ub1bVHU3UEw3pO T/f6wHYq1Q3Ra+HaC5wjErGdhC1d+3pbwObsYPzrNVC+AWoDCXtS0CnQLHFtAae9BcuZ dizaGd49u99A7lgPFIXqSXFk1ZmglpOUMnURXj+vfeJbrpqBu1y98WAwtPAmTCYBGZHS KIUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id b3si89161itd.108.2017.08.31.06.01.46; Thu, 31 Aug 2017 06:01:46 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 7A93A63DB8; Thu, 31 Aug 2017 13:01:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 44C3E60DF2; Thu, 31 Aug 2017 13:00:46 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id BB7C862EF4; Thu, 31 Aug 2017 13:00:30 +0000 (UTC) Received: from forward2p.cmail.yandex.net (forward2p.cmail.yandex.net [77.88.31.17]) by lists.linaro.org (Postfix) with ESMTPS id E327960DF2 for ; Thu, 31 Aug 2017 13:00:24 +0000 (UTC) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b6:6]) by forward2p.cmail.yandex.net (Yandex) with ESMTP id DC53721B4F for ; Thu, 31 Aug 2017 16:00:22 +0300 (MSK) Received: from smtp1p.mail.yandex.net (localhost.localdomain [127.0.0.1]) by smtp1p.mail.yandex.net (Yandex) with ESMTP id 9A7311780D3C for ; Thu, 31 Aug 2017 16:00:21 +0300 (MSK) Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id pHHYqyb8mM-0KtqTYmr; Thu, 31 Aug 2017 16:00:20 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) X-Yandex-Suid-Status: 1 0 From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 31 Aug 2017 16:00:07 +0300 Message-Id: <1504184408-15360-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1504184408-15360-1-git-send-email-odpbot@yandex.ru> References: <1504184408-15360-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 157 Subject: [lng-odp] [PATCH v2 1/2] odp-generator: Use clock related functions less when printing X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Ilias Apalodimas Using odp_time_local() on each iteration consumes too much cpu for no reason Netmap pktio reported ~550kpps prior to this and ~1.2Mpps after the patch, when odp_generator was used as a receiver. Signed-off-by: Ilias Apalodimas --- /** Email created from pull request 157 (apalos:gen_cpu_fix) ** https://github.com/Linaro/odp/pull/157 ** Patch: https://github.com/Linaro/odp/pull/157.patch ** Base sha: 7508c5ac906bb7cb1d339b4c5e924f3a18e504ca ** Merge commit sha: 97c6454f7e6815bb0ef487892e3cfad99ca08c46 **/ example/generator/odp_generator.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index f3ec43be..fad83db5 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -765,11 +765,12 @@ static int gen_recv_thread(void *arg) */ static void print_global_stats(int num_workers) { - odp_time_t cur, wait, next; + odp_time_t cur, wait, next, left; uint64_t pkts_snd = 0, pkts_snd_prev = 0; uint64_t pps_snd = 0, maximum_pps_snd = 0; uint64_t pkts_rcv = 0, pkts_rcv_prev = 0; uint64_t pps_rcv = 0, maximum_pps_rcv = 0; + uint64_t stall = 0; int verbose_interval = 20; odp_thrmask_t thrd_mask; @@ -786,8 +787,14 @@ static void print_global_stats(int num_workers) } cur = odp_time_local(); - if (odp_time_cmp(next, cur) > 0) + if (odp_time_cmp(next, cur) > 0) { + left = odp_time_diff(next, cur); + stall = odp_time_to_ns(left); + stall = (stall / 1000000000) + 1; + stall &= 0xFFFFFFFF; + sleep((unsigned int) stall); continue; + } next = odp_time_sum(cur, wait); switch (args->appl.mode) {