From patchwork Thu Nov 17 15:46:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 82763 Delivered-To: patch@linaro.org Received: by 10.182.1.168 with SMTP id 8csp1014139obn; Thu, 17 Nov 2016 09:23:53 -0800 (PST) X-Received: by 10.37.171.225 with SMTP id v88mr2412026ybi.198.1479403433426; Thu, 17 Nov 2016 09:23:53 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id f127si913687ywa.145.2016.11.17.09.23.53; Thu, 17 Nov 2016 09:23:53 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 00CFF60AC8; Thu, 17 Nov 2016 17:23:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 55C71634E8; Thu, 17 Nov 2016 16:24:23 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 98CE260B2B; Thu, 17 Nov 2016 14:47:24 +0000 (UTC) Received: from mail-qk0-f180.google.com (mail-qk0-f180.google.com [209.85.220.180]) by lists.linaro.org (Postfix) with ESMTPS id B95DD60A4B for ; Thu, 17 Nov 2016 14:47:22 +0000 (UTC) Received: by mail-qk0-f180.google.com with SMTP id n204so222797404qke.2 for ; Thu, 17 Nov 2016 06:47:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TtBxFsfmDy+c010BBY3ZnV7U+rhALCQ3V0igUd1pxMw=; b=Vo7MUMyc/loxrOvQlL9twgxGJdCLudbVX8TYD3LkNnp1SKsp2M0uJyidNGKzmofAyK vgBytGb8IkVy37I9v4p50tLdy2/E6JH+iwiyOwjTLg2mI66M4UIH2tsO+GLj95bht8xz ZHDpMkqqE24mcNhC2CcvMqpKZPXTXX9OsjHDjtXpAh9JUtXNVV9FDovwYmBWa0wU4t/Q CPaTPA1+JsEmv9161Axsj/GrOdRLpp6EKlh8efxG9sMvkL+UL1XCtcy/mx/dPRfYaafM w2ggTWeyaPZ3/1TQpI4tpHYShj4TiGfBypKoy1ukKs5ZrAmaweopNWRoAbP5ZqKMiNhj 8oUQ== X-Gm-Message-State: AKaTC01lCUqoO4lFy5U58DAGW0/YK7lvSwBwpfrdJ29GgHTh1PJsZqo7JPmVmA/Ofh5pacsOBYA= X-Received: by 10.46.9.129 with SMTP id 123mr1517521ljj.20.1479394042318; Thu, 17 Nov 2016 06:47:22 -0800 (PST) Received: from erachmi-ericsson.ki.sw.ericsson.se (c-83-233-76-66.cust.bredband2.com. [83.233.76.66]) by smtp.gmail.com with ESMTPSA id h30sm860451lji.28.2016.11.17.06.47.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Nov 2016 06:47:21 -0800 (PST) From: Christophe Milard To: petri.savolainen@nokia.com, mike.holmes@linaro.org, bill.fischofer@linaro.org, lng-odp@lists.linaro.org Date: Thu, 17 Nov 2016 16:46:34 +0100 Message-Id: <1479397595-50258-13-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1479397595-50258-1-git-send-email-christophe.milard@linaro.org> References: <1479397595-50258-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Subject: [lng-odp] [API-NEXT PATCHv7 12/13] linux_gen: _ishm: decreasing the number of error messages when no huge pages X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c index 0586a96..782c32f 100644 --- a/platform/linux-generic/_ishm.c +++ b/platform/linux-generic/_ishm.c @@ -439,8 +439,12 @@ static int create_file(int block_index, huge_flag_t huge, uint64_t len, fd = open(filename, oflag, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); if (fd < 0) { - ODP_ERR("open failed for %s: %s.\n", - filename, strerror(errno)); + if (huge == HUGE) + ODP_DBG("open failed for %s: %s.\n", + filename, strerror(errno)); + else + ODP_ERR("open failed for %s: %s.\n", + filename, strerror(errno)); return -1; } @@ -762,6 +766,7 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, void *addr = NULL; /* mapping address */ int new_proc_entry; struct stat statbuf; + static int huge_error_printed; /* to avoid millions of error...*/ odp_spinlock_lock(&ishm_tbl->lock); @@ -836,11 +841,16 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, len = (size + (page_hp_size - 1)) & (-page_hp_size); addr = do_map(new_index, len, hp_align, flags, HUGE, &fd); - if (addr == NULL) - ODP_DBG("No huge pages, fall back to normal pages, " - "check: /proc/sys/vm/nr_hugepages.\n"); - else + if (addr == NULL) { + if (!huge_error_printed) { + ODP_ERR("No huge pages, fall back to normal " + "pages. " + "check: /proc/sys/vm/nr_hugepages.\n"); + huge_error_printed = 1; + } + } else { new_block->huge = HUGE; + } } /* Try normal pages if huge pages failed */