From patchwork Fri Nov 4 17:34:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balasubramanian Manoharan X-Patchwork-Id: 80904 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp93151qge; Fri, 4 Nov 2016 10:34:45 -0700 (PDT) X-Received: by 10.55.132.4 with SMTP id g4mr359478qkd.2.1478280885264; Fri, 04 Nov 2016 10:34:45 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id r83si8300324qki.320.2016.11.04.10.34.44; Fri, 04 Nov 2016 10:34:45 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8679960EA6; Fri, 4 Nov 2016 17:34:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 7B02360B49; Fri, 4 Nov 2016 17:34:40 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id E8DDD60C1A; Fri, 4 Nov 2016 17:34:37 +0000 (UTC) Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by lists.linaro.org (Postfix) with ESMTPS id B82E960A59 for ; Fri, 4 Nov 2016 17:34:36 +0000 (UTC) Received: by mail-pf0-f180.google.com with SMTP id i88so54897160pfk.2 for ; Fri, 04 Nov 2016 10:34:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oaejOP1aLIM72YW8PdZgo73SunWavPr3YIHQ5HliEgM=; b=Kb681KOamMP4kXHAVDF4WqyzYfV4lm58Pi5oS/KooKhIdwiFEw3FkwTsQCtyPJQyf0 RJ+oadP6var27QUvXfgYOPX8+cDF4637K/OEaAGn9dWix1uRFHmZ6GQ5XCiLSpWBRYUK SvnyR44RFs9tIZ2tSGumQyFU9vdwYdK/y9lRVBJLd7MpeW0YYBINj0jmrpeoa5Ck8pjU WeHZVAN4HlecJYpC1VPvPgJmpjl9VF5KRw8oPlJtZGrUzEGaDyi28R+Br7VDGIlUFTE4 AYBYuckhxvs8GL/rj0tVEJuRd+rYMNKoDBItKflJbqYRWwgRhTJwbGeRfyW5kruDwEZQ WN/g== X-Gm-Message-State: ABUngvczYsk6BNOJwS6Elx/NYyWQzd6mD4u94EOWHx0mlvscghqwgeeW5s8JpXC/WjbgjUomVSo= X-Received: by 10.98.90.135 with SMTP id o129mr28413168pfb.81.1478280875969; Fri, 04 Nov 2016 10:34:35 -0700 (PDT) Received: from bala-Vostro-2520.domain.name ([117.199.140.230]) by smtp.gmail.com with ESMTPSA id a7sm21780681pfl.87.2016.11.04.10.34.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Nov 2016 10:34:35 -0700 (PDT) From: Balasubramanian Manoharan To: lng-odp@lists.linaro.org Date: Fri, 4 Nov 2016 23:04:30 +0530 Message-Id: <1478280870-1669-1-git-send-email-bala.manoharan@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: Classification Subject: [lng-odp] [API-NEXTv2 1/1] api: pktio: adds further definition for classification configuration X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Updates classification configuration documentation. Signed-off-by: Balasubramanian Manoharan --- v2: Incorporates review comments include/odp/api/spec/packet_io.h | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) -- 1.9.1 Reviewed-by: Petri Savolainen diff --git a/include/odp/api/spec/packet_io.h b/include/odp/api/spec/packet_io.h index d46e405..6598d3e 100644 --- a/include/odp/api/spec/packet_io.h +++ b/include/odp/api/spec/packet_io.h @@ -189,12 +189,11 @@ typedef struct odp_pktin_queue_param_t { /** Number of input queues to be created * - * When classifier is enabled the number of queues may be zero - * (in odp_pktin_queue_config() step), otherwise at least one - * queue is required. More than one input queues require either flow - * hashing or classifier enabled. The maximum value is defined by - * pktio capability 'max_input_queues'. Queue type is defined by the - * input mode. The default value is 1. */ + * When classifier is enabled in odp_ipktin_queue_config() this + * value is ignored, otherwise at least one queue is required. + * More than one input queues require flow hashing configured. + * The maximum value is defined by pktio capability 'max_input_queues'. + * Queue type is defined by the input mode. The default value is 1. */ unsigned num_queues; /** Queue parameters @@ -202,7 +201,9 @@ typedef struct odp_pktin_queue_param_t { * These are used for input queue creation in ODP_PKTIN_MODE_QUEUE * or ODP_PKTIN_MODE_SCHED modes. Scheduler parameters are considered * only in ODP_PKTIN_MODE_SCHED mode. Default values are defined in - * odp_queue_param_t documentation. */ + * odp_queue_param_t documentation. + * when classifier is enabled in odp_pktin_queue_config() this + * value is ignored. */ odp_queue_param_t queue_param; } odp_pktin_queue_param_t; @@ -887,6 +888,8 @@ int odp_pktio_mac_addr(odp_pktio_t pktio, void *mac_addr, int size); * * @retval 0 on success * @retval <0 on failure + * + * @note The default_cos has to be unique per odp_pktio_t instance. */ int odp_pktio_default_cos_set(odp_pktio_t pktio, odp_cos_t default_cos);