From patchwork Wed Oct 26 12:47:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 79409 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp42727qge; Wed, 26 Oct 2016 05:47:15 -0700 (PDT) X-Received: by 10.237.55.131 with SMTP id j3mr1523115qtb.100.1477486035795; Wed, 26 Oct 2016 05:47:15 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 98si1231824qtc.118.2016.10.26.05.47.14; Wed, 26 Oct 2016 05:47:15 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id DA37C60EB0; Wed, 26 Oct 2016 12:47:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 5D4CD60B5E; Wed, 26 Oct 2016 12:47:11 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id B284660BD7; Wed, 26 Oct 2016 12:47:08 +0000 (UTC) Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by lists.linaro.org (Postfix) with ESMTPS id C879960B5E for ; Wed, 26 Oct 2016 12:47:06 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id n202so15064818oig.3 for ; Wed, 26 Oct 2016 05:47:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IxmAJlbNsVxAVoDN3A510S2qrG9LrQWV3PwrqF4Grv8=; b=LKXmgpRECxTgJslt1KeIU2V6Oxxk9LZUW39cZ/7TRyB/sZJwNVI3pHtG9gtxuun1kV F5Blf6AKPv02faUVPtnNYsUJUOLse1gtAy0GkGtNAS149S6vmUK+zXP8wM3GwzmP+4uP ZB11A6SZIZ7iM8fDfuG0nj4JsvWUfyCcYBk23A4HUlhtzS0eLZhzLNlRGfggosriK3B2 p2nsIT9ByXJiPDRHPMpQ7ZFfd3YVnmPZrfE+NHq95RZsOdnvZyqVa9ZZAEElmgeOkSrD yuhjwTXUcziYpEW4CvGWW4HbFiaj1T1W9jcdHj9deQ7D1p7q0YtvvQo0rAprwFT78H+Z 8+Bg== X-Gm-Message-State: ABUngvd8RPuUl++NTUJ0bO/i7XLQJKRexI5ce6QhQk55Dqvj7m+eBG7XKuZKhLpnZTT3Ou9AUOM= X-Received: by 10.202.173.3 with SMTP id w3mr984999oie.165.1477486026094; Wed, 26 Oct 2016 05:47:06 -0700 (PDT) Received: from localhost.localdomain (cpe-70-121-83-241.austin.res.rr.com. [70.121.83.241]) by smtp.gmail.com with ESMTPSA id i18sm576007oib.12.2016.10.26.05.47.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 26 Oct 2016 05:47:05 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Wed, 26 Oct 2016 07:47:04 -0500 Message-Id: <1477486024-8446-1-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.7.4 X-Topics: patch Subject: [lng-odp] [PATCH] linux-generic: packet: add fall through comments to parser X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Address bug https://bugs.linaro.org/show_bug.cgi?id=2565 by adding comments to the parser's switch statement to document the fact that fall through is intentional. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet.c | 7 +++++++ 1 file changed, 7 insertions(+) -- 2.7.4 Reviewed-by: Matias Elo diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-generic/odp_packet.c index 714794a..e43636b 100644 --- a/platform/linux-generic/odp_packet.c +++ b/platform/linux-generic/odp_packet.c @@ -1182,6 +1182,8 @@ int packet_parse_common(packet_parser_t *prs, const uint8_t *ptr, switch (prs->parsed_layers) { case LAYER_NONE: + /* Fall through */ + case LAYER_L2: { const _odp_ethhdr_t *eth; @@ -1254,6 +1256,8 @@ int packet_parse_common(packet_parser_t *prs, const uint8_t *ptr, if (layer == LAYER_L2) return prs->error_flags.all != 0; } + /* Fall through */ + case LAYER_L3: { offset = prs->l3_offset; @@ -1292,6 +1296,8 @@ int packet_parse_common(packet_parser_t *prs, const uint8_t *ptr, if (layer == LAYER_L3) return prs->error_flags.all != 0; } + /* Fall through */ + case LAYER_L4: { offset = prs->l4_offset; @@ -1341,6 +1347,7 @@ int packet_parse_common(packet_parser_t *prs, const uint8_t *ptr, prs->parsed_layers = LAYER_L4; break; } + case LAYER_ALL: break;