From patchwork Wed Oct 19 15:29:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 78292 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp313898qge; Wed, 19 Oct 2016 08:42:32 -0700 (PDT) X-Received: by 10.55.209.26 with SMTP id s26mr6318649qki.24.1476891752868; Wed, 19 Oct 2016 08:42:32 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id g67si24657703qkd.264.2016.10.19.08.42.32; Wed, 19 Oct 2016 08:42:32 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id E62756170B; Wed, 19 Oct 2016 15:42:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id BDDA96174B; Wed, 19 Oct 2016 15:31:39 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3F3A96173B; Wed, 19 Oct 2016 15:31:11 +0000 (UTC) Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) by lists.linaro.org (Postfix) with ESMTPS id 87585616E8 for ; Wed, 19 Oct 2016 15:30:15 +0000 (UTC) Received: by mail-lf0-f47.google.com with SMTP id l131so27812314lfl.2 for ; Wed, 19 Oct 2016 08:30:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dS9lFInNa79lWmse8CNet544bDJ/q5zoTPhb6nyX0nE=; b=SXb+k/gdCwz7HY0JGgI97LBFeKqLp+xzCue7zCx1nkqlGHXWwdNgM2/ue1h8gLgSJW QMG+lstosQPmuA7n8dpg5AWaS9BCwyMhh8o8Y13qAuy2ZR2c5khlxYiOcjfWtkCVWieK R1c/ucclb15+c7+vT5xFm5ofoQ/rOvIa/8oBuzruMuDVIBrlImmAHYSzqgo3ZEhiyegZ 8M4aQs292tzw4nboGpzhpvs/RcrbnPaGpeSfld3dWk2LzoKzieteqvy+wxkNhq2u99/j RDDXBcRigQ2HJpYds6fE8T9wXOJqosygxjqXgoJLEUvVqlK9IdZs3w+iiouIhW8BwynE wngg== X-Gm-Message-State: AA6/9RnAxkaov9WpqMPSKjp84llEI0ZXBdh1+o3/zr9sHDXo3Kz7NyDvVKI3wTpgmRZ6tuVuwEs= X-Received: by 10.25.41.205 with SMTP id p196mr3538027lfp.2.1476891012063; Wed, 19 Oct 2016 08:30:12 -0700 (PDT) Received: from localhost.localdomain (c-83-233-76-66.cust.bredband2.com. [83.233.76.66]) by smtp.gmail.com with ESMTPSA id w65sm10805536lff.16.2016.10.19.08.30.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Oct 2016 08:30:11 -0700 (PDT) From: Christophe Milard To: mike.holmes@linaro.org, bill.fischofer@linaro.org, lng-odp@lists.linaro.org Date: Wed, 19 Oct 2016 17:29:50 +0200 Message-Id: <1476890991-4693-16-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1476890991-4693-1-git-send-email-christophe.milard@linaro.org> References: <1476890991-4693-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Subject: [lng-odp] [API-NEXT PATCHv3 15/16] linux_gen: _ishm: decreasing the number of error messages when no huge pages X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c index 11bb316..0c08998 100644 --- a/platform/linux-generic/_ishm.c +++ b/platform/linux-generic/_ishm.c @@ -427,8 +427,12 @@ static int create_file(int block_index, huge_flag_t huge, fd = open(filename, oflag, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); if (fd < 0) { - ODP_ERR("open failed for %s: %s.\n", - filename, strerror(errno)); + if (huge == HUGE) + ODP_DBG("open failed for %s: %s.\n", + filename, strerror(errno)); + else + ODP_ERR("open failed for %s: %s.\n", + filename, strerror(errno)); return -1; } @@ -730,6 +734,7 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, void *addr = NULL; /* mapping address */ int new_proc_entry; struct stat statbuf; + static int huge_error_printed; /* to avoid millions of error...*/ odp_spinlock_lock(&ishm_tbl->lock); @@ -804,11 +809,16 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, len = (size + (page_hp_size - 1)) & (-page_hp_size); addr = do_map(new_index, len, hp_align, flags, HUGE, &fd); - if (addr == NULL) - ODP_DBG("No huge pages, fall back to normal pages, " - "check: /proc/sys/vm/nr_hugepages.\n"); - else + if (addr == NULL) { + if (!huge_error_printed) { + ODP_ERR("No huge pages, fall back to normal " + "pages. " + "check: /proc/sys/vm/nr_hugepages.\n"); + huge_error_printed = 1; + } + } else { new_block->huge = HUGE; + } } /* Try normal pages if huge pages failed */