From patchwork Wed Oct 12 18:42:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 77585 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp571421qge; Wed, 12 Oct 2016 11:42:42 -0700 (PDT) X-Received: by 10.55.40.40 with SMTP id o40mr2425216qkh.73.1476297762075; Wed, 12 Oct 2016 11:42:42 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id n84si4521413qki.73.2016.10.12.11.42.40; Wed, 12 Oct 2016 11:42:42 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 9205A60509; Wed, 12 Oct 2016 18:42:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A27D861658; Wed, 12 Oct 2016 18:42:35 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 6168F616D9; Wed, 12 Oct 2016 18:42:33 +0000 (UTC) Received: from mail-qk0-f180.google.com (mail-qk0-f180.google.com [209.85.220.180]) by lists.linaro.org (Postfix) with ESMTPS id 929ED60B14 for ; Wed, 12 Oct 2016 18:42:32 +0000 (UTC) Received: by mail-qk0-f180.google.com with SMTP id f128so45648615qkb.1 for ; Wed, 12 Oct 2016 11:42:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jhwnC1ItQW7hEF0JPKGRdyXi3gCmi7HlYiibOd8r4Nc=; b=dURRaOkWiQ1MpMxU9443e0kJGGALd8npmI0bFiWdf80+RMzPFDqewRRgnBuu3bSORp eEH7sAHlzvYe2gcu/ssiEVMCgulA67cs15Hnkg0S/w2uuBA1nBtSJTWB5PmNTsdj5EP0 DlcqDV0Kx+sL0LLP1TAR6rIeSZGLIKqpSNJPOFjHnUaITloyIVQcWUTeSg6R3aTRDY8r 2nBqczzDZwTamVLyOkJwJfQALbDCNIRfRRpKlk8cNAtx3a1SylYCCw8wbBknErySQ11D cpnLmr2CWJ9jUEduFRaZVhO9/8rYjWnSRRLHLJH0d13rdW769T9kPXr1wKlggZOB997Y Dl+Q== X-Gm-Message-State: AA6/9Rkc1p50Q29ceQjO4gWywEuc+uOK4TIxSocDKXvDV5UK0JiV/bM+phK9lpndjyHgncMLIPI= X-Received: by 10.55.35.201 with SMTP id j192mr2548396qkj.190.1476297752281; Wed, 12 Oct 2016 11:42:32 -0700 (PDT) Received: from localhost (c-98-221-136-245.hsd1.nj.comcast.net. [98.221.136.245]) by smtp.gmail.com with ESMTPSA id l8sm3253504qtl.18.2016.10.12.11.42.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Oct 2016 11:42:31 -0700 (PDT) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Wed, 12 Oct 2016 14:42:29 -0400 Message-Id: <1476297749-17029-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.7.4 X-Topics: patch Subject: [lng-odp] [PATCH] example: generator: actually use specified default X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" The help states default is 1000ms. 0 for flood mode, however the default was incorrectly set to zero. Fix odp_l2fwd to specify the timeout it requires to flood mode Signed-off-by: Mike Holmes --- example/generator/odp_generator.c | 1 + test/common_plat/performance/odp_l2fwd_run.sh | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index b0053b9..48d7f5f 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -946,6 +946,7 @@ static void parse_args(int argc, char *argv[], appl_args_t *appl_args) appl_args->number = -1; appl_args->payload = 56; appl_args->timeout = -1; + appl_args->interval = DEFAULT_PKT_INTERVAL; opterr = 0; /* do not issue errors on helper options */ diff --git a/test/common_plat/performance/odp_l2fwd_run.sh b/test/common_plat/performance/odp_l2fwd_run.sh index e64aa47..757cf53 100755 --- a/test/common_plat/performance/odp_l2fwd_run.sh +++ b/test/common_plat/performance/odp_l2fwd_run.sh @@ -32,6 +32,8 @@ TEST_SKIPPED=77 PLATFORM_VALIDATION=${TEST_SRC_DIR}/../../$ODP_PLATFORM/validation +FLOOD_MODE=0 + # Use installed pktio env or for make check take it from platform directory if [ -f "./pktio_env" ]; then . ./pktio_env @@ -66,7 +68,7 @@ run_l2fwd() #@todo: limit odp_generator to cores #https://bugs.linaro.org/show_bug.cgi?id=1398 - (odp_generator${EXEEXT} -I $IF0 \ + (odp_generator${EXEEXT} --interval $FLOOD_MODE -I $IF0 \ --srcip 192.168.0.1 --dstip 192.168.0.2 \ -m u 2>&1 > /dev/null) \ 2>&1 > /dev/null &