From patchwork Fri Sep 9 14:19:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balasubramanian Manoharan X-Patchwork-Id: 75900 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp372361qgf; Fri, 9 Sep 2016 07:19:39 -0700 (PDT) X-Received: by 10.55.132.68 with SMTP id g65mr4096262qkd.8.1473430778002; Fri, 09 Sep 2016 07:19:38 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id v8si2181039qkv.36.2016.09.09.07.19.33; Fri, 09 Sep 2016 07:19:37 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 9BBA060DF0; Fri, 9 Sep 2016 14:19:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 2EF7D60D96; Fri, 9 Sep 2016 14:19:30 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id DF20960DD9; Fri, 9 Sep 2016 14:19:27 +0000 (UTC) Received: from mail-pa0-f47.google.com (mail-pa0-f47.google.com [209.85.220.47]) by lists.linaro.org (Postfix) with ESMTPS id CE54660D92 for ; Fri, 9 Sep 2016 14:19:25 +0000 (UTC) Received: by mail-pa0-f47.google.com with SMTP id cm16so28937896pac.0 for ; Fri, 09 Sep 2016 07:19:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ArsmuslmYlJS1gENRu3Z29YGScB2zLmWi0Zt9p0+7FM=; b=H+xRu8RRQUj5D6amGkeuXzRE6mD2JD2fmYU/imthiFgz7M2RZQLWMBcVAhddjl4ZW0 T79qtggSffFjoZLBuu2hh6eFJtrcuMivm1FCDPEZWVwhlse+vW7M5DjadT2YothTWsGk xduKs4fPCe63dXG6yI3R4CGb1kWG+BH2zhvPUWvcXdKZsSpkINsow82xK3zf1FoDMv66 qYoe+cDzThvMKPsOD7TemQXRBH5b5uEQHfkCN8zFqILVgBMIgAzfrJeRnRAVFMeJ9GlF odWRBGZG9QE8mjMIogppoWfFw+myL/lrxcnSCp0bl5JgSsBHqq11PbNg0g7OjK3hy3QK vDew== X-Gm-Message-State: AE9vXwMTL32KahVM8AOimUNEVM2lWKBM5J6waswcrZYO2bpQv9UkKvf2yYEytbhfw6Pu+tAWgR0= X-Received: by 10.66.127.38 with SMTP id nd6mr7060767pab.74.1473430764937; Fri, 09 Sep 2016 07:19:24 -0700 (PDT) Received: from localhost.localdomain ([122.166.219.57]) by smtp.gmail.com with ESMTPSA id a198sm5857232pfa.27.2016.09.09.07.19.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Sep 2016 07:19:24 -0700 (PDT) From: Balasubramanian Manoharan To: lng-odp@lists.linaro.org Date: Fri, 9 Sep 2016 19:49:09 +0530 Message-Id: <1473430749-19279-1-git-send-email-bala.manoharan@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: Classification patch Subject: [lng-odp] [PATCH 1/1] validation: classification: fix TCP/UDP checksum update X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Fixes https://bugs.linaro.org/show_bug.cgi?id=2512 Signed-off-by: Balasubramanian Manoharan --- .../validation/api/classification/odp_classification_common.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) -- 1.9.1 diff --git a/test/common_plat/validation/api/classification/odp_classification_common.c b/test/common_plat/validation/api/classification/odp_classification_common.c index 7a42ac7..93ac0c0 100644 --- a/test/common_plat/validation/api/classification/odp_classification_common.c +++ b/test/common_plat/validation/api/classification/odp_classification_common.c @@ -11,6 +11,7 @@ #include #include #include +#include "test_debug.h" typedef struct cls_test_packet { odp_u32be_t magic; @@ -291,6 +292,8 @@ odp_packet_t create_packet_len(odp_pool_t pool, bool vlan, parse_ipv4_string(CLS_DEFAULT_SADDR, &addr, &mask); ip->src_addr = odp_cpu_to_be_32(addr); ip->ver_ihl = ODPH_IPV4 << 4 | ODPH_IPV4HDR_IHL_MIN; + odp_packet_has_ipv4_set(pkt, 1); + if (flag_udp) ip->tot_len = odp_cpu_to_be_16(ODPH_UDPHDR_LEN + payload_len + ODPH_IPV4HDR_LEN); @@ -318,14 +321,19 @@ odp_packet_t create_packet_len(odp_pool_t pool, bool vlan, udp->dst_port = odp_cpu_to_be_16(CLS_DEFAULT_DPORT); udp->length = odp_cpu_to_be_16(payload_len + ODPH_UDPHDR_LEN); udp->chksum = 0; + odp_packet_has_udp_set(pkt, 1); + if (odph_udp_tcp_chksum(pkt, ODPH_CHKSUM_GENERATE, NULL) != 0) + LOG_ERR("odph_udp_tcp_chksum failed\n"); } else { odp_packet_l4_offset_set(pkt, offset); tcp = (odph_tcphdr_t *)odp_packet_l4_ptr(pkt, NULL); tcp->src_port = odp_cpu_to_be_16(CLS_DEFAULT_SPORT); tcp->dst_port = odp_cpu_to_be_16(CLS_DEFAULT_DPORT); tcp->hl = ODPH_TCPHDR_LEN / 4; - /* TODO: checksum field has to be updated */ tcp->cksm = 0; + odp_packet_has_tcp_set(pkt, 1); + if (odph_udp_tcp_chksum(pkt, ODPH_CHKSUM_GENERATE, NULL) != 0) + LOG_ERR("odph_udp_tcp_chksum failed\n"); } /* set pkt sequence number */