From patchwork Thu Sep 8 15:53:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 75806 Delivered-To: patch@linaro.org Received: by 10.140.106.11 with SMTP id d11csp921664qgf; Thu, 8 Sep 2016 08:54:23 -0700 (PDT) X-Received: by 10.202.219.137 with SMTP id s131mr411525oig.109.1473350063627; Thu, 08 Sep 2016 08:54:23 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id i5si16235857otb.171.2016.09.08.08.54.20; Thu, 08 Sep 2016 08:54:23 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 176D260E74; Thu, 8 Sep 2016 15:54:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 8C24260979; Thu, 8 Sep 2016 15:54:16 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D6FE560E58; Thu, 8 Sep 2016 15:53:55 +0000 (UTC) Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com [209.85.215.43]) by lists.linaro.org (Postfix) with ESMTPS id 630D860979 for ; Thu, 8 Sep 2016 15:53:13 +0000 (UTC) Received: by mail-lf0-f43.google.com with SMTP id l131so24710937lfl.2 for ; Thu, 08 Sep 2016 08:53:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=No/FKXXocXN3I9o6roKaRofIOPfCl9UfJyz1oozIzIE=; b=O+2ThdtT2Il5bbf1I4/K1ZA0jT1o+E1MBPnJdOfmPQ6Q/UpF5OQt5FWxcECFCZjLyT tn4/Udu/Pk327YqNrbAoIDeJ2914MyZu4cbea17DXfecb1Dp6PeSOoCwkAMi54vRpQKJ 38xCqCGyqj3ZVxLijxad6TKcAsptacvyOQ1FfVeEvPqYmOwhTDlylfk5JOSBRobz5oDK AuS2k++LPDUmT/sh12kd+NrO+6nSkkfKE+EfKBQvUAv+aRC0qSjUXnBunSPTVK+buI0D uU0OXIpiYQDiCWmy7FdGruIQf6ryZ9mSjjPUpZURg5v7BdSvwkePu3lptx2PJfwFdRwH 5mvg== X-Gm-Message-State: AE9vXwMw4A9zB7VF2DoBAlOxNFDDMPF8Ev7v5MkVgUIwuIjpBaVqVanmNlEMG0sdJ+6ycjY/J4E= X-Received: by 10.46.9.84 with SMTP id 81mr130861ljj.62.1473349992080; Thu, 08 Sep 2016 08:53:12 -0700 (PDT) Received: from localhost.localdomain ([83.220.237.147]) by smtp.gmail.com with ESMTPSA id g201sm1491994lfg.8.2016.09.08.08.53.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 08 Sep 2016 08:53:11 -0700 (PDT) From: Maxim Uvarov To: lng-odp@lists.linaro.org Date: Thu, 8 Sep 2016 18:53:00 +0300 Message-Id: <1473349980-6480-1-git-send-email-maxim.uvarov@linaro.org> X-Mailer: git-send-email 2.7.1.250.gff4ea60 X-Topics: patch Subject: [lng-odp] [PATCH] linux-gen: pktio: ipc: remove todos X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Remove todo around copying packet data from shared pool as it's not a bug and can be considered as future request. But left small comment that we coping packet data to make it more visible. https://bugs.linaro.org/show_bug.cgi?id=2408 Signed-off-by: Maxim Uvarov --- platform/linux-generic/pktio/ipc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.7.1.250.gff4ea60 Reviewed-by: Mike Holmes diff --git a/platform/linux-generic/pktio/ipc.c b/platform/linux-generic/pktio/ipc.c index b779ab7..c1f28db 100644 --- a/platform/linux-generic/pktio/ipc.c +++ b/platform/linux-generic/pktio/ipc.c @@ -373,11 +373,6 @@ static int _ipc_slave_start(pktio_entry_t *pktio_entry) pinfo->master.mdata_offset; pktio_entry->s.ipc.pkt_size = pinfo->master.shm_pkt_size; - /* @todo: to simplify in odp-linux implementation we create pool for - * packets from IPC queue. On receive implementation copies packets to - * that pool. Later we can try to reuse original pool without packets - * copying. (pkt refcounts needs to be implemented). - */ _ipc_export_pool(pinfo, pktio_entry->s.ipc.pool); odp_atomic_store_u32(&pktio_entry->s.ipc.ready, 1); @@ -573,7 +568,7 @@ static int ipc_pktio_recv_lockless(pktio_entry_t *pktio_entry, (PKTIO_TYPE_IPC_SLAVE == pktio_entry->s.ipc.type)); - /* @todo fix copy packet!!! */ + /* Copy packet data from shared pool to local pool. */ memcpy(pkt_data, remote_pkt_data, phdr.frame_len); /* Copy packets L2, L3 parsed offsets and size */