From patchwork Fri Jul 29 14:38:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikhil Agarwal X-Patchwork-Id: 73027 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp1279842qga; Fri, 29 Jul 2016 02:10:31 -0700 (PDT) X-Received: by 10.55.70.22 with SMTP id t22mr47083803qka.171.1469783431750; Fri, 29 Jul 2016 02:10:31 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id c68si11511719qkb.126.2016.07.29.02.10.31; Fri, 29 Jul 2016 02:10:31 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0F68E684B7; Fri, 29 Jul 2016 09:10:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, DATE_IN_FUTURE_03_06, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id D575068432; Fri, 29 Jul 2016 09:10:26 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7214B68447; Fri, 29 Jul 2016 09:10:24 +0000 (UTC) Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0044.outbound.protection.outlook.com [104.47.34.44]) by lists.linaro.org (Postfix) with ESMTPS id 5B39168427 for ; Fri, 29 Jul 2016 09:10:22 +0000 (UTC) Received: from BLUPR0301CA0038.namprd03.prod.outlook.com (10.162.113.176) by BN6PR03MB2484.namprd03.prod.outlook.com (10.168.223.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Fri, 29 Jul 2016 09:10:19 +0000 Received: from BY2FFO11FD056.protection.gbl (2a01:111:f400:7c0c::134) by BLUPR0301CA0038.outlook.office365.com (2a01:111:e400:5259::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Fri, 29 Jul 2016 09:10:19 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning linaro.org discourages use of 192.88.158.2 as permitted sender) Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD056.mail.protection.outlook.com (10.1.15.193) with Microsoft SMTP Server (TLS) id 15.1.539.16 via Frontend Transport; Fri, 29 Jul 2016 09:10:19 +0000 Received: from netperf2.ap.freescale.net ([10.232.133.164]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u6T9AHT0003050 for ; Fri, 29 Jul 2016 02:10:18 -0700 From: Nikhil Agarwal To: Date: Fri, 29 Jul 2016 20:08:57 +0530 Message-ID: <1469803138-25622-1-git-send-email-nikhil.agarwal@linaro.org> X-Mailer: git-send-email 2.8.2 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131142570198813525; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(189002)(199003)(5003940100001)(450100001)(68736007)(2351001)(86362001)(8936002)(47776003)(81166006)(50226002)(107886002)(87936001)(48376002)(229853001)(110136002)(36756003)(50466002)(356003)(104016004)(8676002)(33646002)(6806005)(106466001)(97736004)(189998001)(19580405001)(11100500001)(305945005)(7846002)(15975445007)(92566002)(105596002)(81156014)(50986999)(19580395003)(69596002)(2906002)(77096005)(586003); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2484; H:az84smr01.freescale.net; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD056; 1:QsGGuiUDc4P8NDWDgb7t2N9k3JEd3hHeTHO98kELMSdmKs3RaAb9chxGYsbIMkLt+4bTt9J4BPTJpJ0ECExzXLBUh4wZvU34ziAFbxtxebTVgPylOPXqLfC2ssoasi8/Ca6dRuRAWuGrrks72Ok6GVI/3hMYlAo26/pIohchOmOhABoBCZs2mZNrHKAU6l+uDoHo4EkLg0SPnSRP8Ry5P2n1iAiVsA2yvUGGNc/m4DUi7ivF0QVSjh3TbkkyBSE6r9LA/Ne5w/8jVJ741rr8eRUrcwcGiyizvrRrAr3eiOW6d2syqwl0+7Jo/T7AiW64OYkIz58MqGddDjHWZOgVFhUISGuQ5oz+RhPa2zKW64fnSVAMEhtBsS+y2+CvYpFBH12xoIovpduevldYUXM/DaSCaLJVGdFxc8MmYtSrzxM7qJ4fYo/VVaWRsp8+hcb/zCNhby60zP9OFye7sVcBEJz25ZISwVByRAgFjnHlIE7bFQuHUu7TlPeGazq7YAGZixKRtBIzhcFZdkK7hkp075pJZqy/mFuPxM2y0c50jiUjwaqZ+zDB3QZLWOpopSgG MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e6da738a-7269-4215-69f6-08d3b7902a16 X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2484; 2:gk+FrMq4oG2umnHJf1UKapFSKtCA1ES9sQ0WD8OvnYHrcNs3Rsdc4pB2jLxFwx7U/PoWD09bVz7Ck1c9A2NCJOv2imCiMZHy+nBfqvnKYl/AWt0uHwWhaUug9kbbJHUypKCQS0aAh7+evS+a4xMeEcKuV9t73sxYtGtMUlHgetBp+BPg7l+wn3Lx3Cpvk8DQ; 3:gPqBkJ+ZY9fLPoJq1y5WpesPg7c2QrPLesBXR209bNB2+0slfYVDkRtDWkcupRSiTcJBVdUcL/sAcbS48DUpooPeuZbVjrGi9VHOiLPnQNsgDOUpyrNUoK9YI110K7tzXoOL7e3Bgu/N7e61XJVD4wvBf2NJPg/HXXa914txFyNwa4Uf6I5Fh3kFBLB+KM1yrdsMq3yBaQ43s0BiDPEO54tgkqGnW1z+EppcWBr9vyE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN6PR03MB2484; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2484; 25:4KexS+hAZmyjDsumOX1FEaQ1WjsxWoYT5cHlnFVEd5dEaZFDx+Z8py+qQZgcOJUGwcwOKcSeriAY1n7dyd5mOz53yFboTIbpRxGj+HPIhbube8NODxlX5IbZ8hYv/vKLp/9MpIvAktQADHAvkYVv40REGxZAQJ/LtbCiUVGAO2p2oDccKNDLWEr+Y/KdD3HhD7JCaK3xgNv3kHluNPGe4IgWWCzUoOSkOKdKbBmwi08N6v4mJhXtNMTEEEjZIRObNGNg2hDVb+f/jp78e7//A6Zz6XbxLjRtFdM3wRC+VnvbTBimijCvrqELN7kmSNSIJUkH7UZ0nrfWZfDpTq46r+kgpIQ8TbGxcKUEkfuCmc7bCK088mZraQRNOvSGYALaL1XCFPCKt+J/D2RLNfPdw+RBQcfEM8i2xo7qOubRGxpkPu2LqqDUr1SK/vzFMrMLatFt35MKyBXaBDy8aAwGq6pQH82yVHwNXDmys5+Z78Ff7G5CKiFxKZ4CUWF6ahaP+6BYGXmMWbFbpFrPsIwQ5fgTMYVHL7oIKjRJCXg5ZVLKK60/BRrSzrnIpWHqZ10GVptc1kEZyTTJbkp4RMaImtk1KBrWuiOvbpAwURWXJ8ZmbLqeIbI5kP+IjCl9PZmcWZvMJ+V1I3mXDq3/tPN7lpmBoUOaXfp1GVypqIRkcAiETg4kTeRbhJVm8RS27bjK1nEDzLB9vw06a5ju4e0/Ff5GPdC8vd3HF6zkPSzVZp8M+IXF6pIr/s7XC8NqtZdpjVJSwHBJMMTaIRmkZhj6vONVvzF07/tybEkXV0iWkjH/2UAqKdzyw20HahfgEAUwuQRmX5r4mpdYSyrD1lfR+Q== X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2484; 31:9RheDv3gnRT2Fs41KojYt+NsAeXq0c8YMkX+VZpf/txNdeNlhlUd57NhN+Z3gNQh+GOU9ij+2vkQzTCEZU0v2hNrSmCAmR0LJCThmwPeCJ44kbOwh9n561Y9nweo1p56Lt5KchYwbXp1FtnJ5IZgvRxwnTXD8yk0lvcZloTgx1Gft8ofx8VOOWHtOamrCWTNw8swOV7FiPhBETmrNYy9UQ==; 4:gHA8SwG9SRl0RqZi45wLhB80WNSozONmQiQw1w1kKCO1duuQjpA+gI49MDzZtVgvTtAIaWK0I8SfM/KCQaqiuQ8iuw0890AzUSil/nSXR7zqjHp+FAndsSInLgZVlO0J1IKmjrw+LAxkxeqYc9/BNHGYWjbItCtlKYgnHt/VvoFTw6tyZjAlLsYzEC0gH9NymEALpBN8cXdQ7X0szmX0N2ibgm/sjigNyNa1lzcDzJrLUgpDYTFZCnlF+wbkcZ8zx02VMe8iWELh6J3MyDfRK5K3Dr4TN6khvgmfALzRYXIqiUnk28BHz49LiKKW7j1BvhR5kfqS4jXHPjIzTZEZ45XUaH+6ltFHKFfp2U0r0wQo0mOWLJpfmlif/dBwroVmZcxc+rMjJsmOIOdGji7lAD/ThENKokYQYHXtYDvi7OLjdA78lyzq4cAhPheOq51RInLugFU17QOAV2tMpXwYcZ0VAtMEl9CDUjRbbSJGDQQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(13017025)(13018025)(13023025)(13024025)(13015025)(3002001)(10201501046)(6055026); SRVR:BN6PR03MB2484; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2484; X-Forefront-PRVS: 0018A2705B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR03MB2484; 23:kMdI9MI480AB4rbbMVOG6Q03PWaxaANHRzquEgJwE?= =?us-ascii?Q?EBjV4L1QwM6s+mlG+75ql1NGfIS7agT7V3rhZZsOqFHFYi+JMO+bJRW805Hg?= =?us-ascii?Q?impXdDTVXjXK9ZrXSYwg8oKPimeVRpBpnX8vOpVQXtn/pgByApnC76YiHk/u?= =?us-ascii?Q?D9HD2HynlzhzVYZvljxJX5C1VvwHsfwPmSwiU/RnWrhnGZP/6msMd71xIsj0?= =?us-ascii?Q?+n8hzJw2XCf7eBLx1FJIo85thHgmoSqEo6Rjp3WakcAt3KTvRW4OXVy66Yuj?= =?us-ascii?Q?0+D9a6TnVkagNF6cKqX3NItCwic0x6OMqxxSPThIxnadUwhtCODpwJSZDVFT?= =?us-ascii?Q?QUeKKHU/v+LsSja1Q8azMheWe0/nEl9EEY00FzTDOkita7P2Wts070nQiyKv?= =?us-ascii?Q?eMorzfHZgM2NCB+LISU5kK0Rq6qCxa8pv8EVNLh5sKNHWTttdoiEDyBZaqhb?= =?us-ascii?Q?xBGn9X9cQqx5sqUymKFTvGytS/7LdHz0J1XkZAiHoa3rdKvly5kEnCNsRwUs?= =?us-ascii?Q?7AhMrqY4upcvwlIdCqw6eg7xwD2phnFw4WbKkRcQMzl4J7ApiQrYClSBXxu4?= =?us-ascii?Q?mXSYpf/4/0CydfWd9m2h3pnqGnMBFgwcU/5osgDT9N6EDemjl1yq2Bk2D9Tj?= =?us-ascii?Q?EgyIy06pYeq0eJAgXQMJLIdTpMwI9eksB36hdZ/VhQqkAaclKEFiavoD3lKC?= =?us-ascii?Q?P6o6UEH4V73ctgtEbLAyUu2PFfHstDTOX6OXwT0NDx1HfD6P6W1r3lXSsF8I?= =?us-ascii?Q?+Tb1NKyn5qeDreSKgJh5RWHQ1+1n+Nz5tOGPL0EVcljpFn5HRZXNW9dAX24t?= =?us-ascii?Q?Laq8ouODdT0ZwK7TfiY4sfJVVqjWUdSqnL8Btvrdq3JYoNmOg1l/EXUDeBZE?= =?us-ascii?Q?vRHbnxqnQ2D/mc1ziB7drHRfD2U75kJ5QS5njhQaT0jNXNSK8M8T8rAipzoy?= =?us-ascii?Q?DfXv/qxyFaI5inLxvgFgbjcebDEveXK7N1oEAeqhWZeG/P/EWHrSL+gsosxq?= =?us-ascii?Q?JmG1oxbclacdg4oQXghfs/cF5YEycBQkZin2lr7rRkYyZibC4/7Qa/CyWNR7?= =?us-ascii?Q?wPU4xo=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2484; 6:/7jl9P6ZCtzWe9YCrdr7epaoa6JLf0b2wAaWJv36GrjmTtrRm7WnYKYLGPCtcFug9ifGxJRNB8nPamz/x3esKv/LBNHGRtmT8eP6BIYSjXwCifLKOhGBLVXG/uDz8wd+Id5z1X+RwcfhQaLjuJGI8RxXxP1fLvDDfdAcksleYJLDdwo6iSJOL6HUOPmVwhEANtoT2o3o28B93qfq2y4GVKEiWx0DD41lxsxzjEqv3uJM8qQpYFZj2x3opMalGDOc57pDdCyrLp4s+l2+qPj+127XXvxi++6lalUfJ+g5uVY=; 5:oq/rpbbG19yug9JDgoob0mpqSn9KnSzO5LEv4AwpUamugSvEuau8V95kk2IVZUhtsvzhFh9PH0m4LgJ208T2YQ08mss7X7V2lt4jORr6ve9mCYrmPyI6PYZDPwqKUR2c8Dx2zaLyO1lqj3U+9opgpmr6K9rqzbgQJk4dZF9IYrM=; 24:3FXQP/HJf7EGeuU6Or8aVLS8kSPRe05gJPIdeQRzMj+oqm8/hYf9w+kp/LeW78IAfudpsVTamiseBhSJDacM6wMQiZr9Xqktv1uttoHXwW0=; 7:I9Cah55+/51QBeB0Nw9c3SBowejr9nSUJeVI21CSjPTMN4UeM6sY1zBVRkP6G4Vzfdd/mcXDBLrFMs919HE32uoyEUwx8lYRrFA/r08phpvWeh8nyqEaRid3HDNg4rQJY6kwYutbqHIEpRL+/PhxyprPvW9IY34dgtYO5Zj9FDiPEUARkR6w5iPF6muo6RJRhb5rfhQQ41iuybOWaTb9D+S77hqtFSiUIhTwOA6csVL+cJ6CdzsFpBPTZnXOorrm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2016 09:10:19.7565 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2484 X-Topics: patch Subject: [lng-odp] [PATCH 1/2] example:ipsec: removed invalid todos. X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" This todo item is no longer valid. Fixed as a part of following work card. https://cards.linaro.org/browse/LNG-857 Signed-off-by: Nikhil Agarwal --- example/ipsec/odp_ipsec_stream.h | 4 ---- 1 file changed, 4 deletions(-) -- 2.8.2 Reviewed-by: Bill Fischofer diff --git a/example/ipsec/odp_ipsec_stream.h b/example/ipsec/odp_ipsec_stream.h index ea480c3..6f6f7df 100644 --- a/example/ipsec/odp_ipsec_stream.h +++ b/example/ipsec/odp_ipsec_stream.h @@ -93,10 +93,6 @@ odp_packet_t create_ipv4_packet(stream_db_entry_t *stream, /** * Verify an IPv4 packet received on a loop output queue * - * @todo Better error checking, add counters, add tracing, - * remove magic numbers, add order verification - * (see https://bugs.linaro.org/show_bug.cgi?id=620) - * * @param stream Stream to verify the packet against * @param pkt Packet to verify *