From patchwork Wed Jun 29 00:50:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 71160 Delivered-To: patch@linaro.org Received: by 10.140.28.4 with SMTP id 4csp1876283qgy; Tue, 28 Jun 2016 17:51:11 -0700 (PDT) X-Received: by 10.200.44.136 with SMTP id 8mr8082045qtw.18.1467161471779; Tue, 28 Jun 2016 17:51:11 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id c126si863873qkf.208.2016.06.28.17.51.11; Tue, 28 Jun 2016 17:51:11 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 03D696815A; Wed, 29 Jun 2016 00:51:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 85EC668148; Wed, 29 Jun 2016 00:51:03 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id DCA3D6814A; Wed, 29 Jun 2016 00:51:01 +0000 (UTC) Received: from mail-ob0-f175.google.com (mail-ob0-f175.google.com [209.85.214.175]) by lists.linaro.org (Postfix) with ESMTPS id 4B41F6808D for ; Wed, 29 Jun 2016 00:51:00 +0000 (UTC) Received: by mail-ob0-f175.google.com with SMTP id c3so4537547obc.2 for ; Tue, 28 Jun 2016 17:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=51i9I3yQPvsTPl5u51AR1+/GH2Q3oKmlEei4zvzld/8=; b=CNh5YZjKuuBezpGMbJYSmgWGwkBoaJCucvtNrKJB4i7DeUwCGl6gsQaLLfLGQd+R/r 7z0udSDOL88kVI2jWDbr0A5o+2hoLAn7LxrTueczoeqdk5uyYxkPt/2Wx9SxlGKvmgzg BZ+1ljTooNzgkn6hJQtScG6NkFyUHzAgD3Br5WCF8mp1U7YJcXuJKC16Iw3JQCqo6EE9 zOnmJYdz5u6TkXt7Zykvt+zzOHrtxIdpueufaCq4qbqn5BreIFG3tDMQ2mndP/T8Wllj PMjg+Wkz1wPdep3rFCPFLVcqXygHqa1lDQxeHVo6Teuq5G95v3nZGP37Htpv8nUm8aEa lnFA== X-Gm-Message-State: ALyK8tJX+crcCLuHY7M17JprvaEwozozIqCmV94/4XdcjiTNRxlFyit7pvWRHfjR8KvXU2gnkyg= X-Received: by 10.202.66.214 with SMTP id p205mr3841981oia.43.1467161459548; Tue, 28 Jun 2016 17:50:59 -0700 (PDT) Received: from localhost.localdomain (cpe-66-68-129-43.austin.res.rr.com. [66.68.129.43]) by smtp.gmail.com with ESMTPSA id s132sm471844oia.2.2016.06.28.17.50.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Jun 2016 17:50:58 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Tue, 28 Jun 2016 19:50:56 -0500 Message-Id: <1467161456-23229-1-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.7.4 X-Topics: patch Subject: [lng-odp] [PATCHv3] contributing: add user agreement and short log conventions X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Signed-off-by: Bill Fischofer Reviewed-by: Mike Holmes --- v3: Spelling corrections + changes suggested by Christophe v2: Incorporate comments from Mike and Petri CONTRIBUTING | 162 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 154 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTING b/CONTRIBUTING index a81fd8d..a49a34c 100644 --- a/CONTRIBUTING +++ b/CONTRIBUTING @@ -11,15 +11,30 @@ in understanding the contributing requirements for ODP This document is intended to guide a new application developer in understanding the contributing requirements for ODP +== Contributor's Agreement +ODP is an open source project that follows the +https://opensource.org/licenses/BSD-3-Clause[BSD 3 Clause] license. Every +contributor to ODP must agree to comply by these licensing terms as well as +assert that they have the right to contribute the code they submit to the +project. No patches will be considered for acceptance without the contributor +having first executed either an +http://www.opendataplane.org/contributor/individual/[Individual Contributor +License Agreement] or being a member of an organization that has executed +a http://www.opendataplane.org/contributor/corporate/[Corporate Contributor +License Agreement]. + +These agreements are a one-time requirement and take only a few minutes to +perform by click-through. + == New Development ODP code shall be written with the kernel coding style https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/CodingStyle[Kernel Coding Style] ODP code shall be documented using the doxygen style described in the -"Documenting the code" section. +<> section. Check patch script/checkpatch.pl shall be used before submitting a patch. -== ODP patch expectations as an open source project +== ODP patch expectations as an open source project While specific to the Linux kernel development, the following reference could also be considered a general guide for any Open Source development @@ -42,14 +57,145 @@ which can be found in https://git.kernel.org/cgit/linux/kernel/git/torvalds/linu Code without a proper signoff cannot be merged into the mainline. +== Short Log and Long Log Conventions +For ease of patch management, every submitted patch must have a short log +entry. The short log is a one-line summary of the patch and says where it +is intended to be applied and (briefly) its purpose. Following the short +log, submitters are free to add additional detail in the long log. Long log +entries are encouraged when appropriate. These should be relevant and +useful to potential reviewers in understanding the purpose and rationale +for the patch. See the above-referenced +https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches[Submitting Patches] for some useful suggestions and +guidelines. + +=== Short log format +ODP requires that the short log be a single line not exceeding 80 characters, +be composed entirely in lower case, and be structured as follows: + +`area: component: brief description` + +Note that a single colon (:) should be used to separate each section of the +short log and be followed by a single space before beginning the next section. + +Area identifies the functional area that this patch addresses and in general +says where in the directory hierarchy the patch is intended to apply. This +should be taken from the following list: + +api:: +Patch adds, deletes, or changes an ODP API. Any patch that applies to the +`include/odp/api` directory or its descendants is considered an API patch and +must be identified as such. Moreover, any patch series containing an api patch +must be identified in the patch's `--subject-prefix` as API-NEXT. + +doc:: +Patch applies to the ODP documentation library contained in the `doc` directory + +drv:: +Patch adds, deletes, or changes an ODP Driver specification. Any patch that +applies to the `include/odp/drv` directory or its descendants is considered a +DRV patch and must be identified as such. + +example:: +Patch applies to the ODP examples contained in the `example` directory. + +helper:: +Patch applies to the ODP helper library contained in the `helper` directory. + +linux-generic:: +linux-gen:: +Patch applies to the odp-linux reference implementation, specifically the +`platform/linux-generic/` directory that contains that implementation. The +alternate form `linux-gen` may be used to conserve line space if desired. + +performance:: +perftest:: +Patch applies to the ODP performance test suite contained in the +`test/performance` directory. + +test:: +Patch applies to the `test` directory. This can be used as a generic area +for non-specific test patches. + +validation:: +Patch applies to the ODP validation test suite contained in the +`test/validation` directory. + +Any other patch that applies to some other top-level directory or file should +use that directory or file name as its area. + +The component portion of the short log identifies the ODP component that this +patch applies to. A component is required unless the area is a single file, in +which case it may be omitted. Components should be selected from the following +list: + +buffer:: +Buffers and buffer processing. + +classification:: +cls:: +Classification. `cls` may be used as an abbreviation for space if desired. + +crypto:: +Crypto. + +packet:: +Packets and packet processing. + +pktio:: +Packet I/O (pktio) and its related sub-components + +pool:: +Buffer pools and related processing. + +queue:: +Queues and related processing. + +scheduler:: +sched:: +Scheduler and related processing. `sched` may be used as an abbreviation for +space if desired. + +time:: +Time. + +timer:: +Timers and related processing. + +tm:: +Traffic Manager and related processing. + +Following the component the rest of the short log should describe the purpose +of this patch. + +=== Examples +To illustrate, here are some examples of good and bad short logs: + +Good:: +* `api: pool: add new foo attribute to pools` +* `linux-generic: pool: implement new foo attribute for pools` +* `validation: pool: test new foo attribute for pools` + +Bad:: +* `fix something` (doesn't follow required format) +* `api: propose a new api` (missing component) +* `validation: pool: a description that rambles on and on and never gets to +the point` + == Common Errors in Patch and Commit Messages - Avoid starting the summary line with a capital letter, unless the component being referred to also begins with a capital letter. -- Don't have one huge patch, split your change into logical subparts. It's +- Don't have one huge patch, split your change into logical sub-parts. It's easier to track down problems afterward using tools such as git bisect. It also makes it easy for people to cherry-pick changes into things like stable - branches. + branches. Note, however, that each part of a multi-part patch must apply and + build in sequence. That is, if the patch consists of three parts, Part 1 must + build by itself, as must Parts 1 and 2, in addition to all three parts + together. +- If a patch cannot be sepeated because of interdependencies (e.g., an API is + changed and this requires changes to the implementation of that API as well + as tests and examples that make use of it, then the short log should reflect + the "highest" level change made by the patch (in this case, API). - Don't simply translate your change into English for a commit log. The log "Change compare from zero to one" is bad because it describes only the code change in the patch; we can see that from reading the patch itself. Let the @@ -79,7 +225,7 @@ Code without a proper signoff cannot be merged into the mainline. entry point, or start of the trace is relevant (i.e. a syscall or similar), you can leave that, and then replace a chunk of the intermediate calls in the middle with a single [...] -- Don't include timestamps or other unnecessary information, unless they are +- Don't include time stamps or other unnecessary information, unless they are relevant to the situation (i.e. indicating an unacceptable delay in a driver initialization etc.) - Don't use links to temporary resources like pastebin and friends. The commit @@ -90,9 +236,9 @@ Code without a proper signoff cannot be merged into the mainline. == Documenting -- References to wikipedia are not permitted. +- References to Wikipedia are not permitted. -=== Documenting the code +=== Documenting the Code - Allow doxygen to use all its default behaviors to identify tagged information but where a doxygen tag must be specified use @ @@ -154,6 +300,6 @@ Code without a proper signoff cannot be merged into the mainline. image::../.svg[align="center"] ---- - The images are stored in the doc/images directory as svg files, src for image - generators such as .gv and .msg should also render to .svg + generators such as .gv and .msc should also render to .svg - Body text shall wrap at the 80 char point. - No warnings may be generated by the asciidoctor tool.