From patchwork Mon May 2 11:47:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 67007 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp1033769qge; Mon, 2 May 2016 04:47:43 -0700 (PDT) X-Received: by 10.107.131.12 with SMTP id f12mr40003135iod.126.1462189663683; Mon, 02 May 2016 04:47:43 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id dr5si20082496igc.3.2016.05.02.04.47.38; Mon, 02 May 2016 04:47:43 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id DDA3961603; Mon, 2 May 2016 11:47:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0464F615F5; Mon, 2 May 2016 11:47:34 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id F2E1561601; Mon, 2 May 2016 11:47:31 +0000 (UTC) Received: from mail-qk0-f171.google.com (mail-qk0-f171.google.com [209.85.220.171]) by lists.linaro.org (Postfix) with ESMTPS id 350A9615F3 for ; Mon, 2 May 2016 11:47:31 +0000 (UTC) Received: by mail-qk0-f171.google.com with SMTP id r184so72184958qkc.1 for ; Mon, 02 May 2016 04:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=I/ho4nezeqkdYCmwZyTkVoUxqkEBh4YzLCtpvOEoWzo=; b=Kpe9LtaUgWyB8lG8eftzmURHv+4oFK2lu7a+AMbqgORc1dk+9FT79hDMoVMOGUcSxj 4k7Uw9rZ6eVAH5TfgdjknMBHTTBTgAdgp7g5gpc0x9xITU2F/dAqbuMkdP6qFSZbSNlz UhaHLSUtO+esqNB3zuSgpzP7/b6AukWUDnpqXF4+KklTODXGLmVGqpb3MY6V3qPgXXl5 uqeX+DR/1RJvdIFFbu6F0csR18QvVs610cZcLC2K4Yt1bmg6io+fo6IT5lTtAelUzlO6 taprS08zggluFzuwryfjryhhfrW0tv+D40A5mTsUDNXo5KL1oXopdVi4ScnkTunooxew B6YA== X-Gm-Message-State: AOPr4FWuHUq5t3FQ41T/bGGqD166XwOwVlHg28/28vzQtlDWYB1E5aUlSRxJN2NR7lQVwUwJIFQ= X-Received: by 10.233.216.7 with SMTP id u7mr33166525qkf.141.1462189650875; Mon, 02 May 2016 04:47:30 -0700 (PDT) Received: from localhost.localdomain (c-98-221-136-245.hsd1.nj.comcast.net. [98.221.136.245]) by smtp.gmail.com with ESMTPSA id d31sm9025750qgd.44.2016.05.02.04.47.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 May 2016 04:47:30 -0700 (PDT) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Mon, 2 May 2016 07:47:15 -0400 Message-Id: <1462189635-547-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.7.4 X-Topics: patch Subject: [lng-odp] [PATCH] helper: remove unused odph_linux_process_fork API X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" odph_linux_process_fork is not used by any ODP example or test, it is also untested by the helper test suite. odph_linux_process_fork is a wrapper for odph_linux_process_fork_n so just delete this, the impact if there are any users is very small. Signed-off-by: Mike Holmes --- helper/include/odp/helper/linux.h | 18 ------------------ helper/linux.c | 10 ---------- 2 files changed, 28 deletions(-) diff --git a/helper/include/odp/helper/linux.h b/helper/include/odp/helper/linux.h index 7a6504f..a68f269 100644 --- a/helper/include/odp/helper/linux.h +++ b/helper/include/odp/helper/linux.h @@ -80,24 +80,6 @@ int odph_linux_pthread_create(odph_linux_pthread_t *pthread_tbl, */ void odph_linux_pthread_join(odph_linux_pthread_t *thread_tbl, int num); - -/** - * Fork a process - * - * Forks and sets CPU affinity for the child process. Ignores 'start' and 'arg' - * thread parameters. - * - * @param[out] proc Pointer to process state info (for output) - * @param cpu Destination CPU for the child process - * @param thr_params Linux helper thread parameters - * - * @return On success: 1 for the parent, 0 for the child - * On failure: -1 for the parent, -2 for the child - */ -int odph_linux_process_fork(odph_linux_process_t *proc, int cpu, - const odph_linux_thr_params_t *thr_params); - - /** * Fork a number of processes * diff --git a/helper/linux.c b/helper/linux.c index 24e243b..a181322 100644 --- a/helper/linux.c +++ b/helper/linux.c @@ -183,16 +183,6 @@ int odph_linux_process_fork_n(odph_linux_process_t *proc_tbl, return 1; } -int odph_linux_process_fork(odph_linux_process_t *proc, int cpu, - const odph_linux_thr_params_t *thr_params) -{ - odp_cpumask_t mask; - - odp_cpumask_zero(&mask); - odp_cpumask_set(&mask, cpu); - return odph_linux_process_fork_n(proc, &mask, thr_params); -} - int odph_linux_process_wait_n(odph_linux_process_t *proc_tbl, int num) { pid_t pid;