From patchwork Wed Apr 6 06:40:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balakrishna Garapati X-Patchwork-Id: 65151 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp869817lbc; Tue, 5 Apr 2016 23:40:52 -0700 (PDT) X-Received: by 10.140.28.135 with SMTP id 7mr51748889qgz.72.1459924852247; Tue, 05 Apr 2016 23:40:52 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id f93si1021832qgd.92.2016.04.05.23.40.51; Tue, 05 Apr 2016 23:40:52 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id A359A6196A; Wed, 6 Apr 2016 06:40:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 79F1A617B2; Wed, 6 Apr 2016 06:40:47 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 58EC6611FC; Wed, 6 Apr 2016 06:40:45 +0000 (UTC) Received: from mail-lf0-f44.google.com (mail-lf0-f44.google.com [209.85.215.44]) by lists.linaro.org (Postfix) with ESMTPS id 55FB9611FC for ; Wed, 6 Apr 2016 06:40:44 +0000 (UTC) Received: by mail-lf0-f44.google.com with SMTP id e190so24816974lfe.0 for ; Tue, 05 Apr 2016 23:40:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=C67k0GKaqaDzDu0djsDrBOUtMrEL2GyCX5rTHN33eK0=; b=WBYfT1KvRz9bRpUCluh/xi1XaQsdNnOcMLfmNOyeRLbO2jn548XeEohRndCMhiXPhw pADVExSm/rz8HR02OgqnfjLZ91zUGNJ4E71yXupPFLHtvnBMJ+9aMwd7if7xBnij0Zib hIDAy0lzFpmcOzgmoOMEpW/A9FbGgB6nqmf8oj2VFQ6HsNveLMLp9Uk6hD+KjXChgFHZ WYqv9O1zOkLCzwghGmd8fdnNPoZ5gUNMthvLTOwtaYQeWP2ES/K/nAipS1haDYDQYaKP ySmmmHvY6hJK59Rjx9EZOGfuQMM+6kPL/Cei0kLwO+s+v6WbdODZtLmGftwdjFoRZbWN yHUw== X-Gm-Message-State: AD7BkJLUFxBPXTIoaVi/7hPToJYfa3dpkrveFnn3Q2QzTC4+1vVu2jLWBe2QIjQnpTNeoYmZ+fs= X-Received: by 10.25.34.202 with SMTP id i193mr1037553lfi.117.1459924842960; Tue, 05 Apr 2016 23:40:42 -0700 (PDT) Received: from elxahtkds32.localdomain (host-95-192-229-12.mobileonline.telia.com. [95.192.229.12]) by smtp.gmail.com with ESMTPSA id ub6sm226622lbb.17.2016.04.05.23.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 05 Apr 2016 23:40:42 -0700 (PDT) From: Balakrishna Garapati To: bala.manoharan@linaro.org, maxim.uvarov@linaro.org Date: Wed, 6 Apr 2016 08:40:41 +0200 Message-Id: <1459924841-29611-1-git-send-email-balakrishna.garapati@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCHv3] test: performance: Avoid possible out-of-bounds memory access X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Resolving https://bugs.linaro.org/show_bug.cgi?id=2136 by initializing definite number of worker threads. Signed-off-by: Balakrishna Garapati Reviewed-by: Balasubramanian Manoharan --- v1: Fix for the https://bugs.linaro.org/show_bug.cgi?id=2136 v2: comments from v1 v3: Adding commit message test/performance/odp_crypto.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) -- 1.9.1 diff --git a/test/performance/odp_crypto.c b/test/performance/odp_crypto.c index fe1c7b4..0ea0b1b 100644 --- a/test/performance/odp_crypto.c +++ b/test/performance/odp_crypto.c @@ -719,12 +719,12 @@ int main(int argc, char *argv[]) odp_pool_t pool; odp_queue_param_t qparam; odp_pool_param_t params; - odph_linux_pthread_t thr; odp_queue_t out_queue = ODP_QUEUE_INVALID; thr_arg_t thr_arg; - int num_workers = 1; odp_cpumask_t cpumask; char cpumaskstr[ODP_CPUMASK_STR_SIZE]; + int num_workers = 1; + odph_linux_pthread_t thr[num_workers]; memset(&cargs, 0, sizeof(cargs)); @@ -793,13 +793,15 @@ int main(int argc, char *argv[]) printf("Run in sync mode\n"); } + memset(thr, 0, sizeof(thr)); + if (cargs.alg_config) { if (cargs.schedule) { - odph_linux_pthread_create(&thr, &cpumask, + odph_linux_pthread_create(&thr[0], &cpumask, run_thr_func, &thr_arg, ODP_THREAD_WORKER); - odph_linux_pthread_join(&thr, num_workers); + odph_linux_pthread_join(&thr[0], num_workers); } else { run_measure_one_config(&cargs, cargs.alg_config); }