From patchwork Mon Apr 4 16:13:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 65019 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1274904lbc; Mon, 4 Apr 2016 09:14:20 -0700 (PDT) X-Received: by 10.50.79.196 with SMTP id l4mr12579538igx.11.1459786460549; Mon, 04 Apr 2016 09:14:20 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id ck4si9102402igc.11.2016.04.04.09.14.20; Mon, 04 Apr 2016 09:14:20 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id D5553617F8; Mon, 4 Apr 2016 16:14:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 406E3617EF; Mon, 4 Apr 2016 16:14:17 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 5B8D3617F7; Mon, 4 Apr 2016 16:14:14 +0000 (UTC) Received: from mail-oi0-f52.google.com (mail-oi0-f52.google.com [209.85.218.52]) by lists.linaro.org (Postfix) with ESMTPS id 50CB3617EF for ; Mon, 4 Apr 2016 16:14:01 +0000 (UTC) Received: by mail-oi0-f52.google.com with SMTP id w85so42518146oiw.0 for ; Mon, 04 Apr 2016 09:14:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=d/OzLFvFKNWkrRhaZQHVXQ08E5Eoum7TYxaXUhdxyPM=; b=Pyfc/eUUQ71Bw41xsxO2mcBz00AS2f9+i/kp3PsP68wqomxBqp4Kek7jYKvfEO0gcL kEH7bvNIsyfr3EmYnTKkoH/LOpOP5AzuMxBLlUzmMuzkXWHC8cpfDxLFxxHApDE5FUAe FzvVr2rx13/EqnPy0VWfwVanAKEXsky4SsmQwJktzKS7vBNTHS1WEzqLlVKEEF0ViRna JXfvxjma9d/aGMbfm3ji6QwPmLbQgbdtX1Bt9fv8DQccH0zjT1/oO6IdDtURimIAkU2I 67u5Dqi7VPFAGxsIAqvp3SdCtF2hTSQGBXeYUbRavQodi2dkaicrCNkbjfI8cy49yelb UwYA== X-Gm-Message-State: AD7BkJIBOya9MpMIBYUAS8XO0ukLmJJ4gsKVynJPI9CWqJ//kY2pZLKQHjXlivwVscjPA4/u97c= X-Received: by 10.202.217.136 with SMTP id q130mr10946335oig.127.1459786440879; Mon, 04 Apr 2016 09:14:00 -0700 (PDT) Received: from Ubuntu15.localdomain (cpe-66-68-129-43.austin.res.rr.com. [66.68.129.43]) by smtp.gmail.com with ESMTPSA id xt3sm8625186obc.28.2016.04.04.09.13.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Apr 2016 09:13:56 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Mon, 4 Apr 2016 11:13:53 -0500 Message-Id: <1459786433-1161-1-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.5.0 X-Topics: patch Subject: [lng-odp] [PATCHv5] linux-generic: pktio: avoid coverity issues by adding explicit rc check X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit rc check for odp_pktio_capability(). Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index 9192be2..afe5c34 100644 --- a/platform/linux-generic/odp_packet_io.c +++ b/platform/linux-generic/odp_packet_io.c @@ -1027,6 +1027,7 @@ int odp_pktin_queue_config(odp_pktio_t pktio, odp_pktio_capability_t capa; unsigned num_queues; unsigned i; + int rc; odp_queue_t queue; odp_pktin_queue_param_t default_param; @@ -1059,7 +1060,12 @@ int odp_pktin_queue_config(odp_pktio_t pktio, return -1; } - odp_pktio_capability(pktio, &capa); + rc = odp_pktio_capability(pktio, &capa); + if (rc) { + ODP_DBG("pktio %s: unable to read capabilities\n", + entry->s.name); + return -1; + } if (num_queues > capa.max_input_queues) { ODP_DBG("pktio %s: too many input queues\n", entry->s.name); @@ -1135,6 +1141,7 @@ int odp_pktout_queue_config(odp_pktio_t pktio, odp_pktio_capability_t capa; unsigned num_queues; unsigned i; + int rc; odp_pktout_queue_param_t default_param; if (param == NULL) { @@ -1172,7 +1179,12 @@ int odp_pktout_queue_config(odp_pktio_t pktio, return -1; } - odp_pktio_capability(pktio, &capa); + rc = odp_pktio_capability(pktio, &capa); + if (rc) { + ODP_DBG("pktio %s: unable to read capabilities\n", + entry->s.name); + return -1; + } if (num_queues > capa.max_output_queues) { ODP_DBG("pktio %s: too many output queues\n", entry->s.name);