From patchwork Sat Mar 26 21:21:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Fischofer X-Patchwork-Id: 64505 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp769976lbc; Sat, 26 Mar 2016 14:21:28 -0700 (PDT) X-Received: by 10.55.31.215 with SMTP id n84mr17459529qkh.93.1459027288685; Sat, 26 Mar 2016 14:21:28 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 39si15611872qgn.107.2016.03.26.14.21.28; Sat, 26 Mar 2016 14:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0A9AA6194B; Sat, 26 Mar 2016 21:21:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 6548461935; Sat, 26 Mar 2016 21:21:23 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7F86961937; Sat, 26 Mar 2016 21:21:21 +0000 (UTC) Received: from mail-oi0-f53.google.com (mail-oi0-f53.google.com [209.85.218.53]) by lists.linaro.org (Postfix) with ESMTPS id A55FA61887 for ; Sat, 26 Mar 2016 21:21:20 +0000 (UTC) Received: by mail-oi0-f53.google.com with SMTP id h6so75236606oia.2 for ; Sat, 26 Mar 2016 14:21:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=MHFDdDOsfg2v6RGqJ1yUnFGO317ApFqtEKjhkNC1e54=; b=AH4e4/Wbt3Fa2cE8z31Sp8LMCHk/E2mwB29RjPQFt3VBEccuGCwo/WG8m6WtpxOiFw q19NPM1sd2V+NpB6dlBbDOIkQ47iPCpcAN9LTS2Xf0XVd3GMrOpZkYJMvJDDXYbhRfhc UGliZIFvglE4Sy44+zrKRSQiPYx41iXii0ab4e0vRWwo1I3kvN5DkvveisyP0jzpSytU V4RFGl/toSqYYG4HTukGoTDc1XFb8H+TnE2M8ePjN3lw4biIZUq1P9O2s7teYUYqzbny ZobHDQYqgd0NUU40uyirhCDCHDBkkQrKtI3BwDn/2ExzFiQcsN6JDmwr6cFUn8O0+q6y 5loQ== X-Gm-Message-State: AD7BkJJcEuK8r/KyS+FAlJNmnWrYIMeOaiFsR77xGHz/KTOyyRKhORhSMPx5VbjMO5XFeLf/yG0= X-Received: by 10.157.34.11 with SMTP id o11mr9956799ota.55.1459027280147; Sat, 26 Mar 2016 14:21:20 -0700 (PDT) Received: from Ubuntu15.localdomain (cpe-66-68-129-43.austin.res.rr.com. [66.68.129.43]) by smtp.gmail.com with ESMTPSA id i1sm5474437oef.7.2016.03.26.14.21.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 26 Mar 2016 14:21:19 -0700 (PDT) From: Bill Fischofer To: lng-odp@lists.linaro.org Date: Sat, 26 Mar 2016 16:21:17 -0500 Message-Id: <1459027277-6414-1-git-send-email-bill.fischofer@linaro.org> X-Mailer: git-send-email 2.5.0 X-Topics: patch Subject: [lng-odp] [PATCH] linux-generic: pktio: avoid coverity issues by adding explicit cast X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2138 by adding an explicit cast to odp_pktio_capability(). This routine cannot return a bad RC since the error condition is already guarded earlier in the code, however coverity doesn't see this. Signed-off-by: Bill Fischofer --- platform/linux-generic/odp_packet_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/platform/linux-generic/odp_packet_io.c b/platform/linux-generic/odp_packet_io.c index 9192be2..dfeeeaf 100644 --- a/platform/linux-generic/odp_packet_io.c +++ b/platform/linux-generic/odp_packet_io.c @@ -1059,7 +1059,7 @@ int odp_pktin_queue_config(odp_pktio_t pktio, return -1; } - odp_pktio_capability(pktio, &capa); + (void)odp_pktio_capability(pktio, &capa); if (num_queues > capa.max_input_queues) { ODP_DBG("pktio %s: too many input queues\n", entry->s.name); @@ -1172,7 +1172,7 @@ int odp_pktout_queue_config(odp_pktio_t pktio, return -1; } - odp_pktio_capability(pktio, &capa); + (void)odp_pktio_capability(pktio, &capa); if (num_queues > capa.max_output_queues) { ODP_DBG("pktio %s: too many output queues\n", entry->s.name);