From patchwork Tue Jan 26 16:39:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 60475 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp2070257lbb; Tue, 26 Jan 2016 08:39:49 -0800 (PST) X-Received: by 10.140.168.85 with SMTP id o82mr31907589qho.8.1453826389242; Tue, 26 Jan 2016 08:39:49 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id z2si31276323qka.96.2016.01.26.08.39.48; Tue, 26 Jan 2016 08:39:49 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8C49A6176A; Tue, 26 Jan 2016 16:39:48 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=fail reason="verification failed; unprotected key" header.d=linaro.org header.i=@linaro.org header.b=QcpISMSc; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 2DBD0615F9; Tue, 26 Jan 2016 16:39:40 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2D2666174D; Tue, 26 Jan 2016 16:39:36 +0000 (UTC) Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by lists.linaro.org (Postfix) with ESMTPS id 2493D615F1 for ; Tue, 26 Jan 2016 16:39:34 +0000 (UTC) Received: by mail-wm0-f49.google.com with SMTP id u188so114023692wmu.1 for ; Tue, 26 Jan 2016 08:39:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=uiC5z4MR9P6pug+oE6Ryf5m8GYB5Ny57RJNp65U2hEI=; b=QcpISMScNslIw1GAF9e+hBWRG2X6Iw3EmitU04VEZzgIlVZd/VNbDzZyw0k9og60wr ti7qqjwTF9mc+6RJpa6QaiZZPrDF1BP6AuJCovPP3xx1ibTPbW/7Rj7u+pLH5uFkyeex TDf8GGBYlORYPKziSwzFQau+6ncQSMJkYDYmU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uiC5z4MR9P6pug+oE6Ryf5m8GYB5Ny57RJNp65U2hEI=; b=X/neKGwtDKIOUAZafUVuZjh7w1V7iql3hQ2R/Q1I/g3FFV2Z4l9xC/HT1eu/KpVuXR cYmHAYE6Pb6cbIIXOMq7o5IjGa1m6YXiLoxyijnXBi16lPV5AKN2rOCk/c5zyzEp6YCT CGFCL+vRMbBliN7mGHYs4ZL3jSm6HMiqbjckhONLHwD+zfhAxjZRsFH2mf6ef5owZZF2 /63q17+BGTLCqeTqeWBJH/OxwK9cG3kiD5YH1LJqNxGZxm5tc+J5ld9aP8JdXUwy0BR0 NJAIGIHcE0XPby2L58wKvy/mYFLiiCzySqXT3JjEgI8tIkMuM53xHSxNRYikFaYUdNx1 0xXA== X-Gm-Message-State: AG10YOSjgGM7bJ1frqCoCMcOKRbPe2j+2n7qGfe6ZL1P89L0Hbx/HV7dszfOZQUn2otOo/E21ho= X-Received: by 10.28.32.206 with SMTP id g197mr26375217wmg.28.1453826373314; Tue, 26 Jan 2016 08:39:33 -0800 (PST) Received: from e106441.emea.arm.com ([2001:41d0:a:3cb4::1]) by smtp.gmail.com with ESMTPSA id t199sm3621187wmt.23.2016.01.26.08.39.32 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jan 2016 08:39:32 -0800 (PST) From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Tue, 26 Jan 2016 16:39:09 +0000 Message-Id: <1453826349-20235-1-git-send-email-stuart.haslam@linaro.org> X-Mailer: git-send-email 2.1.1 X-Topics: patch Subject: [lng-odp] [PATCH] linux-generic: validation: fix dependency for tests-validation.env X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" The tests-validation.env file lists the test binaries/scripts to be run during post-install testing, but the Makefile dependencies are wrong so it gets created once and never updated. This means the following sequence doesn't actually peform testing as expected - ./configure make ./configure --enable-test-vald --with-testdir --prefix=$(pwd)/mytests make install installcheck As the tests-environment.env file generated during the first make (with test-vald disabled) isn't updated. Signed-off-by: Stuart Haslam --- platform/linux-generic/test/Makefile.am | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/platform/linux-generic/test/Makefile.am b/platform/linux-generic/test/Makefile.am index e629872..8c35c15 100644 --- a/platform/linux-generic/test/Makefile.am +++ b/platform/linux-generic/test/Makefile.am @@ -36,14 +36,19 @@ TESTS += pktio/pktio_run_pcap endif endif -dist_check_SCRIPTS = run-test tests-validation.env $(LOG_COMPILER) +TEST_ENV = tests-validation.env + +dist_check_SCRIPTS = run-test $(TEST_ENV) $(LOG_COMPILER) test_SCRIPTS = $(dist_check_SCRIPTS) -tests-validation.env: - echo "TESTS=\"$(TESTS)\"" > $@ - echo "$(TESTS_ENVIRONMENT)" >> $@ - echo "$(LOG_COMPILER)" >> $@ +$(TEST_ENV): validation-test-env + +.PHONY: validation-test-env +validation-test-env: + echo "TESTS=\"$(TESTS)\"" > $(TEST_ENV) + echo "$(TESTS_ENVIRONMENT)" >> $(TEST_ENV) + echo "$(LOG_COMPILER)" >> $(TEST_ENV) if test_installdir installcheck-local: