From patchwork Tue Jan 12 22:36:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Holmes X-Patchwork-Id: 59642 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp3011212lbb; Tue, 12 Jan 2016 14:36:51 -0800 (PST) X-Received: by 10.55.204.216 with SMTP id n85mr21231618qkl.36.1452638211463; Tue, 12 Jan 2016 14:36:51 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id d70si42640880qkb.34.2016.01.12.14.36.50; Tue, 12 Jan 2016 14:36:51 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C8F6561749; Tue, 12 Jan 2016 22:36:50 +0000 (UTC) Authentication-Results: lists.linaro.org; dkim=fail reason="verification failed; unprotected key" header.d=linaro.org header.i=@linaro.org header.b=N0gSZv6l; dkim-adsp=none (unprotected policy); dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,T_DKIM_INVALID,URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id E51FB61745; Tue, 12 Jan 2016 22:36:44 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7987561745; Tue, 12 Jan 2016 22:36:42 +0000 (UTC) Received: from mail-qg0-f43.google.com (mail-qg0-f43.google.com [209.85.192.43]) by lists.linaro.org (Postfix) with ESMTPS id 8E5716173F for ; Tue, 12 Jan 2016 22:36:41 +0000 (UTC) Received: by mail-qg0-f43.google.com with SMTP id o11so441132299qge.2 for ; Tue, 12 Jan 2016 14:36:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Dn7UinIz2UlTG4H6Ii/zNfh83knqMPa8BHYjxOM/lw8=; b=N0gSZv6laQD3mtwC+vxXot/SDf1osbnujCHAnDIt7FUq6FWhiOHq2XvBtDp8buLfQR 29z67OV6i1wEDhxZOo6TKh6keMPEYz7QNK0zHYDUcDdfQ0MVh6Vs+E2nHk2CMRDPvTQJ 1Iudk+//Hr6F6ekiDOMFhFmo9YnCpLdhUz688= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Dn7UinIz2UlTG4H6Ii/zNfh83knqMPa8BHYjxOM/lw8=; b=QJhIMEvxhBgErGg6+ntOrlMZHBRCXOSCdVS3RYhS+7Mv2nSZbOSIurupJJQg5JGI1J cQGLLgzMqIxio5tThgzKj1MVTIo+QSKnma4akNDlhB0OaU3IlHx5UADNaChNgIShpy95 96Jo9ncDpF07ydOI5uNDSJQuyxZ6dvljShMj3aBFXOj2fKIvJGQWNZS8sMYbOyqDZdCC i4Jz/MgCwy8CqXf+wnADD2tUkxKgSg9SR9Tj9CsrNNYduLYkIIO/ib6v3EbEbrcBRIMT 3PX+Jb6uGe2d/Md/aakaxST7kV4XfWrTAoXw5l8ghTvjipve7jPmU18GccttrmhLGb1Z WIuw== X-Gm-Message-State: ALoCoQlKdtcgJqY4mH+o7oz9R9dlB6N+iFvt2IRO7Vi9gtiANhCn3OjoiIBbghEIM98tjOizYUeGQhNud9OALyBtzPC8n6OlEQ== X-Received: by 10.140.237.74 with SMTP id i71mr121059123qhc.55.1452638201346; Tue, 12 Jan 2016 14:36:41 -0800 (PST) Received: from localhost.localdomain (c-98-221-136-245.hsd1.nj.comcast.net. [98.221.136.245]) by smtp.gmail.com with ESMTPSA id u45sm57350303qgd.26.2016.01.12.14.36.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Jan 2016 14:36:40 -0800 (PST) From: Mike Holmes To: lng-odp@lists.linaro.org Date: Tue, 12 Jan 2016 17:36:35 -0500 Message-Id: <1452638195-23806-1-git-send-email-mike.holmes@linaro.org> X-Mailer: git-send-email 2.5.0 X-Topics: patch Subject: [lng-odp] [PATCH] test: perf: l2fwd detect missing odp_generator X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" The script did not check that the odp_generator was present and worse it failed silently if it was not present. Signed-off-by: Mike Holmes --- test/performance/odp_l2fwd_run | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/performance/odp_l2fwd_run b/test/performance/odp_l2fwd_run index 001d8c2..a1446e8 100755 --- a/test/performance/odp_l2fwd_run +++ b/test/performance/odp_l2fwd_run @@ -54,6 +54,16 @@ run_l2fwd() exit $TEST_SKIPPED fi + type odp_generator > /dev/null + if [ $? -ne 0 ]; then + echo "odp_generator not installed. Aborting." + cleanup_pktio_env + if [ $? -ne 0 ]; then + echo "cleanup_pktio_env error $?" + fi + exit 1 + fi + #@todo: limit odp_generator to cores #https://bugs.linaro.org/show_bug.cgi?id=1398 (odp_generator${EXEEXT} -I $IF0 \