From patchwork Thu Nov 19 14:30:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 57000 Delivered-To: patch@linaro.org Received: by 10.112.155.196 with SMTP id vy4csp3215667lbb; Thu, 19 Nov 2015 06:32:32 -0800 (PST) X-Received: by 10.140.99.6 with SMTP id p6mr7063056qge.76.1447943552731; Thu, 19 Nov 2015 06:32:32 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id o190si6948840qhb.8.2015.11.19.06.32.32; Thu, 19 Nov 2015 06:32:32 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: by lists.linaro.org (Postfix, from userid 109) id 4C4FB61A27; Thu, 19 Nov 2015 14:32:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 876AC61B21; Thu, 19 Nov 2015 14:30:43 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8E25561A32; Thu, 19 Nov 2015 14:30:39 +0000 (UTC) Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com [209.85.215.50]) by lists.linaro.org (Postfix) with ESMTPS id 1877C61A30 for ; Thu, 19 Nov 2015 14:30:16 +0000 (UTC) Received: by lfaz4 with SMTP id z4so49255184lfa.0 for ; Thu, 19 Nov 2015 06:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=TpkNvzdl3vur/XUx/ZDUz3qeRiwATSIfO4ptD7HpxJs=; b=M0VYjJ/0NN+xgSd6WAiR6ErvgSl/FK/A+K7/oi7H7YGEuCA7tHCSdFAGpiCJHfWYHR xdU+UlKR2tCT8stZyylLlI8A7V3PaAaOGtOuo/en5oIBgdgNfKSeuarQ+eKQfI0jhgCx oBo6bKVNh6ZROWrtzu1tICc7OMZOigvZTdBwx8Q7vuc551I+Te243C0fJQLNgB0WcEtj Txha8DQYxPHCGvKB1muncuBBEP/LYc9HHjcMEtsowbE/RiFdcVQkRqv+ET3AaXi4WNag 74g6nosZ8FROjWrfsS2omerAb4ldH7GP8MN9hTJeN+1OUd8KEGvwmhjGv/yVZ1SlQD3w jJig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=TpkNvzdl3vur/XUx/ZDUz3qeRiwATSIfO4ptD7HpxJs=; b=O+9n7xebfAjqNpGoafv3AgDbmmIZ8+ZlEww6iAJYjP47sZ3U8SQ9Ujsmux9M8JWUc9 xcsGXfXw069b3eXQHJIPruNOCDylOSu+zEYsgoFlEKSYZfgtAm3dIvEfQQKDamDiTJJi BvI0bhNmKxFwyECuVgVXDkygl/d3svOPZvxTSoKYWcOr5tzdQTtei74P7MTf4AfDtAJc h/Pzckf073pQrUWiRfF8SoEdzrMM0VdD11acZusCdHB5xiwn+ZhMBJ4dgN8jNobvqF0i 8b3idYjdbxe1DXkNad+MQm8UVXKL6+FVNQX6b/nWqyUC9fPsYJQl7rzeVWKM4c6UQNaW oKew== X-Gm-Message-State: ALoCoQlPlpBT8vVSP4T4+EoymfFucq4pwM0AIW09h3zcy2ldEHLpNd/MogTt59eVlcTVGrYoiAU2 X-Received: by 10.25.162.144 with SMTP id l138mr3503574lfe.30.1447943414823; Thu, 19 Nov 2015 06:30:14 -0800 (PST) Received: from localhost.localdomain ([195.238.92.128]) by smtp.gmail.com with ESMTPSA id f71sm535235lfe.36.2015.11.19.06.30.13 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Nov 2015 06:30:13 -0800 (PST) From: Ivan Khoronzhuk To: lng-odp@lists.linaro.org Date: Thu, 19 Nov 2015 16:30:03 +0200 Message-Id: <1447943403-24803-4-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1447943403-24803-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1447943403-24803-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Topics: patch Subject: [lng-odp] [PATCH v3 3/3] linux-generic: cpumask: warn that CPU0 is used by control and worker thread X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" By default, all control threads execute on CPU 0 and odp_cpumask_default_control() returns this CPU. For reasons of performance, control and worker CPU's shouldn't overlap but for some scenarios it can be desirable to utilize all CPU's for worker threads. Thus we leave the decision of CPU allocation to the user but report when a CPU is used for both control and worker threads. Signed-off-by: Ivan Khoronzhuk Reviewed-by: Ola Liljedahl --- platform/linux-generic/odp_cpumask_task.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/platform/linux-generic/odp_cpumask_task.c b/platform/linux-generic/odp_cpumask_task.c index 535891c..49dbdb7 100644 --- a/platform/linux-generic/odp_cpumask_task.c +++ b/platform/linux-generic/odp_cpumask_task.c @@ -40,6 +40,10 @@ int odp_cpumask_default_worker(odp_cpumask_t *mask, int num) } } + if (odp_cpumask_isset(mask, 0)) + ODP_DBG("\n\tCPU0 will be used for both control and worker threads,\n" + "\tthis will likely have a performance impact on the worker thread.\n"); + return cpu; }