From patchwork Wed Nov 4 22:13:14 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 56010 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp56771lbr; Wed, 4 Nov 2015 14:13:29 -0800 (PST) X-Received: by 10.107.136.106 with SMTP id k103mr5847642iod.187.1446675209625; Wed, 04 Nov 2015 14:13:29 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id t13si3935155ioi.114.2015.11.04.14.13.28; Wed, 04 Nov 2015 14:13:29 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: by lists.linaro.org (Postfix, from userid 109) id 815D061D8C; Wed, 4 Nov 2015 22:13:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 8337961D71; Wed, 4 Nov 2015 22:13:26 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 41B8161D87; Wed, 4 Nov 2015 22:13:24 +0000 (UTC) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com [209.85.217.178]) by lists.linaro.org (Postfix) with ESMTPS id 41DAD61D09 for ; Wed, 4 Nov 2015 22:13:22 +0000 (UTC) Received: by lbbkw15 with SMTP id kw15so16918922lbb.0 for ; Wed, 04 Nov 2015 14:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=OJH7oVnI9Fn99FfM4yROOtGNlwW2FL6o0FIOW32fMGg=; b=VbEoKUIPVI8yHkJExVGXOJdoBVyfJgQvtTpU2dHdwjoR6UfZR66uGwKW0lTUf6azSM 4qDd/8BPEmW76ckosNGim4JFWoLSaqcjDVrHGCnP8t3MFyvQH6oh6hI6mhmWQipy7JkY gqRAKcmi3UnOjJJZuugb8cDpHc1CoaUpOXTPQutr9BHByp0kWUX+5UFUyl/9O/sFmhm4 ql2jCo+SghucIOzi2HfVKjAxjSUMzr3DKH4vrLmEvo8hVn+jKlLSqf7U51rb2LAH4mPH SXUWD0cSc3AFDs3Ym59cYOI9wrOiEXcG5bPjpgvnTYkXjpkJl/5Zw/dypg7GeLGR0dY2 42DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=OJH7oVnI9Fn99FfM4yROOtGNlwW2FL6o0FIOW32fMGg=; b=f0rW9PNEDg05Ru9eHgd/y4AGqGspDfwbqdKnKqu21ptYZrcbMkA6I+jiiCLyODJiDD OjCuQIJkH3l1XXYUxRiyu8v6ksQIwnGnSZJZdNAJR6t91ii1bGnfrbnNc/jXMpoiKtB8 dgV+7uzknKq1BohciZFuZD4q+0eOiLRrivWRov0TLwWoLQL4tgRIr4iVEEVCzG5o+mBL GzzSYt/OyrtFvE48ciqHYDg9F7y4uy/Xujx5LaYBueqtCKlhsntAIe58ID01Tb7ptcFh wSxP6cVIVsrRH5vvwADD9DRGG5Li8kdB76W5H0oktfdI5sCVYJ3hO3HevQ/NAGYsYa5Q 7LGg== X-Gm-Message-State: ALoCoQlLy4VUMSS7h1UnWqv/6BEC4z89KrmvZ1EOqopOH3Mx/dJ+1iHPTy44J6DIzcyazAUDKOrj X-Received: by 10.112.166.102 with SMTP id zf6mr2148460lbb.124.1446675200824; Wed, 04 Nov 2015 14:13:20 -0800 (PST) Received: from localhost.localdomain ([212.90.60.8]) by smtp.gmail.com with ESMTPSA id d187sm48301lfd.26.2015.11.04.14.13.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Nov 2015 14:13:19 -0800 (PST) From: Ivan Khoronzhuk To: lng-odp@lists.linaro.org Date: Thu, 5 Nov 2015 00:13:14 +0200 Message-Id: <1446675194-30401-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [RFC PATCH] api: time: change order of arguments for diff function X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" It's more convenient to pass parameters in order, like t2 - t1, when t2 is supposed to be more. Signed-off-by: Ivan Khoronzhuk --- The same should be done for CPU cycle API example/generator/odp_generator.c | 2 +- include/odp/api/time.h | 4 ++-- platform/linux-generic/odp_schedule.c | 2 +- platform/linux-generic/odp_time.c | 2 +- test/performance/odp_pktio_perf.c | 8 ++++---- test/validation/pktio/pktio.c | 4 ++-- test/validation/time/time.c | 4 ++-- 7 files changed, 13 insertions(+), 13 deletions(-) diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c index 60e015b..ae5d9dc 100644 --- a/example/generator/odp_generator.c +++ b/example/generator/odp_generator.c @@ -604,7 +604,7 @@ static void print_global_stats(int num_workers) } now = odp_time_cycles(); - diff = odp_time_diff_cycles(start, now); + diff = odp_time_diff_cycles(now, start); if (odp_time_cycles_to_ns(diff) < verbose_interval * ODP_TIME_SEC) { continue; diff --git a/include/odp/api/time.h b/include/odp/api/time.h index b0072fc..4c7f5c2 100644 --- a/include/odp/api/time.h +++ b/include/odp/api/time.h @@ -40,12 +40,12 @@ uint64_t odp_time_cycles(void); /** * Time difference * - * @param t1 First time stamp * @param t2 Second time stamp + * @param t1 First time stamp * * @return Difference of time stamps in CPU cycles */ -uint64_t odp_time_diff_cycles(uint64_t t1, uint64_t t2); +uint64_t odp_time_diff_cycles(uint64_t t2, uint64_t t1); /** diff --git a/platform/linux-generic/odp_schedule.c b/platform/linux-generic/odp_schedule.c index 6df8073..418b497 100644 --- a/platform/linux-generic/odp_schedule.c +++ b/platform/linux-generic/odp_schedule.c @@ -608,7 +608,7 @@ static int schedule_loop(odp_queue_t *out_queue, uint64_t wait, } cycle = odp_time_cycles(); - diff = odp_time_diff_cycles(start_cycle, cycle); + diff = odp_time_diff_cycles(cycle, start_cycle); if (wait < diff) break; diff --git a/platform/linux-generic/odp_time.c b/platform/linux-generic/odp_time.c index abafd12..6b1aca5 100644 --- a/platform/linux-generic/odp_time.c +++ b/platform/linux-generic/odp_time.c @@ -19,7 +19,7 @@ uint64_t odp_time_cycles(void) return odp_cpu_cycles(); } -uint64_t odp_time_diff_cycles(uint64_t t1, uint64_t t2) +uint64_t odp_time_diff_cycles(uint64_t t2, uint64_t t1) { return _odp_cpu_cycles_diff(t1, t2); } diff --git a/test/performance/odp_pktio_perf.c b/test/performance/odp_pktio_perf.c index efd26dc..16614bb 100644 --- a/test/performance/odp_pktio_perf.c +++ b/test/performance/odp_pktio_perf.c @@ -336,11 +336,11 @@ static void *run_thread_tx(void *arg) cur_cycles = odp_time_cycles(); start_cycles = cur_cycles; - burst_start_cycles = odp_time_diff_cycles(burst_gap_cycles, cur_cycles); - while (odp_time_diff_cycles(start_cycles, cur_cycles) < send_duration) { + burst_start_cycles = odp_time_diff_cycles(cur_cycles, burst_gap_cycles); + while (odp_time_diff_cycles(cur_cycles, start_cycles) < send_duration) { unsigned alloc_cnt = 0, tx_cnt; - if (odp_time_diff_cycles(burst_start_cycles, cur_cycles) + if (odp_time_diff_cycles(cur_cycles, burst_start_cycles) < burst_gap_cycles) { cur_cycles = odp_time_cycles(); if (idle_start == 0) @@ -350,7 +350,7 @@ static void *run_thread_tx(void *arg) if (idle_start) { stats->s.idle_cycles += odp_time_diff_cycles( - idle_start, cur_cycles); + cur_cycles, idle_start); idle_start = 0; } diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index ff62b3c..4a798e3 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -345,7 +345,7 @@ static odp_event_t queue_deq_wait_time(odp_queue_t queue, uint64_t ns) if (ev != ODP_EVENT_INVALID) return ev; now = odp_time_cycles(); - diff = odp_time_diff_cycles(start, now); + diff = odp_time_diff_cycles(now, start); } while (odp_time_cycles_to_ns(diff) < ns); return ODP_EVENT_INVALID; @@ -389,7 +389,7 @@ static odp_packet_t wait_for_packet(pktio_info_t *pktio_rx, } now = odp_time_cycles(); - diff = odp_time_diff_cycles(start, now); + diff = odp_time_diff_cycles(now, start); } while (odp_time_cycles_to_ns(diff) < ns); CU_FAIL("failed to receive transmitted packet"); diff --git a/test/validation/time/time.c b/test/validation/time/time.c index 41db0e9..b3741ab 100644 --- a/test/validation/time/time.c +++ b/test/validation/time/time.c @@ -27,7 +27,7 @@ void time_test_odp_cycles_diff(void) cycles2 = odp_time_cycles(); CU_ASSERT(cycles2 > cycles1); - diff = odp_time_diff_cycles(cycles1, cycles2); + diff = odp_time_diff_cycles(cycles2, cycles1); CU_ASSERT(diff > 0); } @@ -38,7 +38,7 @@ void time_test_odp_cycles_negative_diff(void) cycles1 = 10; cycles2 = 5; - diff = odp_time_diff_cycles(cycles1, cycles2); + diff = odp_time_diff_cycles(cycles2, cycles1); CU_ASSERT(diff > 0); }