From patchwork Tue Nov 3 15:00:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 55942 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp1882312lbr; Tue, 3 Nov 2015 07:01:23 -0800 (PST) X-Received: by 10.107.156.81 with SMTP id f78mr31955499ioe.107.1446562879571; Tue, 03 Nov 2015 07:01:19 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id n5si8305340igv.64.2015.11.03.07.01.17; Tue, 03 Nov 2015 07:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dkim=neutral (body hash did not verify) header.i=@linaro_org.20150623.gappssmtp.com Received: by lists.linaro.org (Postfix, from userid 109) id DB91A61C6D; Tue, 3 Nov 2015 15:01:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id D48A061BC1; Tue, 3 Nov 2015 15:01:12 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 8203D61BFD; Tue, 3 Nov 2015 15:01:10 +0000 (UTC) Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com [209.85.212.172]) by lists.linaro.org (Postfix) with ESMTPS id A42F161B63 for ; Tue, 3 Nov 2015 15:01:08 +0000 (UTC) Received: by wicfx6 with SMTP id fx6so71150631wic.1 for ; Tue, 03 Nov 2015 07:01:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=MEGi0Lg1rCb2pcdlj2PfZYrBKxXV+hznzeWRvhzCISs=; b=PBBlRMzH2OrlxRZgwB44EgJnlv61KSOzk5n2/AVvJinWOYHx3ufCN4mcuIq5vCNxrn kEGIjPYgtO5BHQOfOXM2VguDCzT1WxpGJzl6c6AMdNn+5iIxuxZ8j23N7ORHEx8XpUZN XEeDbpFQuqmd/HKJrh04ZiHeB5XPN4DJS8Z68ucgN8vO8VRxn8ZdMAWPjZOXRrdUHMAf ya05v1o/h50SSwEhr38BST0I9aEFqITObw8rcoJVx6RFK8r+0ascveJnEgxS/1jEcDuR LD/1rHbAcbKZ9kWYdIT2msx5PcOzYH1Cp1zCgBUQCKwdPA0WJ14fqOetGketcLEjRdqy JzjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=MEGi0Lg1rCb2pcdlj2PfZYrBKxXV+hznzeWRvhzCISs=; b=LlsI8we3nAFqsPac6LvvZWmUKYBI5QuDDhiC3HyZiLDUFibd3G7JGCvIWDY7s1Jlzt D9FvYMTnbX82LvXq9zNEO94l9z3YYduA/zUDp/qDo4zrN2zAl0JzZiwHTmFgmL7ZocCS xdrQjMr3gHPIiV9Dmn6+noDwb+NjrrzyIheDl99QCJdIp5W7+5gBV5lr7YR5wV3KDKT8 M9p1DFPWdaGWqLDzN0RD8dxPuxTvsh4wW6bfcWmWOCUpjRclDVmSZPeYvRG2/nRb8EYg OJtf4yufFFZd5xuGPASr4JwG7J2BLqvu52rmAHHcEva7dh20y8g7pGX1jyu6oXXfcbRm u1ug== X-Gm-Message-State: ALoCoQl9wBFIRnsz/P3tZSQwhCbURAa51t1S2WDFtdozzJE8OLR803iXhOcjR0t8zQUVf7R1Cy5R X-Received: by 10.194.133.229 with SMTP id pf5mr22182817wjb.136.1446562867830; Tue, 03 Nov 2015 07:01:07 -0800 (PST) Received: from e106441.emea.arm.com ([2001:41d0:a:3cb4::abcd]) by smtp.gmail.com with ESMTPSA id at4sm27996745wjc.9.2015.11.03.07.01.06 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 03 Nov 2015 07:01:07 -0800 (PST) From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Tue, 3 Nov 2015 15:00:48 +0000 Message-Id: <1446562848-15069-1-git-send-email-stuart.haslam@linaro.org> X-Mailer: git-send-email 2.1.1 X-Topics: patch Subject: [lng-odp] [PATCH] validation: pktio: initialize queue parameters correctly X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" A call to odp_queue_param_init() is missing so uninitialized parameters are passed to odp_queue_create() leading to unpredictable results. Signed-off-by: Stuart Haslam --- pktio tests fail fairly regularly when built with clang. test/validation/pktio/pktio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/validation/pktio/pktio.c b/test/validation/pktio/pktio.c index 9c16e94..a2da47b 100644 --- a/test/validation/pktio/pktio.c +++ b/test/validation/pktio/pktio.c @@ -278,6 +278,7 @@ static int create_inq(odp_pktio_t pktio, odp_queue_type_t qtype) odp_queue_t inq_def; char inq_name[ODP_QUEUE_NAME_LEN]; + odp_queue_param_init(&qparam); qparam.sched.prio = ODP_SCHED_PRIO_DEFAULT; qparam.sched.sync = ODP_SCHED_SYNC_ATOMIC; qparam.sched.group = ODP_SCHED_GROUP_ALL;