From patchwork Fri Oct 30 13:16:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wallen, Carl \(Nokia - FI/Espoo\)" X-Patchwork-Id: 55835 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp1216022lbr; Fri, 30 Oct 2015 06:17:46 -0700 (PDT) X-Received: by 10.50.155.41 with SMTP id vt9mr2810851igb.22.1446211066223; Fri, 30 Oct 2015 06:17:46 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id e6si2398606igo.5.2015.10.30.06.17.45; Fri, 30 Oct 2015 06:17:46 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id A421962C3C; Fri, 30 Oct 2015 13:17:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 8EE5162C44; Fri, 30 Oct 2015 13:16:17 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id AF15F62C3B; Fri, 30 Oct 2015 13:16:12 +0000 (UTC) Received: from demumfd002.nsn-inter.net (demumfd002.nsn-inter.net [93.183.12.31]) by lists.linaro.org (Postfix) with ESMTPS id C5F9D618DB for ; Fri, 30 Oct 2015 13:16:10 +0000 (UTC) Received: from demuprx017.emea.nsn-intra.net ([10.150.129.56]) by demumfd002.nsn-inter.net (8.15.2/8.15.2) with ESMTPS id t9UDG9K0008089 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Oct 2015 13:16:09 GMT Received: from 10.144.19.15 ([10.144.164.243]) by demuprx017.emea.nsn-intra.net (8.12.11.20060308/8.12.11) with ESMTP id t9UDG7Nu031613 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Fri, 30 Oct 2015 14:16:09 +0100 From: Carl Wallen To: lng-odp@lists.linaro.org Date: Fri, 30 Oct 2015 15:16:07 +0200 Message-Id: <1446210967-23576-4-git-send-email-carl.wallen@nokia.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1446210967-23576-1-git-send-email-carl.wallen@nokia.com> References: <1446210967-23576-1-git-send-email-carl.wallen@nokia.com> X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 3047 X-purgate-ID: 151667::1446210969-00006110-8A90719B/0/0 X-Topics: patch Subject: [lng-odp] [PATCH 3/3] helper: linux: checkpatch cleaning for helper/linux.c X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Cleaned helper/linux.c from any further old checkpatch errors. Signed-off-by: Carl Wallen --- helper/linux.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/helper/linux.c b/helper/linux.c index 6e70206..4a8e8b3 100644 --- a/helper/linux.c +++ b/helper/linux.c @@ -35,6 +35,7 @@ static void *odp_run_start_routine(void *arg) void *ret_ptr = start_args->start_routine(start_args->arg); int ret = odp_term_local(); + if (ret < 0) ODPH_ERR("Local term failed\n"); else if (ret == 0 && odp_term_global()) @@ -43,10 +44,9 @@ static void *odp_run_start_routine(void *arg) return ret_ptr; } - int odph_linux_pthread_create(odph_linux_pthread_t *thread_tbl, - const odp_cpumask_t *mask_in, - void *(*start_routine) (void *), void *arg) + const odp_cpumask_t *mask_in, + void *(*start_routine)(void *), void *arg) { int i; int num; @@ -63,7 +63,7 @@ int odph_linux_pthread_create(odph_linux_pthread_t *thread_tbl, cpu_count = odp_cpu_count(); if (num < 1 || num > cpu_count) { - ODPH_ERR("Invalid number of threads: %d (%d cores available)\n", + ODPH_ERR("Invalid number of threads:%d (%d cores available)\n", num, cpu_count); return 0; } @@ -89,8 +89,10 @@ int odph_linux_pthread_create(odph_linux_pthread_t *thread_tbl, thread_tbl[i].start_args->start_routine = start_routine; thread_tbl[i].start_args->arg = arg; - ret = pthread_create(&thread_tbl[i].thread, &thread_tbl[i].attr, - odp_run_start_routine, thread_tbl[i].start_args); + ret = pthread_create(&thread_tbl[i].thread, + &thread_tbl[i].attr, + odp_run_start_routine, + thread_tbl[i].start_args); if (ret != 0) { ODPH_ERR("Failed to start thread on cpu #%d\n", cpu); free(thread_tbl[i].start_args); @@ -103,7 +105,6 @@ int odph_linux_pthread_create(odph_linux_pthread_t *thread_tbl, return i; } - void odph_linux_pthread_join(odph_linux_pthread_t *thread_tbl, int num) { int i; @@ -114,14 +115,13 @@ void odph_linux_pthread_join(odph_linux_pthread_t *thread_tbl, int num) ret = pthread_join(thread_tbl[i].thread, NULL); if (ret != 0) { ODPH_ERR("Failed to join thread from cpu #%d\n", - thread_tbl[i].cpu); + thread_tbl[i].cpu); } pthread_attr_destroy(&thread_tbl[i].attr); free(thread_tbl[i].start_args); } } - int odph_linux_process_fork_n(odph_linux_process_t *proc_tbl, const odp_cpumask_t *mask_in) { @@ -191,7 +191,6 @@ int odph_linux_process_fork_n(odph_linux_process_t *proc_tbl, return 1; } - int odph_linux_process_fork(odph_linux_process_t *proc, int cpu) { odp_cpumask_t mask; @@ -201,7 +200,6 @@ int odph_linux_process_fork(odph_linux_process_t *proc, int cpu) return odph_linux_process_fork_n(proc, &mask); } - int odph_linux_process_wait_n(odph_linux_process_t *proc_tbl, int num) { pid_t pid;