From patchwork Thu Oct 15 15:10:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 55041 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lf0-f72.google.com (mail-lf0-f72.google.com [209.85.215.72]) by patches.linaro.org (Postfix) with ESMTPS id 1722A2301F for ; Thu, 15 Oct 2015 15:10:50 +0000 (UTC) Received: by lffy185 with SMTP id y185sf3883467lff.2 for ; Thu, 15 Oct 2015 08:10:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=+/w/ooEJ3FV9y2PYWipZegkC2qAs+wkANbKX82saFbs=; b=XnIoVSPyy7EeGS+p4AfycwiXvs4mXZyjUpPyRV8wQlwIPA06EbyMcW2omz4IG2rhMG rhhbBKqdzPnistGKDCx2zD5Z2gMtpy1KanvIcOMXqQqDFOo+ZR8h/Fhx3TLAUvI2PwQn B3zcEcZfjgqdFJGls4nEN98ZPUHEgF4eNe4EnjsuaxoIXs/Y40k9Rno03emNi8yTWYZO Z+1HiW3K3KarODcYpcRcBj6sM8zGPoMyASDi82/5hVdx7md87CXoOzm4J9RY8eoXoJXU D5aJUzqGS1b0R6bPxR8IqgN/gSLsVR5Q05Yp6h2APZ52fIcKT+DpzwApl2Bt16EUgSnU QyAQ== X-Gm-Message-State: ALoCoQnaHcGLqfL2lBAwarlL6OeyXipZnYKFKGhbXtzaBpuWLYcJE7P0oNdZsszKacLy+fbEIOn7 X-Received: by 10.181.29.103 with SMTP id jv7mr2410742wid.0.1444921849011; Thu, 15 Oct 2015 08:10:49 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.161.20 with SMTP id k20ls167106lfe.88.gmail; Thu, 15 Oct 2015 08:10:48 -0700 (PDT) X-Received: by 10.112.161.138 with SMTP id xs10mr4770901lbb.47.1444921848853; Thu, 15 Oct 2015 08:10:48 -0700 (PDT) Received: from mail-lf0-f41.google.com (mail-lf0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id wu8si9433624lbb.57.2015.10.15.08.10.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 08:10:48 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by lfeh64 with SMTP id h64so31094553lfe.3 for ; Thu, 15 Oct 2015 08:10:48 -0700 (PDT) X-Received: by 10.25.150.199 with SMTP id y190mr3245376lfd.35.1444921848323; Thu, 15 Oct 2015 08:10:48 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp691966lbq; Thu, 15 Oct 2015 08:10:47 -0700 (PDT) X-Received: by 10.140.92.143 with SMTP id b15mr12684763qge.85.1444921847201; Thu, 15 Oct 2015 08:10:47 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id k11si13186057qgf.60.2015.10.15.08.10.46; Thu, 15 Oct 2015 08:10:47 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 7D8A861FDE; Thu, 15 Oct 2015 15:10:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 75B3161FD6; Thu, 15 Oct 2015 15:10:43 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 3CD8A61FD9; Thu, 15 Oct 2015 15:10:40 +0000 (UTC) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by lists.linaro.org (Postfix) with ESMTPS id 144B461FD6 for ; Thu, 15 Oct 2015 15:10:34 +0000 (UTC) Received: by lffv3 with SMTP id v3so31695975lff.0 for ; Thu, 15 Oct 2015 08:10:32 -0700 (PDT) X-Received: by 10.180.182.83 with SMTP id ec19mr35688508wic.35.1444921832360; Thu, 15 Oct 2015 08:10:32 -0700 (PDT) Received: from localhost.localdomain ([195.238.92.128]) by smtp.gmail.com with ESMTPSA id p2sm17017890wjb.21.2015.10.15.08.10.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Oct 2015 08:10:31 -0700 (PDT) From: Ivan Khoronzhuk To: lng-odp@lists.linaro.org Date: Thu, 15 Oct 2015 18:10:24 +0300 Message-Id: <1444921824-16599-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [PATCH RFC] Revert "platform: Makefile.inc: use `` instead of != for compatibility with older versions of Make" X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ivan.khoronzhuk@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 This reverts commit a9cc0fc700a4a8b9589404a18136b01974ca4aa3. This revert helps me to revert messages like: "fatal: No names found, cannot describe anything." in case if I build ODP outside of source catalog by: ../../odp/configure --enable-test-perf --enable-test-vald make Seems it's connected with nesting `...`. Is someone going to fix it? --- platform/Makefile.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/Makefile.inc b/platform/Makefile.inc index f64e37c..f232daa 100644 --- a/platform/Makefile.inc +++ b/platform/Makefile.inc @@ -12,6 +12,6 @@ lib_LTLIBRARIES = $(LIB)/libodp.la AM_LDFLAGS += -version-number '$(ODP_LIBSO_VERSION)' -GIT_DESC = `$(top_srcdir)/scripts/git_hash.sh` +GIT_DESC !=$(top_srcdir)/scripts/git_hash.sh AM_CFLAGS += "-DGIT_HASH=$(GIT_DESC)" AM_CFLAGS += -DPLATFORM=${with_platform}