From patchwork Fri Sep 11 10:15:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stuart Haslam X-Patchwork-Id: 53437 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by patches.linaro.org (Postfix) with ESMTPS id 0D282215BF for ; Fri, 11 Sep 2015 10:15:52 +0000 (UTC) Received: by wisv5 with SMTP id v5sf16839451wis.0 for ; Fri, 11 Sep 2015 03:15:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=v180kS32a/AwqKMippCqf/g2LfOCva+uZAOdBO45lcs=; b=KBOlApu7loZqe7AOr3rMeuw1/pxuRtGHDIBbIc0WrSvpOk8z87CrJcqtqiRfPI0NG3 eObBr4/3PewY59ThUkLbEZrcWa2PhfqrlZ1HA01PkeJT0x00ZNA9KlQTBT1w0tNKpL7M nRV7ikA4T3gzdzLnsGj7dSB+vRmUU5H+Sq+0jOnpUKK9Dc34Ui7Awk9YT1QQAkihf3Ow R/pQzDWFWYQPtoaCli+NwV3hYYr144dNy8SMEfngt2yTqn7f2HTh0zg7rKFr0Ug8CWz1 Yjsus7gni6Q2uqZjsvzF4UZuBaEZSajx4dolE1aSWe6FA1/LBJXXTRoibopaaJPbRK6D 0YIw== X-Gm-Message-State: ALoCoQmNltDZaF0lfmE1zvRiz6OZKmrgxtS7QzNRfEtsic6K1DJbP9rEbV+KV1btiZ0HSw9vnW8G X-Received: by 10.180.10.202 with SMTP id k10mr1079462wib.2.1441966551365; Fri, 11 Sep 2015 03:15:51 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.4.227 with SMTP id n3ls316545lan.0.gmail; Fri, 11 Sep 2015 03:15:51 -0700 (PDT) X-Received: by 10.152.43.228 with SMTP id z4mr36829285lal.99.1441966551193; Fri, 11 Sep 2015 03:15:51 -0700 (PDT) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id t1si530079lae.137.2015.09.11.03.15.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Sep 2015 03:15:51 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by lamp12 with SMTP id p12so44181734lam.0 for ; Fri, 11 Sep 2015 03:15:51 -0700 (PDT) X-Received: by 10.112.129.202 with SMTP id ny10mr16621597lbb.112.1441966551032; Fri, 11 Sep 2015 03:15:51 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp1489103lbq; Fri, 11 Sep 2015 03:15:50 -0700 (PDT) X-Received: by 10.140.31.135 with SMTP id f7mr60758887qgf.11.1441966549335; Fri, 11 Sep 2015 03:15:49 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id h12si555234qhc.71.2015.09.11.03.15.48; Fri, 11 Sep 2015 03:15:49 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 487FD61900; Fri, 11 Sep 2015 10:15:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3D6486157E; Fri, 11 Sep 2015 10:15:45 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id C9C2161822; Fri, 11 Sep 2015 10:15:43 +0000 (UTC) Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by lists.linaro.org (Postfix) with ESMTPS id 0186B61570 for ; Fri, 11 Sep 2015 10:15:43 +0000 (UTC) Received: by wicfx3 with SMTP id fx3so52580636wic.0 for ; Fri, 11 Sep 2015 03:15:42 -0700 (PDT) X-Received: by 10.194.71.107 with SMTP id t11mr30906363wju.142.1441966542181; Fri, 11 Sep 2015 03:15:42 -0700 (PDT) Received: from e106441.emea.arm.com ([2001:41d0:a:3cb4::abcd]) by smtp.gmail.com with ESMTPSA id j7sm1025236wjz.11.2015.09.11.03.15.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Sep 2015 03:15:41 -0700 (PDT) From: Stuart Haslam To: lng-odp@lists.linaro.org Date: Fri, 11 Sep 2015 11:15:02 +0100 Message-Id: <1441966502-20651-1-git-send-email-stuart.haslam@linaro.org> X-Mailer: git-send-email 2.1.1 X-Topics: patch Subject: [lng-odp] [PATCH] linux-generic: queue: fix pktout_enqueue() logic X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: stuart.haslam@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Fix inverted logic when checking the return value of pktout_enqueue. Signed-off-by: Stuart Haslam --- platform/linux-generic/odp_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 99a663d..95a2df8 100644 --- a/platform/linux-generic/odp_queue.c +++ b/platform/linux-generic/odp_queue.c @@ -758,7 +758,7 @@ int queue_pktout_enq(queue_entry_t *queue, odp_buffer_hdr_t *buf_hdr, return -1; } else { rc = pktout_enqueue(queue, buf_hdr); - if (!rc) + if (rc) return rc; }