From patchwork Tue Sep 1 20:00:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 52946 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by patches.linaro.org (Postfix) with ESMTPS id A3A012300F for ; Tue, 1 Sep 2015 20:00:39 +0000 (UTC) Received: by wicjd9 with SMTP id jd9sf15359197wic.2 for ; Tue, 01 Sep 2015 13:00:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:subject:precedence:list-id:list-unsubscribe:list-archive :list-post:list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=QjNIXsY2AB+LhDB4KsaCRH4BIcNn7NVgrt/SCH2YePQ=; b=OZK5IdNls8/C/A+OMnzWxmM4uvUiKkge3pnw71diFm45xXAiBkkCtg9M/Xn+2iLTAZ HpMyB4TG7hOUKnMo6WeSoI7dtH5Asol8hEas+1dyNcX/g7uo1kbabRgN8nw6CtmienzC 2ys8EURIw0B+39rZV/JKWyAMSZBFgtUJRMsv7ic00fK28hL574lJbZX1QMRMuP7+cz1k 86naun/6/GW58XNEy6hK4NTDUcdSxfYEUQAAbD+n7+NHEwWnHXs/AnWIOtv+RG9h4dKb jci+IwqJnNJU3Jt96mFzOf8fm2JKUFzmPsL2B0jpeoYW+rkpiGg+3lJMV3kShaB1SvWU mhzA== X-Gm-Message-State: ALoCoQnujXHyk73zoITxgqGqtBvUM6j+CrW0V+iBL23WquZoSHF19ru4ACAJqBee659KqYwd/2Y9 X-Received: by 10.112.172.70 with SMTP id ba6mr7852079lbc.1.1441137638836; Tue, 01 Sep 2015 13:00:38 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.21.100 with SMTP id u4ls646395lae.51.gmail; Tue, 01 Sep 2015 13:00:38 -0700 (PDT) X-Received: by 10.152.8.233 with SMTP id u9mr14302592laa.8.1441137638695; Tue, 01 Sep 2015 13:00:38 -0700 (PDT) Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com. [209.85.217.180]) by mx.google.com with ESMTPS id zd10si17413571lbb.169.2015.09.01.13.00.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Sep 2015 13:00:38 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) client-ip=209.85.217.180; Received: by lbcjc2 with SMTP id jc2so6209563lbc.0 for ; Tue, 01 Sep 2015 13:00:38 -0700 (PDT) X-Received: by 10.112.209.106 with SMTP id ml10mr13784664lbc.112.1441137638313; Tue, 01 Sep 2015 13:00:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp85428lbb; Tue, 1 Sep 2015 13:00:37 -0700 (PDT) X-Received: by 10.140.147.69 with SMTP id 66mr53131318qht.57.1441137637140; Tue, 01 Sep 2015 13:00:37 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id 141si22716638qhx.82.2015.09.01.13.00.36; Tue, 01 Sep 2015 13:00:37 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 2D5EF6183D; Tue, 1 Sep 2015 20:00:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A72A2611F2; Tue, 1 Sep 2015 20:00:31 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 481D96158A; Tue, 1 Sep 2015 20:00:25 +0000 (UTC) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com [209.85.217.179]) by lists.linaro.org (Postfix) with ESMTPS id 5DC3D61105 for ; Tue, 1 Sep 2015 20:00:24 +0000 (UTC) Received: by lbcao8 with SMTP id ao8so6069840lbc.3 for ; Tue, 01 Sep 2015 13:00:22 -0700 (PDT) X-Received: by 10.112.47.73 with SMTP id b9mr13925479lbn.46.1441137622815; Tue, 01 Sep 2015 13:00:22 -0700 (PDT) Received: from localhost.localdomain (ppp91-76-161-180.pppoe.mtu-net.ru. [91.76.161.180]) by smtp.gmail.com with ESMTPSA id g1sm5014641lam.30.2015.09.01.13.00.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 01 Sep 2015 13:00:22 -0700 (PDT) From: Maxim Uvarov To: lng-odp@lists.linaro.org Date: Tue, 1 Sep 2015 23:00:16 +0300 Message-Id: <1441137616-2970-1-git-send-email-maxim.uvarov@linaro.org> X-Mailer: git-send-email 1.9.1 X-Topics: patch Subject: [lng-odp] [PATCH] linux-generic: queue: add missing release lock in release_order() X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: maxim.uvarov@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.180 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 schedule test can hang deadlock in due to missing spin unlock. Signed-off-by: Maxim Uvarov --- platform/linux-generic/odp_queue.c | 1 + 1 file changed, 1 insertion(+) diff --git a/platform/linux-generic/odp_queue.c b/platform/linux-generic/odp_queue.c index 1bd0de6..bc59d88 100644 --- a/platform/linux-generic/odp_queue.c +++ b/platform/linux-generic/odp_queue.c @@ -941,6 +941,7 @@ int release_order(queue_entry_t *origin_qe, uint64_t order, if (reorder_buf && reorder_buf->order == order) { reorder_buf->flags.sustain = 0; + UNLOCK(&origin_qe->s.lock); return 0; } }