From patchwork Fri Jul 3 11:49:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 50625 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8366922916 for ; Fri, 3 Jul 2015 11:53:24 +0000 (UTC) Received: by wgjx7 with SMTP id x7sf29288285wgj.3 for ; Fri, 03 Jul 2015 04:53:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=6jM7iiepHVP9iL+YOMsMHmsAracF2ABqArAFxcZ7yxc=; b=fzNmMY4g0pBkj0IRqli2Cit4pR2vnO8Djst2gdDtPHtzT1h5ukpjn53XFm9vlnyR0E Hk0cprZvIC9z6s0WPCtqAgylOFX9nLYEKUi+ex4dywbZnJmhIRYvWvX3elO+mbuSAJ0Y 0Hy3jARTm/X/IL6y6C9ckwWjxdPDHOs1XopQJXZ5gSZbh16duNvC23295oPC0A9mkJN+ TdUBQzT9MwmeKiCHBpaFhX3C8Y0xuRLum9UvsG/U57R1keU21rsLhw5CdqNr3ywdCyVn u03ZLT9N/cq8MgHEEzjs5I5F/8EUNj/0oX5YCQCr5tWUf2Nb9uiwYN549vo+MfaXN6rR aqKw== X-Gm-Message-State: ALoCoQnCayMOqedrE+HjP8PCUobZYEDARGcub+b2/ahP5de2X/4owJ0lVA2ELZkg8NOwzJ4pi+lo X-Received: by 10.152.22.163 with SMTP id e3mr15869491laf.6.1435924403837; Fri, 03 Jul 2015 04:53:23 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.20.10 with SMTP id j10ls495480lae.6.gmail; Fri, 03 Jul 2015 04:53:23 -0700 (PDT) X-Received: by 10.112.105.104 with SMTP id gl8mr35703995lbb.81.1435924403625; Fri, 03 Jul 2015 04:53:23 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id cn6si7013427lbb.126.2015.07.03.04.53.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jul 2015 04:53:23 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by lagh6 with SMTP id h6so82319177lag.2 for ; Fri, 03 Jul 2015 04:53:23 -0700 (PDT) X-Received: by 10.112.93.37 with SMTP id cr5mr35757671lbb.106.1435924403180; Fri, 03 Jul 2015 04:53:23 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1132945lbb; Fri, 3 Jul 2015 04:53:22 -0700 (PDT) X-Received: by 10.140.34.135 with SMTP id l7mr33466596qgl.79.1435924398027; Fri, 03 Jul 2015 04:53:18 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id h4si10044250qge.80.2015.07.03.04.52.47; Fri, 03 Jul 2015 04:53:18 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id D12456205D; Fri, 3 Jul 2015 11:52:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3042B61DB1; Fri, 3 Jul 2015 11:51:15 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7845C61DB1; Fri, 3 Jul 2015 11:51:11 +0000 (UTC) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com [209.85.215.45]) by lists.linaro.org (Postfix) with ESMTPS id 81C4362057 for ; Fri, 3 Jul 2015 11:50:01 +0000 (UTC) Received: by lagx9 with SMTP id x9so82292816lag.1 for ; Fri, 03 Jul 2015 04:50:00 -0700 (PDT) X-Received: by 10.152.121.99 with SMTP id lj3mr34556312lab.37.1435924200458; Fri, 03 Jul 2015 04:50:00 -0700 (PDT) Received: from erachmi-VirtualBox.ki.sw.ericsson.se (c-83-233-90-46.cust.bredband2.com. [83.233.90.46]) by mx.google.com with ESMTPSA id w6sm2271047lbs.37.2015.07.03.04.49.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Jul 2015 04:49:59 -0700 (PDT) From: Christophe Milard To: anders.roxell@linaro.org, mike.holmes@linaro.org, stuart.haslam@linaro.org, maxim.uvarov@linaro.org Date: Fri, 3 Jul 2015 13:49:37 +0200 Message-Id: <1435924179-30967-5-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435924179-30967-1-git-send-email-christophe.milard@linaro.org> References: <1435924179-30967-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCH 4/6] validation: renaming in system.c X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christophe.milard@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future tests better. Things that are candidate to be exported in the lib in the future have been named as follows: -Tests, i.e. functions which are used in CUNIT testsuites are named: _test_* -Test arrays, i.e. arrays of CU_TestInfo, listing the test functions belonging to a suite, are called: _suite[_*] where the possible suffix can be used if many suites are declared. -CUNIT suite init and termination functions are called: _suite[_*]_init() and _suite[_*]_term() respectively. -Suite arrays, i.e. arrays of CU_SuiteInfo used in executables are called: _suites[_*] where the possible suffix identifies the executable using it, if many. -Main function(s), are called: _main[_*] where the possible suffix identifies the executable using it Signed-off-by: Christophe Milard --- test/validation/system/system.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/test/validation/system/system.c b/test/validation/system/system.c index 212dba9..77afa97 100644 --- a/test/validation/system/system.c +++ b/test/validation/system/system.c @@ -9,7 +9,7 @@ #include "odp_cunit_common.h" #include "test_debug.h" -static void test_odp_version_numbers(void) +static void system_test_odp_version_numbers(void) { int char_ok; char version_string[128]; @@ -31,7 +31,7 @@ static void test_odp_version_numbers(void) CU_ASSERT(char_ok); } -static void test_odp_cpu_count(void) +static void system_test_odp_cpu_count(void) { int cpus; @@ -39,7 +39,7 @@ static void test_odp_cpu_count(void) CU_ASSERT(0 < cpus); } -static void test_odp_sys_cache_line_size(void) +static void system_test_odp_sys_cache_line_size(void) { uint64_t cache_size; @@ -48,7 +48,7 @@ static void test_odp_sys_cache_line_size(void) CU_ASSERT(ODP_CACHE_LINE_SIZE == cache_size); } -static void test_odp_sys_cpu_model_str(void) +static void system_test_odp_sys_cpu_model_str(void) { char model[128]; @@ -57,7 +57,7 @@ static void test_odp_sys_cpu_model_str(void) CU_ASSERT(strlen(model) < 127); } -static void test_odp_sys_page_size(void) +static void system_test_odp_sys_page_size(void) { uint64_t page; @@ -66,7 +66,7 @@ static void test_odp_sys_page_size(void) CU_ASSERT(ODP_PAGE_SIZE == page); } -static void test_odp_sys_huge_page_size(void) +static void system_test_odp_sys_huge_page_size(void) { uint64_t page; @@ -74,7 +74,7 @@ static void test_odp_sys_huge_page_size(void) CU_ASSERT(0 < page); } -static void test_odp_sys_cpu_hz(void) +static void system_test_odp_sys_cpu_hz(void) { uint64_t hz; @@ -82,19 +82,19 @@ static void test_odp_sys_cpu_hz(void) CU_ASSERT(0 < hz); } -static CU_TestInfo test_odp_system[] = { - {"odp version", test_odp_version_numbers}, - {"odp_cpu_count", test_odp_cpu_count}, - {"odp_sys_cache_line_size", test_odp_sys_cache_line_size}, - {"odp_sys_cpu_model_str", test_odp_sys_cpu_model_str}, - {"odp_sys_page_size", test_odp_sys_page_size}, - {"odp_sys_huge_page_size", test_odp_sys_huge_page_size}, - {"odp_sys_cpu_hz", test_odp_sys_cpu_hz}, +static CU_TestInfo system_suite[] = { + {"odp version", system_test_odp_version_numbers}, + {"odp_cpu_count", system_test_odp_cpu_count}, + {"odp_sys_cache_line_size", system_test_odp_sys_cache_line_size}, + {"odp_sys_cpu_model_str", system_test_odp_sys_cpu_model_str}, + {"odp_sys_page_size", system_test_odp_sys_page_size}, + {"odp_sys_huge_page_size", system_test_odp_sys_huge_page_size}, + {"odp_sys_cpu_hz", system_test_odp_sys_cpu_hz}, CU_TEST_INFO_NULL, }; static CU_SuiteInfo system_suites[] = { - {"System Info", NULL, NULL, NULL, NULL, test_odp_system}, + {"System Info", NULL, NULL, NULL, NULL, system_suite}, CU_SUITE_INFO_NULL, };