From patchwork Mon Jun 29 15:39:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 50433 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f70.google.com (mail-wg0-f70.google.com [74.125.82.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 28777228D9 for ; Mon, 29 Jun 2015 15:40:57 +0000 (UTC) Received: by wgfk9 with SMTP id k9sf589067wgf.1 for ; Mon, 29 Jun 2015 08:40:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=pCzxSsTaNNxOSTjzJj5PUuUbnjDaXsPFGabpGDGQ9do=; b=StlG6r8s1Ygv4AOwapW5oy3UUwgJq2vJBI7rAzpWoOV0rTlibOXPM8UrjWsATFsyi+ L5PFCqyqAN4BMyXo8ipdpG3ffuG09BIb4L9bx2eBU2j7MxU1tUVYCcnekv+JYIs9oMf4 TR5LYB1AU0ghp0TJHuGDN8+FRh5eQIeEAARJ6bsBj/OKuCGcCpQLcu9dGk4FHDSKJfV2 H73ox8YoJa110GpCdqTtrmDbNPnEpI5WIl6obnEwQH/gSircqT31ooJAOMVVSNUn4k+4 Ba9MMY8TyFoTWcFTOsU7ltj5UnJzSYUyKF8Z+ZK1mfZtQeQSrwSbVHYkBfiZYHTQyvYb iL+A== X-Gm-Message-State: ALoCoQmEO49OfQ0OGPOA6Xsl8mpTDaCrFXUgmt2F4vB7iaqJIxomz0acOo8kBsoJ+1r16vrDfUG2 X-Received: by 10.112.42.236 with SMTP id r12mr11320842lbl.2.1435592456421; Mon, 29 Jun 2015 08:40:56 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.167 with SMTP id t7ls196721lat.47.gmail; Mon, 29 Jun 2015 08:40:56 -0700 (PDT) X-Received: by 10.112.35.229 with SMTP id l5mr10683529lbj.0.1435592456269; Mon, 29 Jun 2015 08:40:56 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id l7si35333732lae.121.2015.06.29.08.40.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 08:40:56 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by lagx9 with SMTP id x9so130513461lag.1 for ; Mon, 29 Jun 2015 08:40:56 -0700 (PDT) X-Received: by 10.152.4.163 with SMTP id l3mr15020388lal.35.1435592456110; Mon, 29 Jun 2015 08:40:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1791843lbb; Mon, 29 Jun 2015 08:40:55 -0700 (PDT) X-Received: by 10.140.216.18 with SMTP id m18mr21226545qhb.19.1435592454619; Mon, 29 Jun 2015 08:40:54 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id f5si42052023qhc.72.2015.06.29.08.40.53; Mon, 29 Jun 2015 08:40:54 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id DE4B661E00; Mon, 29 Jun 2015 15:40:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 3585D61D88; Mon, 29 Jun 2015 15:40:23 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0EC0B61E0B; Mon, 29 Jun 2015 15:40:16 +0000 (UTC) Received: from mail-la0-f53.google.com (mail-la0-f53.google.com [209.85.215.53]) by lists.linaro.org (Postfix) with ESMTPS id 65A2161DFE for ; Mon, 29 Jun 2015 15:39:47 +0000 (UTC) Received: by lagh6 with SMTP id h6so58639383lag.2 for ; Mon, 29 Jun 2015 08:39:46 -0700 (PDT) X-Received: by 10.152.42.134 with SMTP id o6mr14901205lal.14.1435592386096; Mon, 29 Jun 2015 08:39:46 -0700 (PDT) Received: from erachmi-VirtualBox.ki.sw.ericsson.se (c-83-233-90-46.cust.bredband2.com. [83.233.90.46]) by mx.google.com with ESMTPSA id q9sm10847143lag.20.2015.06.29.08.39.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 29 Jun 2015 08:39:45 -0700 (PDT) From: Christophe Milard To: anders.roxell@linaro.org, mike.holmes@linaro.org, stuart.haslam@linaro.org, maxim.uvarov@linaro.org Date: Mon, 29 Jun 2015 17:39:31 +0200 Message-Id: <1435592374-3517-3-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435592374-3517-1-git-send-email-christophe.milard@linaro.org> References: <1435592374-3517-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCHv2 2/5] validation: renaming in odp_queue.c X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christophe.milard@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future tests better. Things that are candidate to be exported in the lib in the future have been named as follows: -Tests, i.e. functions which are used in CUNIT testsuites are named: _test_* -Test arrays, i.e. arrays of CU_TestInfo, listing the test functions belonging to a suite, are called: _suite[_*] where the possible suffix can be used if many suites are declared. -CUNIT suite init and termination functions are called: _suite[_*]_init() and _suite[_*]_term() respectively. -Suite arrays, i.e. arrays of CU_SuiteInfo used in executables are called: _suites[_*] where the possible suffix identifies the executable using it, if many. -Main function(s), are called: _main[_*] where the possible suffix identifies the executable using it Signed-off-by: Christophe Milard Reviewed-by: Stuart Haslam --- test/validation/odp_queue.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/validation/odp_queue.c b/test/validation/odp_queue.c index e944677..9f17743 100644 --- a/test/validation/odp_queue.c +++ b/test/validation/odp_queue.c @@ -14,7 +14,7 @@ static int queue_contest = 0xff; static odp_pool_t pool; -static int init_queue_suite(void) +static int queue_suite_init(void) { odp_pool_param_t params; @@ -32,12 +32,12 @@ static int init_queue_suite(void) return 0; } -static int init_queue_finalize(void) +static int queue_suite_term(void) { return odp_pool_destroy(pool); } -static void test_odp_queue_sunnyday(void) +static void queue_test_sunnydays(void) { odp_queue_t queue_creat_id, queue_id; odp_event_t enev[MAX_BUFFER_QUEUE]; @@ -107,14 +107,14 @@ static void test_odp_queue_sunnyday(void) return; } -static CU_TestInfo test_odp_queue[] = { - {"queue sunnyday", test_odp_queue_sunnyday}, +static CU_TestInfo queue_suite[] = { + {"queue sunnyday", queue_test_sunnydays}, CU_TEST_INFO_NULL, }; static CU_SuiteInfo queue_suites[] = { - {"Queue", init_queue_suite, init_queue_finalize, - NULL, NULL, test_odp_queue}, + {"Queue", queue_suite_init, queue_suite_term, + NULL, NULL, queue_suite}, CU_SUITE_INFO_NULL, };