From patchwork Thu Jun 25 14:42:16 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 50328 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f197.google.com (mail-wi0-f197.google.com [209.85.212.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C345322907 for ; Thu, 25 Jun 2015 14:44:25 +0000 (UTC) Received: by wilk19 with SMTP id k19sf22328148wil.3 for ; Thu, 25 Jun 2015 07:44:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :mime-version:content-type:content-transfer-encoding:errors-to :sender:x-original-sender:x-original-authentication-results :mailing-list; bh=kFg3k06ZTqglSvndgGhTwPy6XhzOPGsbpn1LQR2m4xE=; b=VJbOn9qBkbczwMlFdQYmY6VgBHZZOmkIwqb96pUsEMdtLL7+MzMR0BexP5XKIo53Es M2iBR1HMuB7sFocVMWulpmhSX3atbNV6MNukhJplpj+B3PaiAAV6xnFHZYXO39fyLGDB UhXKvth49WrC8xucK6K29El+MuxWWK9d8AmWsuhzvuwunpGycCL/rHtBXa5XBouArUn1 WPiq7Q4NnRov/GLqDZ9jiB9qgnGnyaeAszu1ZkLKnk7ZjxGcgY8GMBKtCeou1E+XXORq N4rHqZxUnjqabWCLnfpHcwLRO4seE6W2djQD9uhS4aa+rhKNxitPb0fjUr1AuaLNp6Rt XY9A== X-Gm-Message-State: ALoCoQkJfkVNqtLN1O0UsqBRu6P7OKAMySiTRtjHLphQsGAqm3+H1RXAt2XE5cBRHVrmdA6cDB2v X-Received: by 10.152.219.166 with SMTP id pp6mr40062073lac.1.1435243465113; Thu, 25 Jun 2015 07:44:25 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.88.70 with SMTP id be6ls336274lab.103.gmail; Thu, 25 Jun 2015 07:44:24 -0700 (PDT) X-Received: by 10.152.21.193 with SMTP id x1mr1862618lae.94.1435243464964; Thu, 25 Jun 2015 07:44:24 -0700 (PDT) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com. [209.85.217.178]) by mx.google.com with ESMTPS id m18si725223lbg.157.2015.06.25.07.44.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jun 2015 07:44:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by lbnk3 with SMTP id k3so47019360lbn.1 for ; Thu, 25 Jun 2015 07:44:24 -0700 (PDT) X-Received: by 10.152.37.228 with SMTP id b4mr44677080lak.117.1435243464669; Thu, 25 Jun 2015 07:44:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp654928lbb; Thu, 25 Jun 2015 07:44:23 -0700 (PDT) X-Received: by 10.55.26.133 with SMTP id l5mr78960626qkh.40.1435243462802; Thu, 25 Jun 2015 07:44:22 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id w94si29522164qge.60.2015.06.25.07.44.21; Thu, 25 Jun 2015 07:44:22 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id B5D2161E70; Thu, 25 Jun 2015 14:44:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 6EA6361E49; Thu, 25 Jun 2015 14:43:09 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 0157C61E8B; Thu, 25 Jun 2015 14:43:05 +0000 (UTC) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com [209.85.215.44]) by lists.linaro.org (Postfix) with ESMTPS id 2044961DFC for ; Thu, 25 Jun 2015 14:42:37 +0000 (UTC) Received: by lacny3 with SMTP id ny3so46310229lac.3 for ; Thu, 25 Jun 2015 07:42:36 -0700 (PDT) X-Received: by 10.152.27.1 with SMTP id p1mr44630778lag.112.1435243356052; Thu, 25 Jun 2015 07:42:36 -0700 (PDT) Received: from erachmi-VirtualBox.ki.sw.ericsson.se (c-83-233-90-46.cust.bredband2.com. [83.233.90.46]) by mx.google.com with ESMTPSA id lb8sm4057655lab.16.2015.06.25.07.42.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 25 Jun 2015 07:42:35 -0700 (PDT) From: Christophe Milard To: anders.roxell@linaro.org, mike.holmes@linaro.org, stuart.haslam@linaro.org, maxim.uvarov@linaro.org Date: Thu, 25 Jun 2015 16:42:16 +0200 Message-Id: <1435243338-29958-3-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1435243338-29958-1-git-send-email-christophe.milard@linaro.org> References: <1435243338-29958-1-git-send-email-christophe.milard@linaro.org> X-Topics: patch Cc: lng-odp@lists.linaro.org Subject: [lng-odp] [PATCHv2 2/4] validation: renaming in odp_pool.c X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: christophe.milard@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future tests better. Things that are candidate to be exported in the lib in the future have been named as follows: -Tests, i.e. functions which are used in CUNIT testsuites are named: _test_* -Test arrays, i.e. arrays of CU_TestInfo, listing the test functions belonging to a suite, are called: _suite[_*] where the possible suffix can be used if many suites are declared. -CUNIT suite init and termination functions are called: _suite[_*]_init() and _suite[_*]_term() respectively. -Suite arrays, i.e. arrays of CU_SuiteInfo used in executables are called: _suites[_*] where the possible suffix identifies the executable using it, if many. -Main function(s), are called: _main[_*] where the possible suffix identifies the executable using it Signed-off-by: Christophe Milard --- test/validation/odp_pool.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/test/validation/odp_pool.c b/test/validation/odp_pool.c index 4379eb5..ba5dc79 100644 --- a/test/validation/odp_pool.c +++ b/test/validation/odp_pool.c @@ -26,7 +26,7 @@ static void pool_create_destroy(odp_pool_param_t *params) CU_ASSERT(odp_pool_destroy(pool) == 0); } -static void pool_create_destroy_buffer(void) +static void pool_test_create_destroy_buffer(void) { odp_pool_param_t params = { .buf = { @@ -40,7 +40,7 @@ static void pool_create_destroy_buffer(void) pool_create_destroy(¶ms); } -static void pool_create_destroy_packet(void) +static void pool_test_create_destroy_packet(void) { odp_pool_param_t params = { .pkt = { @@ -54,7 +54,7 @@ static void pool_create_destroy_packet(void) pool_create_destroy(¶ms); } -static void pool_create_destroy_timeout(void) +static void pool_test_create_destroy_timeout(void) { odp_pool_param_t params = { .tmo = { @@ -66,7 +66,7 @@ static void pool_create_destroy_timeout(void) pool_create_destroy(¶ms); } -static void pool_create_destroy_buffer_shm(void) +static void pool_test_create_destroy_buffer_shm(void) { odp_pool_t pool; odp_shm_t test_shm; @@ -92,7 +92,7 @@ static void pool_create_destroy_buffer_shm(void) CU_ASSERT(odp_shm_free(test_shm) == 0); } -static void pool_lookup_info_print(void) +static void pool_test_lookup_info_print(void) { odp_pool_t pool; const char pool_name[] = "pool_for_lookup_test"; @@ -127,18 +127,18 @@ static void pool_lookup_info_print(void) #define _CU_TEST_INFO(test_func) {#test_func, test_func} -static CU_TestInfo pool_tests[] = { - _CU_TEST_INFO(pool_create_destroy_buffer), - _CU_TEST_INFO(pool_create_destroy_packet), - _CU_TEST_INFO(pool_create_destroy_timeout), - _CU_TEST_INFO(pool_create_destroy_buffer_shm), - _CU_TEST_INFO(pool_lookup_info_print), +static CU_TestInfo pool_suite[] = { + _CU_TEST_INFO(pool_test_create_destroy_buffer), + _CU_TEST_INFO(pool_test_create_destroy_packet), + _CU_TEST_INFO(pool_test_create_destroy_timeout), + _CU_TEST_INFO(pool_test_create_destroy_buffer_shm), + _CU_TEST_INFO(pool_test_lookup_info_print), CU_TEST_INFO_NULL, }; static CU_SuiteInfo pool_suites[] = { { .pName = "Pool tests", - .pTests = pool_tests, + .pTests = pool_suite, }, CU_SUITE_INFO_NULL, };